Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [recommenders-dev] CodeSearch Incubator - Progress

Hi Andreas,

All the changes are now working fine. Thanks for the tip about Rebase button in Gerrit. :) It worked for one change, but denied for the other due to conflicts. I re-commited those changes again and submitted to gerrit [1].

BTW my given name is "Kavith Thiranga" and family name is "Lokuhewage". :)


On Tue, Aug 27, 2013 at 7:12 PM, Andreas Sewe <andreas.sewe@xxxxxxxxxxxxxx> wrote:
Hi Kavith,

> I managed to upload the patch set 7 [1] with fixing all the check style
> errors. Now the hudson CI build doesn't give check style errors[2]. But
> it gives the license headers warnings.

yes, I just fixed those by including both you and Tobias (the original
author of Codesearch) in releng/licenses/resources. Have a look there
[1] how license headers have to look like if you are the author (I
assume Kavith is your given name and Thiranga your family name, right?)

Anyway, if you now rebase [2] and dependent commits once more, they
should build (and hopefully succeed) on Hudson. (BTW, Gerrit has a
"rebase" button somewhere, so you don't have to use the Git command line
in many cases.)

Hope this helps.

Andreas

[1]
<https://git.eclipse.org/r/#/c/15779/8/releng/licenses/resources/license-thiranga-2013.txt>
[2] <https://git.eclipse.org/r/#/c/15842/>

--
Codetrails UG (haftungsbeschränkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Mobile: +49-170-811-3791
http://www.codetrails.com/

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev



--
Kavith Thiranga Lokuhewage,
Undergraduate,
BEng (Hons) Software Engineering,
Staffordshire University, UK.
APIIT Sri Lanka.

Linkedin  Twitter


Back to the top