Re: [recommenders-dev] CodeSearch Incubator - Progress

[kavith Thiranga <rc404mekt@xxxxxxxxx>]

Hi Andreas,

I managed to upload the patch set 7 [1] with fixing all the check style errors. Now the hudson CI build doesn't give check style errors[2]. But it gives the license headers warnings.

[1.] https://git.eclipse.org/r/#/c/15779/

[2.] https://hudson.eclipse.org/recommenders/job/codesearch.gerrit.master/17/console

Thanks

On Mon, Aug 26, 2013 at 11:49 PM, kavith Thiranga <rc404mekt@xxxxxxxxx> wrote:

Hi Andreas,

I am currently having several conflicts in rebasing and I think I have messed things up. :) Didn't had so much advanced experience with git. Anyway is it ok to rebase my previous three changes on to your patch set six and then apply check style errors fixed commit finally? I guess doing this will result in a new review in gerrit rather than a patch set for your change.

is it OK?

Thanks.

On Mon, Aug 26, 2013 at 7:34 PM, Andreas Sewe <andreas.sewe@xxxxxxxxxxxxxx> wrote:

Hi Kavith,

I have updated my change set [1]. Can you make sure that it doesn't show
checkstyle errors anymore [2].

> I got rid of the all style errors with Maven build. But now I am getting
> a lot of error lines saying the license header is missing. But I can see
> the license header in the relevant files.

Yes, the "problem" is that there is a hard-coded list of authors that
the build checks for. We need to expand that list.

But, first, can you amend this commit [1] (git amend, in case you don't
know it) so that it builds cleanly on our Hudson CI server. Thereafter,
we can tackle the license header and merge your other changes.

Thank you.

Andreas

[1] <https://git.eclipse.org/r/#/c/15779/>
[2]
<https://hudson.eclipse.org/recommenders/job/codesearch.gerrit.master/16/console>

--
Codetrails UG (haftungsbeschränkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Mobile: +49-170-811-3791
http://www.codetrails.com/

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev

--

Kavith Thiranga Lokuhewage,
Undergraduate,
BEng (Hons) Software Engineering,
Staffordshire University, UK.

APIIT Sri Lanka.

Linkedin  Twitter

--

Kavith Thiranga Lokuhewage,
Undergraduate,
BEng (Hons) Software Engineering,
Staffordshire University, UK.

APIIT Sri Lanka.

Linkedin  Twitter