Community
Participate
Working Groups
Created attachment 276072 [details] background 1 The background color of toolbars in views (eg: Project Explorer, Package Explorer etc) has a different background in the dark theme. The toolbar background doesn't follows the background of its parent.
Created attachment 276073 [details] background 2
If someone can point me out how i should approach this i can find my way and provide a gerrit patch. I tried altering the css but seems like the toolbars are not blending-in with the original gradient of the CTabFolder header. May be because that gradient is some what painted by the CTabFolder Renderer ?
(In reply to Gayan Perera from comment #2) > If someone can point me out how i should approach this i can find my way and > provide a gerrit patch. I tried altering the css but seems like the toolbars > are not blending-in with the original gradient of the CTabFolder header. May > be because that gradient is some what painted by the CTabFolder Renderer ? Maybe the layout spy or the CSS spy helps? See http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#layout-spy-for-layout-information http://www.vogella.com/tutorials/Eclipse4CSS/article.html#css-spy
Mass change, please reset target if you still planning to fix this for 4.11.
Best approach seems to be to inherit the colors from the parent for toolbar entries instead of setting a color. Gerrit upcoming.
Created attachment 278008 [details] Left with inherit - right with the old hard coded colors
New Gerrit change created: https://git.eclipse.org/r/139479
Created attachment 278010 [details] Before on macOS
Created attachment 278011 [details] Screenshot after on macOS
I tested on macOS. Is looks so much better with this patch. @Gayan: Thank you for reporting. @Lars: Thank you for fixing.
Its working on windows and linux as expected, Thanks @Lars :)
Thanks to Matthias and Gayan for the fast feedback and the test of the patch
Gerrit change https://git.eclipse.org/r/139479 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=25715a37d79ac0b1a79852355f72a31e4095fda9
New Gerrit change created: https://git.eclipse.org/r/139520
Gerrit change https://git.eclipse.org/r/139520 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8d62ffdaf67611ece2cbba28f3f2b92748e978d2
(In reply to Eclipse Genie from comment #13) > Gerrit change https://git.eclipse.org/r/139479 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=25715a37d79ac0b1a79852355f72a31e4095fda9 After this change, the background in the "Search" Dialog is white in many places in the dark design (on macOS 10.14.3). If I switch tabs and back, it gets corrected.
Created attachment 278039 [details] screenshot of search dialog
Its same on windows as well :(.
Currently fighting an infection, not sure when I will be able to look it this. Feel free to revert if necessary.
Also reproducible on Linux, investigating this now.
New Gerrit change created: https://git.eclipse.org/r/139886
(In reply to Eclipse Genie from comment #21) > New Gerrit change created: https://git.eclipse.org/r/139886 This should fix the Search Dialog (and break again the toolbar colors). Till, can you please test? For the toolbar Composite color I most likely need to set an CSS class to target it.
Its strange how toolbar selector effects the composites in the search dialog :(
New Gerrit change created: https://git.eclipse.org/r/139904
Gerrit change https://git.eclipse.org/r/139886 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0ebba77bf2bfbd239a21f30d0fa176eaa976f5d0
(In reply to Gayan Perera from comment #23) > Its strange how toolbar selector effects the composites in the search dialog > :( CTabFolder > Composite > * is unfortunately not limited to the toolbar.
New Gerrit change created: https://git.eclipse.org/r/139907
Note for myself, the view toolbar color comes from @import url("platform:/plugin/org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css"); If I remove that import the view toolbar item looks good.
New Gerrit change created: https://git.eclipse.org/r/139926
Created attachment 278124 [details] Screenshot for https://git.eclipse.org/r/#/c/139926/ With https://git.eclipse.org/r/#/c/139926/ I think the toolbar styling looks really good. Tested on Linux.
Created attachment 278127 [details] screenshots for https://git.eclipse.org/r/#/c/139926/ on macOS
(In reply to Matthias Becker from comment #31) > Created attachment 278127 [details] > screenshots for https://git.eclipse.org/r/#/c/139926/ on macOS Tested https://git.eclipse.org/r/#/c/139926/ on macOS. It looks like this on macOS. I like it.
Gerrit change https://git.eclipse.org/r/139907 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fafccbc129384052e6279cfed4d6f67432e10179
Gerrit change https://git.eclipse.org/r/139926 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=30c22ee588c542bc8afdd65e17f1dd8276dbfba8
Thanks, Matthias for verification. Also thanks to Till for reporting the issue with the search dialog.
Sorry for reopening again, but at least on the mac, if the window is not wide enough and the toolbar moves to its own row below the view tabs, it is now impossible to see if a toggle is selected ( e.g. the "Link with editor and selection" and "Compare mode" buttons in the "Git Staging View" )
New Gerrit change created: https://git.eclipse.org/r/140009
(In reply to Eclipse Genie from comment #37) > New Gerrit change created: https://git.eclipse.org/r/140009 Till this should restore the background color (this again creates an inconsistent coloring in the toolbar) but should make the selection status visible again. So it is basically a revert for the css for the toolbar composite. This fixes the reported issue on Linux, please check on Mac and let me know if you also can see the selected item again.
(In reply to Lars Vogel from comment #38) > (In reply to Eclipse Genie from comment #37) > > New Gerrit change created: https://git.eclipse.org/r/140009 > > Till this should restore the background color (this again creates an > inconsistent coloring in the toolbar) but should make the selection status > visible again. So it is basically a revert for the css for the toolbar > composite. > > This fixes the reported issue on Linux, please check on Mac and let me know > if you also can see the selected item again. selection status is visible on macOS again with that change.
I agree, the selection status is visible again. But I noted something (probably for another bug): I noted that the whole scheme regarding which view is selected and which tab is selected within it doesn't really make sense: The selected view's tab group or selected tab within it is darker than the other ones. This doesn't make sense. Even in the dark design, the selected entry should be a bit brighter so it appears to be in the foreground. Compare this to the macOS dark designs or the dark designs of firefox and chrome.. If that is changed, the background for the selected view's tab group would be brighter not totally dark, and the selection status visible even with inherited background...
(In reply to Till Brychcy from comment #40) > I agree, the selection status is visible again. Thanks for confirmation. > But I noted something (probably for another bug): > > I noted that the whole scheme regarding which view is selected and which tab > is selected within it doesn't really make sense: I agree. > The selected view's tab group or selected tab within it is darker than the > other ones. This doesn't make sense. Even in the dark design, the selected > entry should be a bit brighter so it appears to be in the foreground. > > Compare this to the macOS dark designs or the dark designs of firefox and > chrome.. > > If that is changed, the background for the selected view's tab group would > be brighter not totally dark, and the selection status visible even with > inherited background... I actually searching the setting for this since yesterday in the CSS :-) https://git.eclipse.org/r/#/c/140010/ is one approach to make it easier to find this setting. Once I find it (or someone else), I plan to change it, which should allow to revert https://git.eclipse.org/r/#/c/140009/ again and finally make the toolbar not ugly in the dark theme.
Gerrit change https://git.eclipse.org/r/140009 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4dbb2f04bfa06110c7a7fc76185d85b3e5ac0fb8
New Gerrit change created: https://git.eclipse.org/r/140266
Gerrit change https://git.eclipse.org/r/140266 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a6190cc7ce246382a49728964dc9ebc6c43e9a59
Gerrit change https://git.eclipse.org/r/139904 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2fc5cb27e8492e4d3b1a2a95be8e521d9706b08f
I tested the lastest I-Build and still the inconsistency is there it seems.
Nice snippet to put into e4-dark_globalstyle.css for testing. Shell, Composite, ScrolledComposite, ExpandableComposite, Canvas, TabFolder, CLabel, Label, CoolBar, Sash, Group, RefactoringLocationControl, ChangeParametersControl, Link, FilteredTree, ProxyEntriesComposite, NonProxyHostsComposite, DelayedFilterCheckboxTree, Splitter, ScrolledPageContent, ViewForm, LaunchConfigurationFilteredTree, ContainerSelectionGroup, BrowseCatalogItem, EncodingSettings, ProgressMonitorPart, DocCommentOwnerComposite, NewServerComposite, NewManualServerComposite, ServerTypeComposite, FigureCanvas, DependenciesComposite, ListEditorComposite, WrappedPageBook, CompareStructureViewerSwitchingPane, CompareContentViewerSwitchingPane, QualifiedNameComponent, RefactoringStatusViewer, MessageLine, Button /* SWT-BUG: checkbox inner label font color is not accessible */, Composite > *, Group > StyledText { background-color:red; color:#eeeeee; } /* ############################## Toolbar ############################## */ /* Toolbar should inherit the colors of its container to avoid drawing artifacts*/ ToolBar > Composite, ToolBar > Composite > *, ToolBar { background-color:blue; }
I think I have a couple CSS changes that will address this.
(In reply to Mike Marchand from comment #48) > I think I have a couple CSS changes that will address this. Cool
New Gerrit change created: https://git.eclipse.org/r/162665
With the way things are currently, there are a couple states that are incorrect. When the toolbar is on the second line: -When first switching to a tab, the toolbar is the wrong color -Selecting off the tab changes the color to another wrong color -Selecting the view again will result in a correct color for the toolbar on the second row. -Top row toolbars always look good. All these scenarios have been tested in my patch, now the top row and second row toolbars always look correct.
Gerrit change https://git.eclipse.org/r/162665 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c4c19d93cd2a9d6ad2899c1d8cc6766fbaada5a8
Awesome Mike. Thanks!
New Gerrit change created: https://git.eclipse.org/r/162682
Gerrit change https://git.eclipse.org/r/162682 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=883a58ebd1dc71f94196c6432c91fd4ad787328e
Created attachment 283036 [details] Dark toolbar color inconsistency I have found one last issue with the dark theme toolbar (excluding the remaining Linux issue). Reproducing this is a matter of losing focus on the view with the toolbar on the second row. I investigated and determined that the color is being inherited from the .MPart. Changing the .MPart CSS to match the color used on the second row fixes the problem. Gerrit incoming.
Reopening
New Gerrit change created: https://git.eclipse.org/r/163688
I can confirm it fixed the background color issue as shown in Bug 563575.
Sorry, it doesn't fix (In reply to Amit Mendapara from comment #59) > I can confirm it fixed the background color issue as shown in Bug 563575. Sorry, it doesn't fix the background Bug 563575. I tested with uncleaned sources (with my changes).
Created attachment 283047 [details] Toolbar issue in search view screencast
Created attachment 283048 [details] Screencast with fix in the search view
Gerrit change https://git.eclipse.org/r/163688 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cf5426ca70339dc68ebcec48f07c8ddccae0fd9e
Thanks Mike. Found one more (existing) issue in this area and opened Bug 563667 for handling it. Thanks again for working on this.
