Community
Participate
Working Groups
I suggest to replace the Minimize, Maximize and View Menu custom drawings with png icons. This should also help with the work of supporting high resolution displays, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=382972#c51
Png icons for Minimize, Maximize and View Menu are available in eclipse.platform.ui\bundles\org.eclipse.ui\icons\full\dlcl16 Could someone suggest a pattern to find custom drawings ?
(In reply to Patrik Suzzi from comment #1) > Png icons for Minimize, Maximize and View Menu are available in > eclipse.platform.ui\bundles\org.eclipse.ui\icons\full\dlcl16 > > Could someone suggest a pattern to find custom drawings ? I have found some custom drawing for part buttons in org.eclipse.platform.swt, CTabFolderRenderer class, drawMinimize, drawMaximize, drawChevron (I think this is the view menu).
What is meant with "custom drawings"?
(In reply to Matthias Becker from comment #3) > What is meant with "custom drawings"? Custom drawings are images drawn directly using the graphics object. i.e. http://www.vogella.com/tutorials/SWTCustomWidget/article.html
(In reply to Matthias Becker from comment #3) > What is meant with "custom drawings"? The view menu is created in StackRenderer#getViewMenuImage. @Matthias, could you create a svg and png version of the view menu and replace the custom drawing in getViewMenuImage with the new png file?
*** Bug 430166 has been marked as a duplicate of this bug. ***
See Bug 495033 for minimize and maximize icons in CTabFolderRenderer in SWT.
What is the difference of this bug and bug 495033?
(In reply to Matthias Becker from comment #8) > What is the difference of this bug and bug 495033? Different repos. StackRenderer is part of Platform UI and CTabFolder is part of SWT. I prefer to have different bugs if work spreads over repos.
If you replace those drawings with images. How can one change the color of those icons? Do you expose a css-property?
I can think of two options: 1. We put images with a transparent BG, that look good for common Themes. 2. We expose a new CSS-property for a customizable image.
(In reply to Thomas Schindl from comment #10) > If you replace those drawings with images. How can one change the color of > those icons? Do you expose a css-property? Our default CSS engine currently does not allow to (In reply to Patrik Suzzi from comment #11) > I can think of two options: > 1. We put images with a transparent BG, that look good for common Themes. +1 > 2. We expose a new CSS-property for a customizable image. Replacing png icons via CSS is a big development item. IIRC Brian wrote a few years ago an alternative CSS engine.
> Replacing png icons via CSS is a big development item. IIRC Brian wrote a > few years ago an alternative CSS engine. But maybe this is not such a bad idea. Sometimes it is really hard to design an icon that looks good on light as well as on dark background. Such icons could be replaced when switching the theme. Just my 2 cents.
(In reply to Matthias Becker from comment #13) > Such icons could be replaced when switching the theme. Completely agree, but that is a difference issue than the one in this bug. Can you check for existing bugs or open a new one and link it here?
Mass move to M4.
[...] > > 2. We expose a new CSS-property for a customizable image. > > Replacing png icons via CSS is a big development item. IIRC Brian wrote a > few years ago an alternative CSS engine. Not sure why that should be hard all i ask for is to have ViewMenuClass { public void setImageUrl() { ... } } and then in css i do .view-class { image-url: url(path/to/my/image); } I don't think we need a new CSS-Engine to make that work, right?
Mass move. Please move to a concrete milestone if you plan to work on this item.
Created attachment 273318 [details] Screenshot of icon on Windows 10 Btw, the existing icon is not centered. Not sure if that is intentionally but I find it super annoying. As you see in the screenshot there is more empty space to the left compare to the right.
New Gerrit change created: https://git.eclipse.org/r/120279
New Gerrit change created: https://git.eclipse.org/r/120329
Created attachment 273339 [details] old (top) and new png version (bottom) in comparison This shows how the view menu now looks like. Old (directly drawn on gc) on top and new (high res png rendered out of svg) on the bottom. You also see that I have centered the triangle.
(In reply to Matthias Becker from comment #21) > Created attachment 273339 [details] > old (top) and new png version (bottom) in comparison > > This shows how the view menu now looks like. > Old (directly drawn on gc) on top and new (high res png rendered out of svg) > on the bottom. > You also see that I have centered the triangle. I see one issue with this approach. In https://git.eclipse.org/r/#/c/120279/4/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java you see that the stroke and fill color is system dependent. You also see this in the screenshots - on Windows 10 the lines are grey and on macOS they are black. We cannot do this with a PNG. The centering should also be feasible in the old version. Couldn't we accomplish high resolution drawing on the GC so that this also is crisp?
Yes you need a twice as big image, so in theory if you multiply everything with the DPIUtil-value you should get a crisp image on HiDPI ;-)
(In reply to Matthias Becker from comment #22) > you see that the stroke and fill color is system dependent. You also see > this in the screenshots - on Windows 10 the lines are grey and on macOS they > are black. We cannot do this with a PNG. The centering should also be > feasible in the old version. I can test the new image on Windows and Linux. All other images are also not system dependent, so if the new image look good on all platforms we should be good. Using png file will also make it simpler to have a good experience on dark and the light theme.
(In reply to Thomas Schindl from comment #23) > Yes you need a twice as big image, so in theory if you multiply everything > with the DPIUtil-value you should get a crisp image on HiDPI ;-) How do you detect when to do this multiplication?
there's an internal swt-class named DPIUtil but i would go with icons as lars said the they all map together
Created attachment 273344 [details] with fill and with transparency in light and dark theme I just played around with the stroke and fill colors. I have the feeling that the grey stroke is too light (contrast with background is bad in both themes). I also think that the transparent fill is not a good idea. What do you think?
(In reply to Matthias Becker from comment #27) > Created attachment 273344 [details] > with fill and with transparency in light and dark theme > > I just played around with the stroke and fill colors. > I have the feeling that the grey stroke is too light (contrast with > background is bad in both themes). I also think that the transparent fill is > not a good idea. > > What do you think? It looks bad. First, the min/max icons are too "strong" and the view menu uses different colors. So, please do what this bug is about: replace the custom drawing with icons and not invent new icons ;-). That would be a different bug/topic.
(In reply to Dani Megert from comment #28) > First, the min/max icons are too "strong" and the view menu uses different > colors. Yes. It is not my intension to keep it like that. I just wanted to show the difference on one icon. >So, please do what this bug is about: replace the custom drawing > with icons and not invent new icons ;-). That would be a different bug/topic. The only reason for playing around with the colors is that on windows the lines seem to be gray and on mac they are black (see Lars' screenshot). So they will change anyway.
(In reply to Matthias Becker from comment #29) > Yes. It is not my intension to keep it like that. I just wanted to show the > difference on one icon. The other icons are drawn in CTabFolderRenderer which is SWT.
(In reply to Dani Megert from comment #28) > First, the min/max icons are too "strong" AFAICS these are the existing custom drawn icons. Bug 495033 is for their replacement. I agree that the existing icons are too "strong". @Matthias, I might be that the MinMaxAddon draws them, I need to check but I think a little while I found it their. Lets look at there placement together with this one.
(In reply to Lars Vogel from comment #31) > (In reply to Dani Megert from comment #28) > > First, the min/max icons are too "strong" > > AFAICS these are the existing custom drawn icons. Bug 495033 is for their > replacement. I agree that the existing icons are too "strong". @Matthias, I > might be that the MinMaxAddon draws them, I need to check but I think a > little while I found it their. Lets look at there placement together with > this one. Note that the view menu icon looks blurry (just an additional comment).
(In reply to Lars Vogel from comment #31) > (In reply to Dani Megert from comment #28) > > First, the min/max icons are too "strong" > > AFAICS these are the existing custom drawn icons. Bug 495033 is for their > replacement. I just uploaded SVGs and PNGs for these icons to Gerrit in Bug 495033. So do we continue with black lines and white fill?
Created attachment 273346 [details] Old (top) and New (bottom) on low-res monitor (In reply to Dani Megert from comment #32) > Note that the view menu icon looks blurry (just an additional comment). The new PNG version of it? I don't see this here on my Retina Display. And I also don't see that on my external low-res monitor (see Attachment)
(In reply to Matthias Becker from comment #34) > Created attachment 273346 [details] > Old (top) and New (bottom) on low-res monitor > > (In reply to Dani Megert from comment #32) > > Note that the view menu icon looks blurry (just an additional comment). > > The new PNG version of it? I don't see this here on my Retina Display. And I > also don't see that on my external low-res monitor (see Attachment) My comment is based on the screenshot.
I think the new icon does not look good on the dark theme. AFAICS the old one had some light borders https://ibb.co/kWkAZn Did you try with these borders? Also I think some transparency similar to the new + and - buttons would help the icon in the dark theme. I really like that it is now centered. :-)
Created attachment 273416 [details] Now with white border (In reply to Lars Vogel from comment #36) > I think the new icon does not look good on the dark theme. AFAICS the old > one had some light borders https://ibb.co/kWkAZn Did you try with these > borders? Also I think some transparency similar to the new + and - buttons > would help the icon in the dark theme. > > I really like that it is now centered. :-) Try again with the new patchset.
(In reply to Matthias Becker from comment #37) > Created attachment 273416 [details] > Now with white border > > (In reply to Lars Vogel from comment #36) > > I think the new icon does not look good on the dark theme. AFAICS the old > > one had some light borders https://ibb.co/kWkAZn Did you try with these > > borders? Also I think some transparency similar to the new + and - buttons > > would help the icon in the dark theme. > > > > I really like that it is now centered. :-) > > Try again with the new patchset. Please read comment 28 again. The three icons must use the same color/style. On Windows 7 with light theme it is darker than min/max. Let me know if you need a screenshot.
(In reply to Dani Megert from comment #38) > Please read comment 28 again. The three icons must use the same color/style. > On Windows 7 with light theme it is darker than min/max. Yeah. If we agree that the new view menu icon is ok I can also replace the other once. > Let me know if you need a screenshot. Yeah.
(In reply to Matthias Becker from comment #39) > (In reply to Dani Megert from comment #38) > > Please read comment 28 again. The three icons must use the same color/style. > > On Windows 7 with light theme it is darker than min/max. > Yeah. If we agree that the new view menu icon is ok I can also replace the > other once. No, I can't agree to a single icon change. Again, this bug is about replacing the custom draw with an icon that looks exactly the same. Which is currently not the case. If the goal is to change all three icons then the summary needs to be changed and the change needs to contain all three icons, so that one can decide whether it looks good. > > Let me know if you need a screenshot. > Yeah. Coming...
Created attachment 273429 [details] Screenshot of change 120279/6 on Windows 7
(In reply to Dani Megert from comment #40) > No, I can't agree to a single icon change. Again, this bug is about > replacing the custom draw with an icon that looks exactly the same. Which is > currently not the case. This is not possible. As the custom drawing uses different colors on different OSes. So it will change on some OSes. We can decide on which OSes this happens. We already talked about that topic.
(In reply to Matthias Becker from comment #42) > (In reply to Dani Megert from comment #40) > > No, I can't agree to a single icon change. Again, this bug is about > > replacing the custom draw with an icon that looks exactly the same. Which is > > currently not the case. > > This is not possible. As the custom drawing uses different colors on > different OSes. > So it will change on some OSes. We can decide on which OSes this happens. > We already talked about that topic. So, maybe go with comment 22 is the best solution.
(In reply to Dani Megert from comment #43) > So, maybe go with comment 22 is the best solution. I think it is better to use one consistent color for all OS. This is also the case for all other icons. Alternative we can have a simple OS based switch which selects the "correct" images but IMHO this is overkill a specific icon.
(In reply to Lars Vogel from comment #44) > (In reply to Dani Megert from comment #43) > > So, maybe go with comment 22 is the best solution. > > I think it is better to use one consistent color for all OS. This is also > the case for all other icons. Alternative we can have a simple OS based > switch which selects the "correct" images but IMHO this is overkill a > specific icon. I'm now looking at the Linux and Windows icons and under Linux the view icon looks ugly to me, as it is using too strong colors. The Windows version looks way better, I suggest to use this one.
Matthias, can you update the patch so that we use the color of Windows? This would make the view drop-down icon nicer on Mac and Linux and would keep the nice Window one.
(In reply to Lars Vogel from comment #46) > Matthias, can you update the patch so that we use the color of Windows? This > would make the view drop-down icon nicer on Mac and Linux and would keep the > nice Window one. I can do. But what is the RGB value of SWT.COLOR_WIDGET_DARK_SHADOW on windows?
(In reply to Matthias Becker from comment #47) > (In reply to Lars Vogel from comment #46) > > Matthias, can you update the patch so that we use the color of Windows? This > > would make the view drop-down icon nicer on Mac and Linux and would keep the > > nice Window one. > > I can do. But what is the RGB value of SWT.COLOR_WIDGET_DARK_SHADOW on > windows? Nikita, could you tell us the color code?
(In reply to Lars Vogel from comment #48) > (In reply to Matthias Becker from comment #47) > > (In reply to Lars Vogel from comment #46) > > I can do. But what is the RGB value of SWT.COLOR_WIDGET_DARK_SHADOW on > > windows? > > Nikita, could you tell us the color code? It's (105,105,105) or #696969 on Win7 and Win10. SWT ControlExample has Colors tab with a list of system colors and their values.
I updated my gerrit to the images repo with the new color. The gerrit for the platform.ui repo also was updated. I also created SVGs and PNGs for the view-stack's min / max / restore icons. For this I crated also a gerrit for the images repo. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=495033 for that.
Lets move this to early 4.9
New Gerrit change created: https://git.eclipse.org/r/127928
(In reply to Eclipse Genie from comment #52) > New Gerrit change created: https://git.eclipse.org/r/127928 This implements a completely other approach. Instead of replacing the custom drawn view icon with an PNG I made the custom drawing dpi-aware. This as the advantage, that the OS-dependenct colors used for the stroke can stay as it is. Furthermore I "moved" the triangle into the middle of the 16x16 icon (the old one was miss-aligned to the right).
Created attachment 275505 [details] Screenshot showing old and new view menu
Comment on attachment 275505 [details] Screenshot showing old and new view menu the blue line in the screenshot are there to visualize the changed alignment.
(In reply to Matthias Becker from comment #55) > Comment on attachment 275505 [details] > Screenshot showing old and new view menu > > the blue line in the screenshot are there to visualize the changed alignment. Which one is the new one? The upper one looks blurred?And why look the arrows differently?
(In reply to Dani Megert from comment #56) > (In reply to Matthias Becker from comment #55) > > Comment on attachment 275505 [details] > > Screenshot showing old and new view menu > > > > the blue line in the screenshot are there to visualize the changed alignment. > > Which one is the new one? The upper one looks blurred?And why look the > arrows differently? the upper one is old, the lower one is new. What difference do you mean besides the blurriness?
(In reply to Matthias Becker from comment #57) > the upper one is old, the lower one is new. What difference do you mean > besides the blurriness? The arrow icons look different.
(In reply to Dani Megert from comment #58) > (In reply to Matthias Becker from comment #57) > > the upper one is old, the lower one is new. What difference do you mean > > besides the blurriness? > > The arrow icons look different. different == better? ;-)
(In reply to Matthias Becker from comment #59) > (In reply to Dani Megert from comment #58) > > (In reply to Matthias Becker from comment #57) > > > the upper one is old, the lower one is new. What difference do you mean > > > besides the blurriness? > > > > The arrow icons look different. > > different == better? ;-) No, it just has nothing to do here.
(In reply to Dani Megert from comment #58) > (In reply to Matthias Becker from comment #57) > > the upper one is old, the lower one is new. What difference do you mean > > besides the blurriness? > > The arrow icons look different. You mean the "link with editor icon"? I did not change them with my change. The before screenshot was made with an older release of eclipse. I will attach a new before/after comparison.
Created attachment 275513 [details] old (upper) and new (lower)
can someone pls. test on linux and windows? Can we get that in RC1?
(In reply to Matthias Becker from comment #63) > can someone pls. test on linux and windows? I can't see much difference on Windows, but I don't have an HDPI monitor. > Can we get that in RC1? It's a bit too late to change such a prominent icon. I suggest to do it early 4.10.
New Gerrit change created: https://git.eclipse.org/r/140410
I just uploaded a version where the view dropdown icon is now drawn as a PNG in grey on all platforms (macOS did use black before). Now the color is (105,105,105) as it was used on windows. I also adapted the custom drawn min max icons to use the same color. As these icons only use horizontal and vertical lines they don't get pixelated when scaled up. So I think we can keep this custom drawing here. I will upload how this now looks on macOS in light and dark and on high-res and normal-res screens. What do you think?
Created attachment 278224 [details] grey icons in light theme high res display
Created attachment 278225 [details] grey icons in dark theme high res display
Created attachment 278226 [details] grey icons in light theme normal res display
Created attachment 278227 [details] grey icons in dark theme normal res display
Looks beautiful to me. Thanks, Matthias. Once we have Gerrits for Min/Max we can release this one, if it also looks great on Linux. I test this later today.
(In reply to Lars Vogel from comment #71) > Looks beautiful to me. I don't like the grey in the dark theme. There the icons are hard to see. To fix this I think the grey must be lighter to be better readable on dark background. >Thanks, Matthias. Once we have Gerrits for Min/Max we > can release this one, if it also looks great on Linux. I test this later > today. We already have. See: https://git.eclipse.org/r/#/c/140410/
Eric, please test this one with the various themes you have. I have big concerns about hardcoding colors.
(In reply to Alexander Kurtakov from comment #73) > Eric, please test this one with the various themes you have. I have big > concerns about hardcoding colors. FYI all other icons use fixed colors
(In reply to Alexander Kurtakov from comment #73) > Eric, please test this one with the various themes you have. I have big > concerns about hardcoding colors. pls. see my comments in gerrit
Created attachment 278239 [details] Screenshot - old dark view menu under Ubuntu
Created attachment 278240 [details] Screenshot - new dark view menu under Ubuntu
With the change the view menu looks really good in the dark theme under Ubuntu and more or less the same in the light theme.
Created attachment 278258 [details] Windows 7 Light On Windows 7 with (default) light theme it does not look good. It is too bright and can give the impression that it is disabled. Also, the border should be a bit sharper. I think it's pretty close but needs some final tweaking.
Created attachment 278259 [details] Windows 7 Dark On Windows 7 with Dark theme it looks a bit blurry if you compare it to the Min/Max icons.
(In reply to Dani Megert from comment #80) > Created attachment 278259 [details] > Windows 7 Dark > > On Windows 7 with Dark theme it looks a bit blurry if you compare it to the > Min/Max icons. This is due to the fact that the min max only have horizontal and vertical lines but the view drop down has diagonal lines. We won't get that better. Pls. compare with the current state. The view drop down should no should look better then it was before.
(In reply to Matthias Becker from comment #81) > The view drop down should no should look better then it was before. I presume you mean "should look better".
Created attachment 278260 [details] Windows 7 Dark - old vs. new It's a mixed feeling when I compare old (above) vs. new (below). For me the old one looks sharper, which I prefer, but the new one appears a bit bigger, which looks better to me.
Gerrit change https://git.eclipse.org/r/140410 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a5d8b38bcb1b0702f9e164aacfd92f5edc1df87b
New Gerrit change created: https://git.eclipse.org/r/140601
Gerrit change https://git.eclipse.org/r/140601 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9304fe94fda6a01723eca1806e3ff9b70dc5e406
New Gerrit change created: https://git.eclipse.org/r/140607
(In reply to Eclipse Genie from comment #87) > New Gerrit change created: https://git.eclipse.org/r/140607 @Everbody: Can you pls. test this change together with https://git.eclipse.org/r/#/c/120279/ again. I now use the original colors as it was on windows (105,105,105)
Created attachment 278291 [details] Light theme with Windows colors under Ubuntu
Created attachment 278292 [details] Dark theme with Windows colors under Ubuntu
(In reply to Matthias Becker from comment #88) > (In reply to Eclipse Genie from comment #87) > > New Gerrit change created: https://git.eclipse.org/r/140607 > > @Everbody: Can you pls. test this change together with > https://git.eclipse.org/r/#/c/120279/ again. I now use the original colors > as it was on windows (105,105,105) Looks fine to me under Ubuntu, see attached screenshots.
(In reply to Matthias Becker from comment #88) > (In reply to Eclipse Genie from comment #87) > > New Gerrit change created: https://git.eclipse.org/r/140607 > > @Everbody: Can you pls. test this change together with > https://git.eclipse.org/r/#/c/120279/ again. I now use the original colors > as it was on windows (105,105,105) I will test it on Monday.
Created attachment 278356 [details] Windows 7 Light On Windows 7 Top is current, bottom is new version. On Windows 7 with (default) light theme it does not look good. Now it is exactly the opposite as in comment 79: Min/Max are now too bright. The new icon plus the current version of Min/Max would probably hit it. Why did you change Min/Max?
Created attachment 278357 [details] Windows 7 Dark Top is current, bottom is new version. The new image is now better/sharper compared to comment 80. However, I see the same issue as in the light theme: Min/Max are now too bright. The new icon plus the current version of Min/Max would probably hit it.
(In reply to Dani Megert from comment #93) > Min/Max are now too bright. The new > icon plus the current version of Min/Max would probably hit it. Why did you > change Min/Max? Sorry for the confusion. I uploaded a new patchset to https://git.eclipse.org/r/#/c/140607/ that changes the color of min max to the view drop down icon. Can you please test again?
(In reply to Matthias Becker from comment #95) > (In reply to Dani Megert from comment #93) > > Min/Max are now too bright. The new > > icon plus the current version of Min/Max would probably hit it. Why did you > > change Min/Max? > > Sorry for the confusion. I uploaded a new patchset to > https://git.eclipse.org/r/#/c/140607/ that changes the color of min max to > the view drop down icon. > > Can you please test again? +1 for Windows 7 (Light and Dark theme).
Gerrit change https://git.eclipse.org/r/120279 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=18665e4da8e946d2f790ff270e3e49ff69f182b4
Gerrit change https://git.eclipse.org/r/140607 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=334542aecfe5ad8883b94a07a4a93b1a4e50d383
Gerrit change https://git.eclipse.org/r/120329 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=3eb802ed247f71096a1ec4142dd7324ef45ac02f
Thanks Matthias!
(In reply to Dani Megert from comment #100) > Thanks Matthias! Awesome, Matthias. Finally the view menu does not look ugly in the dark theme. Thanks. You may want to add a N&N entry...
(In reply to Lars Vogel from comment #101) > You may want to add a N&N entry... I don't think this is necessary as everyone should notice immediately ;-).
(In reply to Dani Megert from comment #102) > (In reply to Lars Vogel from comment #101) > > You may want to add a N&N entry... > I don't think this is necessary as everyone should notice immediately ;-). Maybe some people which evaluated the dark theme earlier and decided it was too ugly might give it another try with such an N&N entry. But I have no strong feelings here, so whatever Matthias thinks is fine for me.
New Gerrit change created: https://git.eclipse.org/r/141061
Gerrit change https://git.eclipse.org/r/141061 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=dfd7348605ce973a7589d64c4d972149eb999f02
