Community
Participate
Working Groups
Created attachment 283012 [details] navigator-toolbar.png The navigator toolbars have few minor layout issues. Please see the attached screenshot. The toolbar is overlapping the tab and there is a background color issue because of unnecessary spacing between toolbar items.
Thanks, Gerrits are welcome.
(In reply to Lars Vogel from comment #1) > Thanks, Gerrits are welcome. Thanks Lars :) The overlapping issue is not there in 4.15 so it may be because of some 4.16 changes. I can check if you point me to the correct source and components.
I just checked further and found that it's "CTabRendering" where I should check and it is #538740 related changes that caused this issue.
Mike, can you check?
@Amit, there's now a preference to switch between using Square/Round tabs in the appearance options. It might be worth investigating if this issue occurs only with square or round tabs, as that'd help Mike (or someone else) find the source of the bug.
(In reply to Andrew Obuchowicz from comment #5) > @Amit, there's now a preference to switch between using Square/Round tabs in > the appearance options. It might be worth investigating if this issue occurs > only with square or round tabs, as that'd help Mike (or someone else) find > the source of the bug. Yes I checked, same issue is the with rounded tab. I tried by reverting "CTabRendering" to commit 40500009cce062f9a81533e94f1e310fdc9f76de and the issue was not there. After that I reverted the "CTabRendering" to the commit 9c74e2cf1d925d37fb7f8a4c1bd387e27cab4448 (the one that implemented square tabs) and I can see the issue.
I'm going to take a look at this today.
This issue also reproduces on Windows.
I have a fix for this issue. This regression was caused by the change to computeTrim so that the corner radius doesn't affect the trim. In the PART_BORDER case, we no longer have enough padding without the corner radius' contribution. By considering ITEM_LEFT_MARGIN and ITEM_RIGHT_MARGIN, we get better results, with no overlap of buttons and tabs. Gerrit incoming.
New Gerrit change created: https://git.eclipse.org/r/163687
(In reply to Mike Marchand from comment #8) > This issue also reproduces on Windows. How can I reproduce this on Windows?
(In reply to Lars Vogel from comment #11) > How can I reproduce this on Windows? To reproduce: close all views after it and move it over the corner.
Ah, reproducing for me is as simple as resizing the view, so that the toolbar approaches the tabs, at a certain point the toolbar should move to the second row but it happens a couple pixels too late, causing some overlap of the toolbar and the tab.
Gerrit change https://git.eclipse.org/r/163687 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c8eb29bee01194e467f4a2b71e134687d3ac59fc
Thanks Mike for the fix and Andrew for testing and review. Thanks Amit for reporting.
(In reply to Lars Vogel from comment #15) > Thanks Mike for the fix and Andrew for testing and review. > > Thanks Amit for reporting. I couldn't check it yesterday. Does the I-Build(In reply to Lars Vogel from comment #15) > Thanks Mike for the fix and Andrew for testing and review. > > Thanks Amit for reporting. I couldn't test the patch yesterday but just checked the latest I-Build and issue is fixed now.
Thanks Amit for checking. Your other issues is handled by Bug 539661. Please test, if you have time.
(In reply to Lars Vogel from comment #17) > Thanks Amit for checking. Your other issues is handled by Bug 539661. Please > test, if you have time. I doubt. The Bug 539661 is about dark theme while I can see the issue with light theme. I found that setting RawLayout spacing to 0 (zero) in StackRenderer.java before line 711 fixes the issue.
(In reply to Amit Mendapara from comment #18) > I doubt. The Bug 539661 is about dark theme while I can see the issue with > light theme. For light theme, please comment on Bug 483493.
(In reply to Lars Vogel from comment #19) > (In reply to Amit Mendapara from comment #18) > > > I doubt. The Bug 539661 is about dark theme while I can see the issue with > > light theme. > > For light theme, please comment on Bug 483493. It's Bug 539661. I just tested those last gerrit changes and it fixed the issue. I will comment on both those tickets.
(In reply to Amit Mendapara from comment #20) > (In reply to Lars Vogel from comment #19) > > (In reply to Amit Mendapara from comment #18) > > > > > I doubt. The Bug 539661 is about dark theme while I can see the issue with > > > light theme. > > > > For light theme, please comment on Bug 483493. > > It's Bug 539661. I just tested those last gerrit changes and it fixed the > issue. I will comment on both those tickets. Sorry, it's not. The issue is still there.
