Community
Participate
Working Groups
Created attachment 258421 [details] White tab separator sized area/sliver In tab areas (like the one near Package Explorer, Outline, etc.), there is an area the size of a separator which is white/has a white background. This stands out since the background is light gray. You can see it both when the tab is focused and not. I can confirm that it's a Platform UI issue since running a child Eclipse with only the latest SWT (and not the latest Platform UI) doesn't reproduce the issue. As soon as I run a child Eclipse with the latest Platform UI from master, the issue appears. It's possible it's related to this commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=88c5aba15dc5a16b66b331b2d072499da9065d37 I've attached a screenshot showing the issue.
*** Bug 497829 has been marked as a duplicate of this bug. ***
Eric, is it possible that setBackground is not working for ToolItem(style=SWT.SEPARATOR) as it uses different css node separator?
(In reply to Alexander Kurtakov from comment #2) > Eric, is it possible that setBackground is not working for > ToolItem(style=SWT.SEPARATOR) as it uses different css node separator? Will investigate.
*** Bug 520099 has been marked as a duplicate of this bug. ***
(In reply to Eric Williams from comment #3) > (In reply to Alexander Kurtakov from comment #2) > > Eric, is it possible that setBackground is not working for > > ToolItem(style=SWT.SEPARATOR) as it uses different css node separator? > > Will investigate. Follow up: it's not related AFAICT.
Created attachment 280362 [details] Screenshot 4 years later, and we still have a while strip. See screenshot.
(In reply to Lars Vogel from comment #6) > Created attachment 280362 [details] > Screenshot > > 4 years later, and we still have a while strip. See screenshot. seems to be a Linux issue. On macOS I don't see this.
Looks like we seen the underlying Composite. For testing, add the following to e4-dark_globalstyle.css in org.eclipse.ui.themes CTabFolder > Composite { background-color:red; }
Created attachment 280523 [details] Screenshot Eric, looks to me that we have a additional Composite in the view toolbar (the red bar). Is this necessary or could this be removed on the SWT side?
(In reply to Lars Vogel from comment #9) > Created attachment 280523 [details] > Screenshot > > Eric, looks to me that we have a additional Composite in the view toolbar > (the red bar). Is this necessary or could this be removed on the SWT side? It is necessary on GTK, all Composite widgets have this. However this doesn't mean we need to live with the ugliness. :) I am thinking of a few solutions: 1) I can try setting the background color of it in SWT to match the ToolBar's background color. 2) Can we theme it in Platform UI to make it transparent, so it inherits the parent's background color? What do you think?
(In reply to Eric Williams from comment #10) > (In reply to Lars Vogel from comment #9) > > Created attachment 280523 [details] > > Screenshot > > > > Eric, looks to me that we have a additional Composite in the view toolbar > > (the red bar). Is this necessary or could this be removed on the SWT side? > > It is necessary on GTK, all Composite widgets have this. However this > doesn't mean we need to live with the ugliness. :) > > I am thinking of a few solutions: > > 1) I can try setting the background color of it in SWT to match the > ToolBar's background color. > > 2) Can we theme it in Platform UI to make it transparent, so it inherits the > parent's background color? > > > What do you think? I looked into the IDE a bit closer using GtkInspector and the Composite you are interested in is not related to the ToolBar, it's the parent for all the ToolBars in that area. My thought is that this Composite is missing some styling in the theme engine. It's possible other platforms don't need it to be themed because the Composite has the right background color implicitly, but it seems on GTK the background color is coming from somewhere else, or isn't being set at all. Alternatively there could be a bug in SWT Composite's color inheritance (like bug 519416) but I don't know enough about how the parent Composite is constructed. Lars, could you point me to the class in Platform UI that constructs this Composite?
(In reply to Eric Williams from comment #11) > Lars, could you point me to the class in Platform UI that constructs this > Composite? I think this is CTabFolder. See screenshot from the Layout Spy (Ctrl+Shift+Alt+F9).
Created attachment 280528 [details] Layout spy
(In reply to Lars Vogel from comment #12) > (In reply to Eric Williams from comment #11) > > > Lars, could you point me to the class in Platform UI that constructs this > > Composite? > > I think this is CTabFolder. See screenshot from the Layout Spy > (Ctrl+Shift+Alt+F9). Ah, looks like this is handled / caused by org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering.
Perfect, thanks for the info. I'll take a look next week.
Please retarget if you still plan to fix this for 4.14.
(In reply to Eric Williams from comment #15) > Perfect, thanks for the info. I'll take a look next week. Eric. Do you have plans to continue work on this?
(In reply to Matthias Becker from comment #17) > (In reply to Eric Williams from comment #15) > > Perfect, thanks for the info. I'll take a look next week. > > Eric. Do you have plans to continue work on this? Eric no longer works on SWT so I doubt he has such plans.
Mike, can you have a look?
Sometime over the next couple days I can try to take a look in my Linux VM to see what I can ascertain.
So if I disable theming the issue is not visible so I'm quite sure that it comes from code in platform.ui CTabRenderer.
(In reply to Mike Marchand from comment #20) > Sometime over the next couple days I can try to take a look in my Linux VM > to see what I can ascertain. Thanks!
Some issue can be seen in the dark theme.
I spent a significant amount of time investigating this issue on my Linux VM yesterday. I can see the problem, but I wasn't able to trace the difference between the Win32 and GTK behavior. I'm going to have to revisit this some time again in the future.
(In reply to Mike Marchand from comment #24) > I spent a significant amount of time investigating this issue on my Linux VM > yesterday. I can see the problem, but I wasn't able to trace the difference > between the Win32 and GTK behavior. I'm going to have to revisit this some > time again in the future. Maybe the same issue as in Bug 539661?
(In reply to Lars Vogel from comment #25) > (In reply to Mike Marchand from comment #24) > > I spent a significant amount of time investigating this issue on my Linux VM > > yesterday. I can see the problem, but I wasn't able to trace the difference > > between the Win32 and GTK behavior. I'm going to have to revisit this some > > time again in the future. > > Maybe the same issue as in Bug 539661? Yes it's. I just tested latest gerrit patches for but 539661 and it fixed the issue.
(In reply to Amit Mendapara from comment #26) > (In reply to Lars Vogel from comment #25) > > (In reply to Mike Marchand from comment #24) > > > I spent a significant amount of time investigating this issue on my Linux VM > > > yesterday. I can see the problem, but I wasn't able to trace the difference > > > between the Win32 and GTK behavior. I'm going to have to revisit this some > > > time again in the future. > > > > Maybe the same issue as in Bug 539661? > > Yes it's. I just tested latest gerrit patches for but 539661 and it fixed > the issue. Ignore my last comment.
Right, unfortunately those two bugs are not related. This particular bug has to do with the way colors are being resolved differently when calculated by CSS vs setBackground(color) vs setBackground(null)... for some reason, on Windows and Mac, the colors are coming out correctly for the #ToolbarComposite in just about all cases but on Linux they are not.
Created attachment 283057 [details] remove-spacing.patch I have tried removing the layout spacing. But I am not sure if it can affect other components.
Amit, please provide Gerrit. You know how :-)
New Gerrit change created: https://git.eclipse.org/r/163797
Created attachment 283196 [details] Linux Dark Toolbars - 163797 I'm still seeing a problem with https://git.eclipse.org/r/163797 applied
(In reply to Mike Marchand from comment #32) > Created attachment 283196 [details] > Linux Dark Toolbars - 163797 > > I'm still seeing a problem with https://git.eclipse.org/r/163797 applied The horizontal line? I think with my other patches for bug 563684 may fix that.
Gerrit change https://git.eclipse.org/r/163797 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a987b290beb29d29220ffb1353f055a416950018
Thanks, Amit. (In reply to Amit Mendapara from comment #33) > (In reply to Mike Marchand from comment #32) > > Created attachment 283196 [details] > > Linux Dark Toolbars - 163797 > > > > I'm still seeing a problem with https://git.eclipse.org/r/163797 applied > > The horizontal line? I think with my other patches for bug 563684 may fix > that. I also think that is another bug and should be handled somewhere else.
(In reply to Lars Vogel from comment #35) > Thanks, Amit. Thanks, Lars. Feeling happy it was merged, my first contribution :)
