Bug 519416 - [GTK] Composite.setBackgroundMode() not working properly on GTK
Summary: [GTK] Composite.setBackgroundMode() not working properly on GTK
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-07-07 13:14 EDT by Eric Williams CLA
Modified: 2021-05-27 00:35 EDT (History)
0 users

See Also:


Attachments
Screenshot comparing GTK2 vs. GTK3 vs. Win32 (304.42 KB, image/png)
2017-07-07 13:14 EDT, Eric Williams CLA
no flags Details
Snippet237 as of M4 (30.33 KB, image/png)
2017-12-06 13:25 EST, Eric Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2017-07-07 13:14:00 EDT
Created attachment 269289 [details]
Screenshot comparing GTK2 vs. GTK3 vs. Win32

On GTK2 and 3, Snippet237 shows incorrect color inheritance.

At first I thought that perhaps this was caused by bug 477950 but it turns out the issue has been going on since before then.

GTK3 is more broken than GTK2, but both versions are not correct.

I'll take this one.
Comment 1 Eclipse Genie CLA 2017-07-11 11:23:23 EDT
New Gerrit change created: https://git.eclipse.org/r/101064
Comment 3 Eric Williams CLA 2017-07-11 11:32:23 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/101064 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=fdffc9db3abc61bd1d690b5d5740e718ad09e920

First fix is in, just a quick one for Group. More investigation into other issues are pending.
Comment 4 Eclipse Genie CLA 2017-07-13 08:11:05 EDT
New Gerrit change created: https://git.eclipse.org/r/101178
Comment 5 Eclipse Genie CLA 2017-07-13 08:18:49 EDT
New Gerrit change created: https://git.eclipse.org/r/101179
Comment 6 Eclipse Genie CLA 2017-07-13 08:26:09 EDT
New Gerrit change created: https://git.eclipse.org/r/101182
Comment 7 Eric Williams CLA 2017-12-06 11:36:12 EST
Some initial observations:

-The List widget in the SWT.INHERIT_FORCE frame is not cyan because the background machinery for List is a bit broken. I have an easy fix for that which I will merge after M4.

-The labels and buttons in the SWT.INHERIT_NONE frame pose a bigger a challenge. These widgets are not themed by the GTK, so they are transparent by default. This seems to have been the case for awhile (on GTK3), and I'm not sure how we're going to deal with it.

This begs the question: does the SWT API report the actual color of the widget? Or the perceived color? For example: the label in this case is transparent (according to GtkInspector, rgba(0,0,0,0)). But calling label.getBackground() yields the platform default, which is COLOR_WIDGET_BACKGROUND. To the user, the label widget is cyan.

Either way this requires further investigation, since GTK2 vs. GTK3 behaviour is clearly very different.
Comment 8 Eric Williams CLA 2017-12-06 13:25:13 EST
Created attachment 271800 [details]
Snippet237 as of M4

This is what Snippet237 looks like now: you can see the Labels and Buttons are cyan (but shouldn't be).
Comment 9 Eric Williams CLA 2019-06-06 10:23:58 EDT
Not working on this at the moment, re-assigning to the inbox.
Comment 10 Eclipse Genie CLA 2021-05-27 00:35:54 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.