Community
Participate
Working Groups
The vertical bar to the left of line numbers which is usually used to display the errors/warnings/quick fixes is not styled at all when I switch to dark theme. I'm using Fedora 26 and Photon I20170924-2000.
Created attachment 270886 [details] Screenshot of the issue
I think you are seeing the range indicator. If yes, I think this is a dup of Bug 514043. You can check with unflagging Windows-> Preferences -> General -> Editors -> Text Editors -> Show range indicator
I don't think it's the range indicator. My range in the screenshot I provided is bound only to line 107 (where my cursor is) and you can see that it's bit of blue-ish under the error marker. But the rest of the bar, including the package declaration area supposedly out of the range of where my cursor is, is still non-dark. To confirm, I also disabled the range indicator and it did not make a difference elsewhere, except on the range indicator limited to line 107.
Eric, I have a feeling this relates with the color port.
Does this bug reproduce on Oxygen?
(In reply to Eric Williams from comment #5) > Does this bug reproduce on Oxygen? No, works fine for me on Oxygen.
(In reply to Alexander Kurtakov from comment #6) > (In reply to Eric Williams from comment #5) > > Does this bug reproduce on Oxygen? > > No, works fine for me on Oxygen. Okay, will investigate.
I can confirm this is an SWT issue related to the color port.
New Gerrit change created: https://git.eclipse.org/r/106611
Gerrit change https://git.eclipse.org/r/106611 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=dbb0707aaf394479cecab65956b04e6677e546d3
This change broke Platform UI at least in the case of "no CSS" theme. The background of many dialogs is white and not gray anymore. To reproduce on Linux (GTK3.14): in a new workspace, go to Preferences General Appearance and unset "enable theming". After restart, open same dialog and see that the background is white all over the place, except some groups. I will attach the picture. Funny enough, this seem to disappear after opening/closing the preferences dialog, so there is some initialization issue.
Created attachment 271094 [details] broken dialog background
(In reply to Andrey Loskutov from comment #12) > Created attachment 271094 [details] > broken dialog background (In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/106611 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=dbb0707aaf394479cecab65956b04e6677e546d3 Reverting SWT to the previous commit 700f51a9dadbb2758a6fdb36646cac1c42f17cf9 fixes the regression for me.
(In reply to Andrey Loskutov from comment #13) > (In reply to Andrey Loskutov from comment #12) > > Created attachment 271094 [details] > > broken dialog background > > (In reply to Eclipse Genie from comment #10) > > Gerrit change https://git.eclipse.org/r/106611 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > > ?id=dbb0707aaf394479cecab65956b04e6677e546d3 > > Reverting SWT to the previous commit > 700f51a9dadbb2758a6fdb36646cac1c42f17cf9 fixes the regression for me. I can reproduce the issue you have described. Interestingly enough, it only happens with an empty workspace. Having any editor open doesn't reproduce the issue. Happens with GTK3.14 - 3.22. I'll investigate in the coming weeks.
Ping. I would appretiate if we could revert the last patch if we can't get a fix for the regression soon.
New Gerrit change created: https://git.eclipse.org/r/111310
Gerrit change https://git.eclipse.org/r/111310 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c63947ad40653d5435a577fcbd47fe1e29c447ec
(In reply to Eclipse Genie from comment #17) > Gerrit change https://git.eclipse.org/r/111310 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=c63947ad40653d5435a577fcbd47fe1e29c447ec I've reverted the fix in the meantime until I can find a proper solution.
(In reply to Eric Williams from comment #18) > > I've reverted the fix in the meantime until I can find a proper solution. Many thanks. Works fine for me now with I20171109-2000.
Gerrit change https://git.eclipse.org/r/112576 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fd4b43a9e02286be25654184359fb2a11644fe10
I'm sorry being too late, but it looks like the last patch broke the toolbars / titles in some UI's. I haven't investigated this further, but some of them have no background now (and before they had the background from parent). See next screenshot. Note: I've de-selected the theme and run Eclipse without CSS theme support to see how it looks like in a "pure" native widget mode.
Created attachment 271736 [details] Some widgets have no bakground after patch
Created attachment 271737 [details] Some widgets have no bakground after patch
Created attachment 271738 [details] Same UI before the patch
Please provide a junit test for this issue. IMHO it's smaller issue than the broken dark them ruller so it's lesser evil.
Eric, it's up to you whether you'll get a fix for the issue ASAP or you want to revert it. FWIW, JUnit tests are badly due
(In reply to Alexander Kurtakov from comment #25) > Please provide a junit test for this issue. Did you mean me or Eric? I have no time for this, sorry. > IMHO it's smaller issue than the > broken dark them ruller so it's lesser evil. There are much more users with "Light" theme as with the "Dark" one, therefore I don't think this is a good trade off to fix one bug by introducing another one which affects more people. BTW interesting effect is: in the "Light" theme the broken background seem to change to the "right" one after making the view / editor active. In the "no CSS" theme the broken background stays forever.
I would vote +1 for reverting for M4.
New Gerrit change created: https://git.eclipse.org/r/112717
(In reply to Eclipse Genie from comment #29) > New Gerrit change created: https://git.eclipse.org/r/112717 I am reverting the patch. This needs more time to be properly investigated.
Gerrit change https://git.eclipse.org/r/112717 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=382c1d03f132e44887b0dcb83fdb7f7578ef9db2
(In reply to Eclipse Genie from comment #31) > Gerrit change https://git.eclipse.org/r/112717 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=382c1d03f132e44887b0dcb83fdb7f7578ef9db2 Reverted. I think it's best to fix bug 519416 before getting involved in this one. They are likely related. Moving out of M4.
New Gerrit change created: https://git.eclipse.org/r/113100
(In reply to Eclipse Genie from comment #33) > New Gerrit change created: https://git.eclipse.org/r/113100 I've uploaded a new patch -- Andrey please review.
Gerrit change https://git.eclipse.org/r/113100 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e4ea137643762dd3e38d38276d52c49d8a5b8aec
(In reply to Eclipse Genie from comment #35) > Gerrit change https://git.eclipse.org/r/113100 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=e4ea137643762dd3e38d38276d52c49d8a5b8aec In master now. Thanks everyone for your patience and efforts in helping me fix this pernicious bug.
Verified in I20180122-2000.
*** Bug 489030 has been marked as a duplicate of this bug. ***
