Community
Participate
Working Groups
This is more of a long term project rather than a bug. Currently in SWT we have alpha values being lost for many widgets, as colors are currently stored in GdkColor objects, not GdkRGBA. There are also instances where alpha values are hard-coded to 1 and never set. This would take quite a bit of effort since many widgets are affected by this. Code duplication would also ensue because separate code paths for Gtk2 and Gtk3 would be needed. However this issue affects lots of different areas, so it would probably be worth fixing eventually, and Gtk2 will be around for the foreseeable future. This affects things like bug 441566, bug 439884, etc. -- places where a lack of transparency is particularly ugly (for example, colored text on a black background). Feel free to discuss. :)
Looking to spend some time on this in the next 6-8 months. Would be nice to have this for Oxygen.
*** Bug 271618 has been marked as a duplicate of this bug. ***
I opt for raising priority of this bug, as it has some very negative effects in 4.6.0 and 4.6.1.
(In reply to Markus Duft from comment #3) > I opt for raising priority of this bug, as it has some very negative effects > in 4.6.0 and 4.6.1. Can you attach some screenshots where we see this effect?
Created attachment 264510 [details] Screenshot As described multiple times in 439884. The javadoc colors are completely wrong. This may not sound like a big issue, but it /is/ a big one for a lot of my colleagues. Als the quick outline, quick type hierarchy etc. are affected. No matter what colors are configured by the theme, they are completely ignored. Sometimes, the /first/ javadoc tooltip shows up very shortly with the correct color, but immediately after it flickers and switches to white on black. Especially links are extremely hard to read in this color setup.
(In reply to Markus Duft from comment #5) >The javadoc colors are wrong. I don't these wrong colors are part of the alpha issue. The Javadoc colors are reworked in Bug 501742 and for the tooltips are covered by Bug 381010.
In this case comment 44 on bug 439884 is wrong, and also the depends on references this bug.
1) Priority (In reply to Markus Duft from comment #3) > I opt for raising priority of this bug, as it has some very negative effects > in 4.6.0 and 4.6.1. Hello Markus.D, Eric is currently in 4th year of his university degree and won't be back full time until ~May 2018. Unless somebody else picks up where he paused, it might take a while before progress is made on this patch. Me/Ian are currently working on Webkit/Wayland port, so we probably won't be able to work on this either. 2) Javadoc / Outline (In reply to Lars Vogel from comment #6) > (In reply to Markus Duft from comment #5) > >The javadoc colors are wrong. > > I don't these wrong colors are part of the alpha issue. The Javadoc colors > are reworked in Bug 501742 and for the tooltips are covered by Bug 381010. The outline colors are already fixed, (try recent nightly build). I'm also nearly done with the Javadoc color fix. Hopefully these two color issues should be resolved soon. Please follow Bug 501742 for updates on the matter.
(In reply to Leo Ufimtsev from comment #8) > 1) Priority > (In reply to Markus Duft from comment #3) > > I opt for raising priority of this bug, as it has some very negative effects > > in 4.6.0 and 4.6.1. > > Hello Markus.D, > > Eric is currently in 4th year of his university degree and won't be back > full time until ~May 2018. Unless somebody else picks up where he paused, it > might take a while before progress is made on this patch. Slight correction: May 2017! The color port patch is done minus the issue with the GSlice error. It's an annoying bug I hope to track down in time for the 4.7 release, time permitting.
(In reply to comment #9) > (In reply to Leo Ufimtsev from comment #8) > Slight correction: May 2017! Ah yea... :-)
Close to finishing, but not in time for 4.7. Moving to 4.8.
New Gerrit change created: https://git.eclipse.org/r/98569
Gerrit change https://git.eclipse.org/r/76631 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8f5c12dbbf0d52d77529e8b468c625831e5f4dd0
(In reply to Eclipse Genie from comment #13) > Gerrit change https://git.eclipse.org/r/76631 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=8f5c12dbbf0d52d77529e8b468c625831e5f4dd0 Patch is in master now. A big thanks to all that helped review! I will be merging JUnit tests in a bit.
New Gerrit change created: https://git.eclipse.org/r/100400
Gerrit change https://git.eclipse.org/r/98569 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4f872fd395164f725f4b93c20c939640f33f2146
(In reply to Eclipse Genie from comment #16) > Gerrit change https://git.eclipse.org/r/98569 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=4f872fd395164f725f4b93c20c939640f33f2146 Tests are merged.
Gerrit change https://git.eclipse.org/r/100400 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f3589756b1057b01e3ae719bf8ba0464d3131ea5
New Gerrit change created: https://git.eclipse.org/r/100636
Gerrit change https://git.eclipse.org/r/100636 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a11c0c7796b373c0b90c36a2f484694075cc0994
New Gerrit change created: https://git.eclipse.org/r/100659
(In reply to Eclipse Genie from comment #20) > Gerrit change https://git.eclipse.org/r/100636 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=a11c0c7796b373c0b90c36a2f484694075cc0994 This fixes the failing test cases on Win32, which has no transparent foreground color support.
New Gerrit change created: https://git.eclipse.org/r/101133
Gerrit change https://git.eclipse.org/r/101133 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=beb7ed1153ccbc46a55dc532aa013d8744ac4ee8
(In reply to Eclipse Genie from comment #24) > Gerrit change https://git.eclipse.org/r/101133 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=beb7ed1153ccbc46a55dc532aa013d8744ac4ee8 Committed a snippet for comparing system color values. Only useful on Fedora with the Adwaita theme, but very helpful when dealing with system color issues.
Could this be the cause for bug 519616?
(In reply to Dani Megert from comment #26) > Could this be the cause for bug 519616? Possible but unlikely. The gerrit tests started failing yesterday morning even though the alpha test cases and main patch have been merged for almost 2 weeks. AllNonBrowser tests pass locally for GTK2.24 all the way through 3.22.
New Gerrit change created: https://git.eclipse.org/r/101989
New Gerrit change created: https://git.eclipse.org/r/101991
New Gerrit change created: https://git.eclipse.org/r/101990
Gerrit change https://git.eclipse.org/r/101989 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3b7a03ad4819bd0b57a0b8cd57a7a8d1f7604e9a
Gerrit change https://git.eclipse.org/r/101990 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=06ebabcb138760679f584678c7485fb15f183f7f
Gerrit change https://git.eclipse.org/r/101991 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=942848839aa09ec1e546f97e0b03ea8d287c8b89
(In reply to Eclipse Genie from comment #31) > Gerrit change https://git.eclipse.org/r/101989 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=3b7a03ad4819bd0b57a0b8cd57a7a8d1f7604e9a (In reply to Eclipse Genie from comment #32) > Gerrit change https://git.eclipse.org/r/101990 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=06ebabcb138760679f584678c7485fb15f183f7f (In reply to Eclipse Genie from comment #33) > Gerrit change https://git.eclipse.org/r/101991 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=942848839aa09ec1e546f97e0b03ea8d287c8b89 All three patches are in master now. Thank you Andrey!
New Gerrit change created: https://git.eclipse.org/r/104580
Gerrit change https://git.eclipse.org/r/104580 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=510123cbd7e52b3e1787bb11d971112329a7baf2
