Bug 546063 - [Dark Theme] Add transparency to the Collapse all image
Summary: [Dark Theme] Add transparency to the Collapse all image
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.11   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 532695
Blocks:
  Show dependency tree
 
Reported: 2019-04-02 12:10 EDT by Lars Vogel CLA
Modified: 2020-06-02 12:00 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (13.81 KB, image/png)
2019-04-02 12:10 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-04-02 12:10:29 EDT 
Created attachment 278121 [details]
Screenshot

I think the Collapse button would look may better in the dark theme if we replace the hard-coded white with transparency.

I think light theme will not be affected.
Comment 1 Lars Vogel CLA 2019-04-03 04:12:34 EDT 
Matthias, can you give it a try?
Comment 2 Matthias Becker CLA 2019-04-03 04:32:46 EDT 
(In reply to Lars Vogel from comment #0)
> Created attachment 278121 [details]
> Screenshot
> 
> I think the Collapse button would look may better in the dark theme if we
> replace the hard-coded white with transparency.
> 
> I think light theme will not be affected.

do you mean that square with the "-" sign in it?
The background is not white is has a light blue gradient. If we remove that the contrast to the background will be bad.
Comment 3 Lars Vogel CLA 2020-05-18 07:56:06 EDT 
(In reply to Matthias Becker from comment #2)
> do you mean that square with the "-" sign in it?

Yes
> The background is not white is has a light blue gradient. If we remove that
> the contrast to the background will be bad.

Any other suggestions how to improve this icon? Or shall we close this bug as wontfix?
Comment 4 Matthias Becker CLA 2020-05-18 08:03:18 EDT 
(In reply to Lars Vogel from comment #3)
> Any other suggestions how to improve this icon? Or shall we close this bug
> as wontfix?
I don't have other suggenstions. Once we can exchange icons based on the theme we could provide a dark-theme specific version of the icon