Bug 546987 - [CSS] Style initially not applied when toolbar is wrapped before user selects it
Summary: [CSS] Style initially not applied when toolbar is wrapped before user selects it
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.11   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 569022 571296 (view as bug list)
Depends on:
Blocks: 577364
  Show dependency tree
 
Reported: 2019-05-05 15:02 EDT by Rolf Theunissen CLA
Modified: 2021-11-19 07:15 EST (History)
6 users (show)

See Also:

Attachments
Screenshot of the problem (14.04 KB, image/png)
2020-06-03 11:46 EDT, Rolf Theunissen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2019-05-05 15:02:20 EDT 
When the toolbar is wrapped and it is changed, the background of the toolbar has the incorrect color. It has the color of the unwrapped toolbar instead of the wrapped toolbar.

To reproduce:
1. Open the search view, do a search
2. Ensure that the toolbar is wrapped, by changing the views width
3. Change the toolbar: View menu > Show as List

The background is becomes correct when the view is resized, or when the window is (de)activated.

It can also be reproduced with the Mock Views.
Comment 1 Lars Vogel CLA 2020-05-25 11:10:13 EDT 
Search view toolbar does not wrap for me anymore. Does is still wrap for you? Not sure if that is a regression or an intended fix.
Comment 2 Lars Vogel CLA 2020-06-03 05:29:56 EDT 
Rolf, please reopen if you still see this issue.
Comment 3 Rolf Theunissen CLA 2020-06-03 11:46:33 EDT 
Created attachment 283135 [details]
Screenshot of the problem

I still see the issue in I20200602-1800
Comment 4 Rolf Theunissen CLA 2020-06-03 11:46:59 EDT 
I still see the issue in I20200602-1800
Comment 5 Lars Vogel CLA 2020-06-03 11:52:06 EDT 
Mike, please have a look
Comment 6 Mike Marchand CLA 2020-06-03 11:55:37 EDT 
Rolf, do you see the same issue in Dark theme?
Comment 7 Rolf Theunissen CLA 2020-06-03 12:04:36 EDT 
In the dark theme the issue shows not when changing the toolbar. However, it does show when resizing the search view when the toolbar is wrapped. It disappears again when the view gains or loses focus.
Comment 8 Mike Marchand CLA 2020-08-17 09:06:05 EDT 
I spent some time investigating this but so far I have come up with nothing.
Comment 9 Thomas Wolf CLA 2020-11-22 13:11:13 EST 
BTW: this is an old problem predating 2019. I first ran into this on OS X in 2016 when I gave the EGit history view a search field in the toolbar. I spent quite some time back then investigating this but had been unable to figure out what caused it.

In EGit we have some rather gruesome hacks that appear to work around this most of the time. Basically, whenever the search textbox in the toolbar becomes visible (which may cause the toolbar to be wrapped) it focuses first the view's main control and then its own widget. This appears to fix the wrong background most of the time.
Comment 10 Rolf Theunissen CLA 2021-02-23 03:19:09 EST 
*** Bug 569022 has been marked as a duplicate of this bug. ***
Comment 11 Rolf Theunissen CLA 2021-02-23 03:19:20 EST 
*** Bug 571296 has been marked as a duplicate of this bug. ***
Comment 12 Lars Vogel CLA 2021-02-23 05:22:30 EST 
Not sure if that helps but a while ago I ported the layout spy to PDE, which allows to assign random colors to UI elements to better identify them and shows additional infos on hover. To trigger: Ctrl+3 -> Layout spy -> Color controls
Comment 13 Rolf Theunissen CLA 2021-02-23 06:27:40 EST 
Seems that this is yet another scenario that is left over from Bug 539661 Comment 36 and further. Given the history of that bug, Bug 565754 could have the same root cause as this one.