Bug 507072 (LinuxIDEColorTracker) - Implement fitting Linux colors for various IDE components
Summary: Implement fitting Linux colors for various IDE components
Status: CLOSED WONTFIX
Alias: LinuxIDEColorTracker
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 516003 500196 500452 505851 507067 507073 507298 508086 508498 508776 DebugHoverBlackBg 508817 ColorInfoApi 508901 CTabFolderBlackBg refactorPopupBlackBg 515972 516364 516515 darkThemeLinkText RefactorStatusDialog fullScreenPopup 531274 531761
Blocks:
  Show dependency tree
 
Reported: 2016-11-04 13:11 EDT by Leo Ufimtsev CLA
Modified: 2020-07-06 05:26 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2016-11-04 13:11:01 EDT
This is an umbrella bug for tracking related bugs.

We have a number of inverted black/white issues, which can now be fixed by using the HOVER_ preference:
Bug 505738 – Define a information hover color which JDT, CDT or others can use 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=505738

Fix can be implemented like in this commit:
https://git.eclipse.org/r/#/c/84373/
(See JavaDocView code that acquires color from preference).
Using HOVER_ is encouraged because it's properly styled in Dark-theme:
https://git.eclipse.org/r/#/c/84374/


I'll add sub-bugs shortly.
Note, sub-bugs are not all in Platform.UI. Some are scattered in JDT, CDT, etc..
Comment 1 Leo Ufimtsev CLA 2016-11-24 10:02:33 EST
At the moment I'm working on Webkit2 port. After which I intend to take a look at this business. 
If anyone is interested in working on it sooner, then please feel free to do so.
Comment 2 Leo Ufimtsev CLA 2016-11-29 11:55:45 EST
Note to self, fix would probably be like:

ColorRegistry colorRegistry =  JFaceResources.getColorRegistry();
Color foreground= colorRegistry.get("org.eclipse.ui.workbench.HOVER_FOREGROUND"); //$NON-NLS-1$
if (foreground == null) {
	foreground = display.getSystemColor(SWT.COLOR_INFO_FOREGROUND);
}
Color background= colorRegistry.get("org.eclipse.ui.workbench.HOVER_BACKGROUND"); //$NON-NLS-1$
if (background == null) {
	background = display.getSystemColor(SWT.COLOR_INFO_BACKGROUND);
}


or colorRegistry.getRGB(..) for RGB colors.
Comment 3 Eclipse Genie CLA 2020-07-06 05:26:01 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.