Bug 531274 - [Dark Theme] Info field in Generate HashCode and Equals not styled in dark theme
Summary: [Dark Theme] Info field in Generate HashCode and Equals not styled in dark theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Till Brychcy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 515514
Blocks: LinuxIDEColorTracker
  Show dependency tree
 
Reported: 2018-02-16 07:57 EST by Lars Vogel CLA
Modified: 2018-02-28 04:05 EST (History)
5 users (show)

See Also:

Attachments
Screenshot for the generate hash code and equals (36.66 KB, image/png)
2018-02-16 07:57 EST, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-02-16 07:57:42 EST 
Created attachment 272704 [details]
Screenshot for the generate hash code and equals

See screenshot.
Comment 1 Lars Vogel CLA 2018-02-16 08:02:07 EST 
Roland, also something for you?
Comment 2 Roland Grunberg CLA 2018-02-16 10:52:02 EST 
I think so. I'll have it block Bug 507072 to keep track of it more easily.
Comment 3 Till Brychcy CLA 2018-02-27 17:19:24 EST 
While testing the renamed Buttons, I noted that the problem exists almost in all Generate dialogs.
Seems to be related to Bug 515514.
Comment 4 Till Brychcy CLA 2018-02-28 02:53:16 EST 
The patch for bug Bug 515514 removed setting the JFace error color in MessageLine, so the easiest way to fix this is to simply completely remove the special background color handling, so the styling engine can always style the background.
Comment 5 Eclipse Genie CLA 2018-02-28 02:55:43 EST 
New Gerrit change created: https://git.eclipse.org/r/118327
Comment 6 Andrey Loskutov CLA 2018-02-28 03:02:42 EST 
(In reply to Till Brychcy from comment #4)
> The patch for bug Bug 515514 removed setting the JFace error color in
> MessageLine, so the easiest way to fix this is to simply completely remove
> the special background color handling, so the styling engine can always
> style the background.

There are people (our lab & our customers at least) who don't use styling engine at all. Will this work for this case too?
Comment 7 Till Brychcy CLA 2018-02-28 03:14:37 EST 
(In reply to Andrey Loskutov from comment #6)
> (In reply to Till Brychcy from comment #4)
> > The patch for bug Bug 515514 removed setting the JFace error color in
> > MessageLine, so the easiest way to fix this is to simply completely remove
> > the special background color handling, so the styling engine can always
> > style the background.
> 
> There are people (our lab & our customers at least) who don't use styling
> engine at all. Will this work for this case too?

Hmmm, In this case, the only thing the previous version of the code would do would be to set the background explictely to null if the status was non-empty. 
I assume when no styling is in effect, having no special handling for the background should just leave it at null, so it should have the same effect, but maybe you can test?
Comment 8 Lars Vogel CLA 2018-02-28 03:47:33 EST 
(In reply to Andrey Loskutov from comment #6)
> There are people (our lab & our customers at least) who don't use styling
> engine at all. Will this work for this case too?

Change from Till good to me with "General -> Appearance -> Enable theming" turned off and restart.
Comment 10 Lars Vogel CLA 2018-02-28 04:05:18 EST 
Thanks, Till.