Bug 516364 - Replace use of HOVER_ color with INFORMATION_
Summary: Replace use of HOVER_ color with INFORMATION_
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Roland Grunberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: ColorInfoApi
Blocks: LinuxIDEColorTracker
  Show dependency tree
 
Reported: 2017-05-09 09:24 EDT by Leo Ufimtsev CLA
Modified: 2018-04-25 11:52 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2017-05-09 09:24:27 EDT 
Once API is defined:
https://git.eclipse.org/r/#/c/96122/

I should replace string instances of:
org.eclipse.ui.workbench.HOVER_FOREGROUND
org.eclipse.ui.workbench.HOVER_BACKGROUND

With:
org.eclipse.ui.workbench.INFORMATION_FOREGROUND
org.eclipse.ui.workbench.INFORMATION_BACKGROUND
But not the string, but instead reference the API that will be defined in  JFacePreferences.java:
INFORMATION_FOREGROUND_COLOR
INFORMATION_BACKGROUND_COLOR

Related patches that I can base things of:
https://git.eclipse.org/r/#/c/96117/
https://git.eclipse.org/r/#/c/96123/
Comment 1 Leo Ufimtsev CLA 2017-10-12 11:50:28 EDT 
Dependent merged. I'll need to look into this. Currently pending till I finish webkit2 port.
Comment 2 Leo Ufimtsev CLA 2018-02-08 09:19:12 EST 

As a note:

org.eclipse.jdt.ui.Javadoc.backgroundColor
Comment 3 Leo Ufimtsev CLA 2018-02-08 09:25:33 EST 
@Roland

1) I dug up a patch I wrote a long time ago to replace the HOVER_ with INFORMATION_ in jdt:
https://git.eclipse.org/r/#/c/96117

I just updated the patch a bit, but I think it needs a rebase and a bit of testing/Roland's touch.

2) Also, this file contains a reference to HOVER_, which should probably be updated to INFORMATION_
/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBInfoColorFactory.java

3) as well as possibly this guy:
/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/AbstractAnnotationHover.java

4) In general, I think HOVER_* shouldn't be used anywhere to complete this task.
(Let me know, I can open all projects I've worked on and do a quick search to verify).
Comment 4 Noopur Gupta CLA 2018-03-28 01:39:49 EDT 
I'll have a look post Java 10 work.
Comment 6 Noopur Gupta CLA 2018-04-16 07:30:27 EDT 
Thanks, Leo and Roland for the patch.
Comment 7 Dani Megert CLA 2018-04-25 11:52:39 EDT 
Verfied in I20180422-2000.