Community
Participate
Working Groups
AbstractTableInformationControl contains some hard-coded info colors setting which makes the popup looks really bad on Linux in the light theme. I suggest to remove that color setting and re-use the standard shell style.
Created attachment 267369 [details] Before the change
Created attachment 267370 [details] After the change
New Gerrit change created: https://git.eclipse.org/r/93489
Adding Leo, Patric and Andrey as they worked on styling issues in the past. (Andrey actually work on not using styling ;-)) Leo or Patric, could you test the patch on Windows?
Created attachment 267386 [details] After the change on RHEL 7.2 Lars, I like the idea but don't like the implementation :-) I've tried the patch with both default GTK theme and without themes, it looks ugly because the table seem to use gray color for background by default. So please change the patch: revert to the old state (except SWT.COLOR_INFO* constants) and let it use some matching color definition, may be via PlatformUI.getWorkbench().getThemeManager().getCurrentTheme().getColorRegistry().get...
The color business has been on my todo list for a while. I'm still working on fixing up remaining webkit2 port business: Bug 441568 as webkit1 is removed in Fedora 26. But Once done with webkit2 port I've been meaning to finish off the color business that I started a while back. ~Eta this summer ish?.
Leo, is this something you can take?
Thank you for bringing this to my attention (again ^_^). I'll patch this up once the HOVER_ api patch is finished (added dependent) and we'll have "INFORMATION_" color available. Using that color will ensure it will look nice on regular themes and gets styled well on dark themes. Please feel free to CC me on other issues of that sort.
Dependent merged. I'll need to look into this. Currently pending till I finish webkit2 port.
Roland will take a look.
Please provide steps on how to tests/verify this.
Steps to reproduce : 1) While using the light theme, on Linux, open any 2 source/class files (eg. java.lang.Object, and java.lang.Exception) in the JDT Perspective. 2) Reduce the width of the editor area until there is insufficient room to display the tabs indicating the source/classes opened (eg. Object.class, Exception.class) 3) One of the 2 visible tabs will be replaced by a '>>' symbol with a '1' as a subscript. Click on this symbol to reveal a dropdown list containing the other opened source/class file. Note that the colour of the dropdown's background is black, on the light theme.
(In reply to Roland Grunberg from comment #12) > Steps to reproduce : > > 1) While using the light theme, on Linux, open any 2 source/class files (eg. > java.lang.Object, and java.lang.Exception) in the JDT Perspective. > 2) Reduce the width of the editor area until there is insufficient room to > display the tabs indicating the source/classes opened (eg. Object.class, > Exception.class) > 3) One of the 2 visible tabs will be replaced by a '>>' symbol with a '1' as > a subscript. Click on this symbol to reveal a dropdown list containing the > other opened source/class file. > > Note that the colour of the dropdown's background is black, on the light > theme. That's not what I see. For me on Windows 7 it is the usual hover color when using 'Light'. When using 'Dark' I do not see any difference (black with or without the patch). I also tried 'Light/Dark (Linux)', but no difference. So, is the difference only visible when using Linux? If so, can you attach some screen shots?
(In reply to Dani Megert from comment #13) > So, is the difference only visible when using Linux? See Comment 12 : 1) While using the light theme, on Linux,
Created attachment 273198 [details] After the change (In reply to Dani Megert from comment #13) >If so, can you attach some screen shots? New screenshot for after the change, see existing screenshot "Before the change"
(In reply to Lars Vogel from comment #14) > (In reply to Dani Megert from comment #13) > > So, is the difference only visible when using Linux? > > See Comment 12 : 1) While using the light theme, on Linux, Yep, saw that, but there was no information about (un-)expected changes on other Platforms.
Gerrit change https://git.eclipse.org/r/93489 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2d45c71441f3832901c93f66d5ca10b1cbff0158
Thanks for handling this so quickly (every other comment I try and make gets a mid-air collision :) ) I commented a bit on the review itself but didn't post to here. See comment #1, and 2 for patch set 4. This doesn't affect win32/macos and meant only for Linux on light theme.
