505851 – [Dark Theme] Style the HOVER_ colors for the dark theme

Bug 505851 - [Dark Theme] Style the HOVER_ colors for the dark theme

Summary: [Dark Theme] Style the HOVER_ colors for the dark theme

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.7 M4
Assignee:	Leo Ufimtsev
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	LinuxIDEColorTracker
	Show dependency tree

Reported:	2016-10-13 04:51 EDT by Lars Vogel
Modified:	2017-04-28 09:42 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change 501742 Git Commit Gerrit Change 505738 Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-10-13 04:51:22 EDT

This is a split of for Bug 501742. I will use Leos css change to style the dark theme correctly.

Comment 1 Eclipse Genie

2016-10-13 04:57:02 EDT

New Gerrit change created: https://git.eclipse.org/r/83090

Comment 2 Eclipse Genie

2016-10-13 10:08:57 EDT

Gerrit change https://git.eclipse.org/r/83090 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f6c15e2d083f770d3ecd9fd7c9a65154ae418a19

Comment 3 Lars Vogel

2016-10-13 10:09:45 EDT

Thanks Leo.

Comment 4 Lars Vogel

2016-10-13 10:23:11 EDT

Simon, could you add an entry for the N&N M3? I asked as neither Leo nor I have access to a windows system.

Comment 5 Leo Ufimtsev

2016-11-02 14:52:36 EDT

I'll be updating this one shortly.

Comment 6 Eclipse Genie

2016-11-02 14:57:23 EDT

New Gerrit change created: https://git.eclipse.org/r/84374

Comment 7 Leo Ufimtsev

2016-11-02 14:58:20 EDT

Renaming Javadoc to HOVER_

Comment 8 Leo Ufimtsev

2016-11-02 15:01:34 EDT

(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/84374

If someone has time, could you review the patch please?

This is the patch to style the new HOVER_ property for dark theme. Since JavaDoc will inherit from HOVER_, it replacing javadoc styling with HOVER_ seems sensible.

Tested, works well. Javadoc looks very readable on dark theme, looks the same as editor.

Comment 9 Eclipse Genie

2016-11-04 03:03:33 EDT

Gerrit change https://git.eclipse.org/r/84374 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=adad8404d40ee8e4d7e92ee4717e8bf1333d5577

Comment 10 Lars Vogel

2016-11-04 03:04:06 EDT

Thanks Leo.