Bug 427950 - [Graphics] Use PNG files for the Eclipse platform project instead of GIF files
Summary: [Graphics] Use PNG files for the Eclipse platform project instead of GIF files
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.5   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 422040 426024 426025 426107 426110 426116 426247 426306 426365 430127 430694 431093 432186 432217 432741 433714 433716 465456 465778 465781 493931
Blocks:
  Show dependency tree
 
Reported: 2014-02-11 18:30 EST by Lars Vogel CLA
Modified: 2016-06-03 09:26 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-02-11 18:30:20 EST
The Eclipse platform projects currently use mainly gif files which do not support a real transparency. We should switch to png files, wherever possible.

This is supposed to be master bug for the different changes in the platform plug-ins including JDT.
Comment 1 David Williams CLA 2014-04-14 11:07:11 EDT
Adding bug 432741 as "child" of this one. I thought there was another, more general bug, but since I could not find it, thought I'd at least document the relationship here. 

The "general" part of bug 432741 is the standard guidelines of 

http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

which says the "icon.xpm" file we specify for Linux is "supported for legacy" reasons, but ... png preferred, and svg optional ... and I think even those "guidelines" are pretty old -- and not sure if widely accepted as "standard" or not. So, can leave the "icon.xpm" file in our distributions, in case any "old" platforms need it ... but, but 432751 is "linux specific" and more so only tested on "Ubuntu", so if anyone has any RedHat or "HP" machines to test with that'd be great. I'm assume it makes "no difference" on those other platforms, but perhaps makes an improvement if someone is using some particular 'fancy' desktop.
Comment 2 Markus Keller CLA 2015-04-26 12:04:31 EDT
Note for adopters: E4 stores a reference to the extension point contribution
org.eclipse.ui.editors > editor > icon 
for each editor tab that is open when the workbench shuts down (bug 465456).

Projects that switch to .png graphics need to keep the .gif versions for such icon contributions. Please mention bug 465456 in the comment of the commit that removes most .gif files but leaves a few around.
Comment 3 Markus Keller CLA 2015-04-28 14:46:29 EDT
(In reply to Markus Keller from comment #2)
> Note for adopters:

Update (via bug 465456):
Bundles need to keep the *.gif icons of values contributed in extension points:
- org.eclipse.ui.editors > editor > icon (typically in /icons/full/obj16/)
- org.eclipse.ui.views > view > icon (complete /icons/full/eview16/ folder)
Comment 4 Lars Vogel CLA 2015-05-22 07:10:37 EDT
I declare victory for this aggregator bug and we will solve remaining issues via separate bugs. 

Thanks again to Tony and all involved projects to make the transition possible.