Community
Participate
Working Groups
Not sure what to do with the XDOCtask.xml and anttasks_1.6.0.xml file. I left them out. https://git.eclipse.org/r/#/c/20909/
Merged with: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=a8b669c8d0ae2761def200851e67f66686b18dc3 Thanks Lars.
(In reply to Michael Rennie from comment #2) > Merged with: > http://git.eclipse.org/c/platform/eclipse.platform.git/commit/ > ?id=a8b669c8d0ae2761def200851e67f66686b18dc3 > > Thanks Lars. Thanks for merging!
The Ant looks more like a spider now and looks blurred / washed out. Please provide updated icons or revert to GIF for Luna.
Images are already updated by Tony in our org.eclipse.ui.images plug-in. Tony, do you want to provide a Gerrit review for the org.eclipse.ant.ui plug-in images?
Created attachment 242781 [details] Good (4.3)
Created attachment 242782 [details] Blurred (4.4 M7)
(In reply to Dani Megert from comment #7) > Created attachment 242782 [details] > Blurred (4.4 M7) There's actually a newer one in a gerrit submission, I will find it.
(In reply to Tony McCrary from comment #8) > (In reply to Dani Megert from comment #7) > > Created attachment 242782 [details] > > Blurred (4.4 M7) > > There's actually a newer one in a gerrit submission, I will find it. I commited that to org.eclipse.ui.images already, see https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=11402300085b0d464f67664531bce8c89d681892. If you want I can create an Gerrit review for the ant repo but I wanted to know if you would prefer to do that.
(In reply to Lars Vogel from comment #9) > (In reply to Tony McCrary from comment #8) > > (In reply to Dani Megert from comment #7) > > > Created attachment 242782 [details] > > > Blurred (4.4 M7) > > > > There's actually a newer one in a gerrit submission, I will find it. > > I commited that to org.eclipse.ui.images already, see > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=11402300085b0d464f67664531bce8c89d681892. > > If you want I can create an Gerrit review for the ant repo but I wanted to > know if you would prefer to do that. Yes, please. I don't want to dig out the relevant files from ui.images myself ;-).
https://git.eclipse.org/r/26167
Created attachment 242837 [details] 3.8 vs. proposed change (In reply to Lars Vogel from comment #11) > https://git.eclipse.org/r/26167 The view icon is acceptable now, but I'd say it's a bit to dark/black still. In the "add" icon it's still hard to see the '+'. Besides that, it fixes none of the issues from comment 7.
(In reply to Dani Megert from comment #12) > Besides that, it fixes none of the issues from comment 7. Looks like we need an update from Tony. I ping him via email.
(In reply to Lars Vogel from comment #13) > (In reply to Dani Megert from comment #12) > > Besides that, it fixes none of the issues from comment 7. > > Looks like we need an update from Tony. I ping him via email. Please set the review flag when a new version is ready.
Pushed a revert of the blurry ants to: https://git.eclipse.org/r/#/c/27032/ retargetting to 4.5 (unless we get new images for RC3). Curtis / Dani, please review the revert for RC2
(In reply to Michael Rennie from comment #15) > Curtis / Dani, please review the revert for RC2 +1 for reverting
Published with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=416cd3b5e94363aeb4168b359c963702a1da95f8
Created attachment 243470 [details] batik vs inkscape render comparison I've found the issue with this icon and it appears to be the batik renderer. I've attached an image that compares output from Inkscape vs Batik (as well as the gif reference image). I've updated the icons in the same bundle and will perform a manual render of the images for a gerrit submission shortly.
(In reply to Tony McCrary from comment #18) > Created attachment 243470 [details] > batik vs inkscape render comparison > > I've found the issue with this icon and it appears to be the batik renderer. > I've attached an image that compares output from Inkscape vs Batik (as well > as the gif reference image). > > I've updated the icons in the same bundle and will perform a manual render > of the images for a gerrit submission shortly. Here is a gerrit sub containing the new ant icons (like the above attachment): https://git.eclipse.org/r/#/c/27315/
(In reply to Tony McCrary from comment #19) > (In reply to Tony McCrary from comment #18) > > Created attachment 243470 [details] > > batik vs inkscape render comparison > > > > I've found the issue with this icon and it appears to be the batik renderer. > > I've attached an image that compares output from Inkscape vs Batik (as well > > as the gif reference image). > > > > I've updated the icons in the same bundle and will perform a manual render > > of the images for a gerrit submission shortly. > > Here is a gerrit sub containing the new ant icons (like the above > attachment): https://git.eclipse.org/r/#/c/27315/ This submission adds the new ant icons to eclipse.platform: https://git.eclipse.org/r/#/c/27366/
David pushed the updated icons with (thanks David): http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b6d4a21ea7f42d2c0ca03f29d34bc310d9797eff Updated bundle version: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=4ca2577ec60826e7c59fdbd4cb2c1ba4cce2c03f
Here is the commit with the new icons for our org.eclipse.ui.images plug-in https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=07341d8063684bec3be7d2207f0683b45e6dfd8c
Verified using Eclipse SDK Version: Mars (4.5) Build id: I20140806-2000
I'm fine with the icons now.
