Community
Participate
Working Groups
Dani Megert gave his OK to continue to do some icon work for the dark theme in case the icons get reviewed. Maybe we can fix at the most prominent PDE icons? I start with the run icon which is pretty prominent in the PDE UI.
Created attachment 242425 [details] Git
Created attachment 242426 [details] png file
https://git.eclipse.org/r/25700
Debug icon https://git.eclipse.org/r/25702
Help icon https://git.eclipse.org/r/25703
I think these are the most visible icons, would be great if you could review and apply them, if you see no issues with the icons.
Dani, are there any concerns with switching the icons? I won't have time for reviewing beyond 'do they show up ok in Win7 high contrast mode'.
(In reply to Curtis Windatt from comment #7) > Dani, are there any concerns with switching the icons? I won't have time > for reviewing beyond 'do they show up ok in Win7 high contrast mode'. They must look the same (or at least very similar) to the existing ones and not look washed out or blurry on our major platforms.
(In reply to Dani Megert from comment #8) > (In reply to Curtis Windatt from comment #7) > > Dani, are there any concerns with switching the icons? I won't have time > > for reviewing beyond 'do they show up ok in Win7 high contrast mode'. > > They must look the same (or at least very similar) to the existing ones and > not look washed out or blurry on our major platforms. Curtis, we use these icons already in the platform, hence these icons should be fine.
(In reply to Curtis Windatt from comment #7) > Dani, are there any concerns with switching the icons? I won't have time > for reviewing beyond 'do they show up ok in Win7 high contrast mode'. Curtis can you have a look? Tony who does this icon work in his private time, typically has also limitations when he can do desired updates.
(In reply to Lars Vogel from comment #9) > (In reply to Dani Megert from comment #8) > > (In reply to Curtis Windatt from comment #7) > > > Dani, are there any concerns with switching the icons? I won't have time > > > for reviewing beyond 'do they show up ok in Win7 high contrast mode'. > > > > They must look the same (or at least very similar) to the existing ones and > > not look washed out or blurry on our major platforms. > > Curtis, we use these icons already in the platform, hence these icons should > be fine. I randomly picked one of the changes (help.png) and it suggests to replace a 16x16 image with a 24x24 image, which of course looks bad in the UI. I therefore rejected all three changes. Please provide one change with all PNG changes and not one change for each, this is much easier to load into the workbench and review. Before doing this make sure you verify that PNG and GIF are identical, not blurry, not different size,... and test it in the workbench.
(In reply to Dani Megert from comment #11) > Please provide one change with all PNG > changes and not one change for each, this is much easier to load into the > workbench and review. Thanks, sounds good, also easier to upload. I assumed one change per icon makes the review process easier. Good to hear that is not the case. I create a new review..
Tony, could you upload a correct set of icons to org.eclipse.ui.images via Gerrit? I integrated them into PDE.
Any update on this one?
JDT icons are very close to finished, I'll work on getting PDE's icons ready this week.
(In reply to Tony McCrary from comment #15) > JDT icons are very close to finished, I'll work on getting PDE's icons ready > this week. Tony, any news?
If this cannot be done by next Tuesday we should probably move it out of M5
I'm still working on the PDE icon set as a whole. For Tuesday, I will get the prominent icons listed in the gerrit reviews fixed.
any update here
(In reply to Vikas Chandra from comment #20) > any update here I try to catch Tony at EclipseCon... :-)
Tony, can you created and upload a comparison of the new and old icons?h
Created attachment 251991 [details] Icon Gallary I've attached a comparison gallery for PDE's new icons. There are two columns for light and dark background comparison. The gif is on the left, png on the right for each background color. Vikas, if you find the new icons good, I can create a Gerrit review for the update. If give the review priority, if there is review of the icons required Tony needs time to do this.
Many of the new icons look overly anti-aliased (fuzzy) compared to the originals.
Can you please list the ones that you find issues with, thanks.
Pretty much all the new ones have less definition than the originals. This is particularly obvious at the border. For instance, plugin_obj or java_lib_obj
(In reply to Tony McCrary from comment #25) > Can you please list the ones that you find issues with, thanks. I think the following looks fuzzy: alphab_sort_co alphab_sort_co_mini java_lib_obj warning_st_obj plugin_obj These can be potentially removed from the repo, I do not see the gif version for them: clear_co warning_ovr This might be a typo or can be delete, the Copy is definitely wrong, but I also do not see a plugin_persp.gif version plugin_persp - Copy --- Thanks again Tony for updating these icons in your private time.
Created attachment 252612 [details] April 21 2015 Gallery I've updated the icons we've discussed. There are also many new icons, more will be coming this week.
Created attachment 252704 [details] April 24 2015 Gallery Updated gallery. I'm getting close but need to cleanup some of the newer icons tomorrow. I expect to have these in pretty decent shape by EOD.
For what it's worthy... They all still look fuzzier at the edges and in detail areas than the original gifs. Not an improvement to my eye.
(In reply to Konstantin Komissarchik from comment #30) > For what it's worthy... They all still look fuzzier at the edges and in > detail areas than the original gifs. Not an improvement to my eye. Hi Konstantin, There are definitely some that still need to be cleaned up, as my last comment mentioned. However there are some that are pretty much finished which makes me wonder, do you perhaps have some kind of zoom setting in your image viewer/browser? or perhaps some kind of visual impairment/disability?
I am looking at the images at their intended resolution and I see just fine. The images appear to me to have aliasing artifacts that I would associate with increasing the image size and then reducing back down. Where as many of the originals have a crisp defined border that makes the icon pop, the border is lighter and faded out in the new versions.
Well perhaps have your monitor checked out. Many of the icons in that image were already vetted on other projects (Platform, JDT) and many are in Eclipse already. If you have the need to provide further feedback, please be more specific.
> Well perhaps have your monitor checked out. Please stop with personal attacks. That's not constructive. I tried to give you concrete and specific feedback as a user and as amateur dabbler in all things image related. At this point, I will not comment further on this thread. If a quorum of PDE committers think these images are an improvement, then that's a decision they will have to live with.
(In reply to Konstantin Komissarchik from comment #34) > > Well perhaps have your monitor checked out. > > Please stop with personal attacks. That's not constructive. Thanks Konstantin for your feedback. Tony does this icon work in his private time and therefore he looks for specific feedback. I think it is safe to assume that Tony has the best intents and does not mean to insult anybody. > I tried to give > you concrete and specific feedback as a user and as amateur dabbler in all > things image related. At this point, I will not comment further on this > thread. If a quorum of PDE committers think these images are an improvement, > then that's a decision they will have to live with. Thanks, we take it up from here.
New Gerrit change created: https://git.eclipse.org/r/46478 WARNING: this patchset contains 57017 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Created attachment 252759 [details] April 25 2015 Gallery Here's an updated gallery and the png/svg commit for the source icon repo. Let me know if any icons have issues and I'll get them fixed tomorrow.
Dani/Markus, What is your feedback on the latest icons.
(In reply to Vikas Chandra from comment #38) > Dani/Markus, > > What is your feedback on the latest icons. FYI - JDT accepted the latest icons from Tony. See Bug 426025. Also if you find an issue, Tony has a record of providing an improved version with a small delay. I hope this improves the confidence.
(In reply to Vikas Chandra from comment #38) > Dani/Markus, > > What is your feedback on the latest icons. Noopur, please take an initial look. Thanks.
(In reply to Tony McCrary from comment #37) > Created attachment 252759 [details] > April 25 2015 Gallery > > Here's an updated gallery and the png/svg commit for the source icon repo. > > Let me know if any icons have issues and I'll get them fixed tomorrow. Most of the icons look good/better in png. Following icons can be revisited: - debug_exc: bug's legs are not clearly visible in dark theme - doc_co: can be made darker like in gif - eclipse, eclipse_launcher: the new color is different than in gif - environment: map on the globe in not visible - external_co: new arrow is very thick - find_obj: the tip can be made sharper and darker like in gif - friend_co: looks little blurred compared to gif - psearch_obj: both the tips need to be improved like in gif - runtime_obj: green bars can be made sharper and darker like in gif - swt_launcher: text "SWT" is little blurred - th_horizontal: triangles in the second column can be improved - tsk_alert_obj: diamond shape is not as good as in gif - variable_tab: is now smaller, lighter and not clearly visible in dark theme
Thanks for evaluating Noopur. I agree with a few caveats: - debug_exc: this is the same icon we've been using elsewhere in platform/debug/jdt. We can redesign for better contrast on dark backgrounds but I'm not sure we want to do it right now? - eclipse, eclipse_launcher: the new colors are done on purpose to match Eclipse's "new" color scheme. The more red/purple icon was an older eclipse style (like 2.x days I think?). Similar colors are using in platform and jdt. - external_co: I believe we are using this icon in JDT currently (I will double check and update if not) I will fix the others and update the gerrit submission.
(In reply to Tony McCrary from comment #42) > Thanks for evaluating Noopur. I agree with a few caveats: > > - debug_exc: this is the same icon we've been using elsewhere in > platform/debug/jdt. We can redesign for better contrast on dark backgrounds > but I'm not sure we want to do it right now? > - eclipse, eclipse_launcher: the new colors are done on purpose to match > Eclipse's "new" color scheme. The more red/purple icon was an older eclipse > style (like 2.x days I think?). Similar colors are using in platform and jdt. > - external_co: I believe we are using this icon in JDT currently (I will > double check and update if not) > > I will fix the others and update the gerrit submission. Sounds good.
(In reply to Konstantin Komissarchik from comment #32) > I am looking at the images at their intended resolution and I see just fine. > The images appear to me to have aliasing artifacts that I would associate > with increasing the image size and then reducing back down. Where as many of > the originals have a crisp defined border that makes the icon pop, the > border is lighter and faded out in the new versions. I agree with Konstantin that there is a loss of crisp border on many of the icons (delete_edit, discovery, filter_ps, and many more). However, there are major improvements to the icons, especially making them work on the dark theme. PDE will definitely be moving forward with replacing the icons. Thanks Noopur for the indepth review.
New Gerrit change created: https://git.eclipse.org/r/46605
Created attachment 252820 [details] April 27 2015 Gallery
(In reply to Tony McCrary from comment #46) > Created attachment 252820 [details] > April 27 2015 Gallery Looks good.
I integrated https://git.eclipse.org/r/#/c/46605/ into our common icon repository. Vikas, if the icons are OK for you, can you integrate them into PDE? Or if you prefer, I (or Tony) can provide a Gerrit review to integrate them.
A Gerrit review will help
(In reply to Lars Vogel from comment #48) > Vikas, if the icons are OK for you, can you integrate them into PDE? Or if > you prefer, I (or Tony) can provide a Gerrit review to integrate them. Would that be today? Today is our last official M7 build. I'd like to have those icons when doing our 2 day test pass next week. The change should also - Remove the GIFs, except those used in editors and views extension point, for details see bug 465456. - Adjust the code.
(In reply to Dani Megert from comment #50) > (In reply to Lars Vogel from comment #48) > > Vikas, if the icons are OK for you, can you integrate them into PDE? Or if > > you prefer, I (or Tony) can provide a Gerrit review to integrate them. > > Would that be today? Today is our last official M7 build. I'd like to have > those icons when doing our 2 day test pass next week. Working on it. Almost done with the adjustment. > The change should also > - Remove the GIFs, except those used in editors and views extension point, > for > details see bug 465456. > - Adjust the code. I plan to leave the GIF in for for 4.5 and remove them early in 4.6
New Gerrit change created: https://git.eclipse.org/r/46747
(In reply to Lars Vogel from comment #51) > (In reply to Dani Megert from comment #50) > > (In reply to Lars Vogel from comment #48) > > > Vikas, if the icons are OK for you, can you integrate them into PDE? Or if > > > you prefer, I (or Tony) can provide a Gerrit review to integrate them. > > > > Would that be today? Today is our last official M7 build. I'd like to have > > those icons when doing our 2 day test pass next week. > > Working on it. Almost done with the adjustment. > > > The change should also > > - Remove the GIFs, except those used in editors and views extension point, > > for > > details see bug 465456. > > - Adjust the code. > > I plan to leave the GIF in for for 4.5 and remove them early in 4.6 Vikas, please remove them after applying the change. Otherwise we almost double the size of the JAR.
(In reply to Dani Megert from comment #53) > Vikas, please remove them after applying the change. Otherwise we almost > double the size of the JAR. In the past we had concerns about other projects referring to such icons via platform:// references. I can also provide a second Gerrit review with the removal.
New Gerrit change created: https://git.eclipse.org/r/46755
Adding the png files and the required code changes, except for the missing icons reported via Bug 465769: https://git.eclipse.org/r/46747 Deleting the Gif icons which are not used by editors and views. https://git.eclipse.org/r/46755
Vikas, is busy, I commit after M7.
(In reply to Lars Vogel from comment #56) > Adding the png files and the required code changes, except for the missing > icons reported via Bug 465769: > > https://git.eclipse.org/r/46747 Has been updated with the missing icons, provided by Tony.
According to the end game rules I need +1 by another committer. Vikas, can you +1 this bug?
I looked at the changes. I can verify that the latest change of gerrit commit in comment#58 ensures that the new icons are picked. I checked few of the icons in the comprehensive icon list in the launched eclipse with this change. Plugin.xml needs 2015 license year but I guess it is trivial ( but better to change before commit) >> I plan to leave the GIF in for for 4.5 and remove them early in 4.6 We need a defect for this.
(In reply to Vikas Chandra from comment #60) > I looked at the changes. > > I can verify that the latest change of gerrit commit in comment#58 ensures > that the new icons are picked. I checked few of the icons in the > comprehensive icon list in the launched eclipse with this change. Thanks. > Plugin.xml needs 2015 license year but I guess it is trivial ( but better to > change before commit) Thanks, will do that. > >> I plan to leave the GIF in for for 4.5 and remove them early in 4.6 > We need a defect for this. Dani requested that we do this immediately so I have https://git.eclipse.org/r/46755 for that.
I think, these icons should not be deleted 1) ui/org.eclipse.pde.ui/icons/obj16/plugin_mf_obj.gif Used at <extension point="org.eclipse.ui.editors"> <editor default="true" name="%editors.pluginManifest.name" icon="$nl$/icons/obj16/plugin_mf_obj.gif" class="org.eclipse.pde.internal.ui.editor.plugin.ManifestEditor" 2) ui/org.eclipse.pde.ui/icons/obj16/cheatsheet_obj.gif used in <extension point="org.eclipse.ui.editors"> <editor class="org.eclipse.pde.internal.ua.ui.editor.cheatsheet.simple.SimpleCSEditor" contributorClass="org.eclipse.pde.internal.ua.ui.editor.cheatsheet.simple.SimpleCSEditorContributor" icon="$nl$/icons/obj16/cheatsheet_obj.gif" id="org.eclipse.pde.ua.ui.simpleCheatSheetEditor" Plus we need to delete icons for ds.ui except icons/obj16/ds_obj.gif used in <plugin> <extension point="org.eclipse.ui.editors"> <editor class="org.eclipse.pde.internal.ds.ui.editor.DSEditor" contributorClass="org.eclipse.pde.internal.ds.ui.editor.DSEditorContributor" default="true" icon="$nl$/icons/obj16/ds_obj.gif" see bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=465456
(In reply to Vikas Chandra from comment #62) > I think, these icons should not be deleted Thanks, I update the review before committing.
(In reply to Lars Vogel from comment #63) > (In reply to Vikas Chandra from comment #62) > > I think, these icons should not be deleted > > Thanks, I update the review before committing. Please make sure that all icons for contributed editors and views are kept.
I re-checked everything and a png version of "dlcl16/remove_att.gif is missing. I contacted Tony about it, and update the Gerrit review to leave the gif reference for this file
Gerrit change https://git.eclipse.org/r/46747 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a9477647d360eac5347891b761450f13d4abd693
(In reply to Eclipse Genie from comment #66) > Gerrit change https://git.eclipse.org/r/46747 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=a9477647d360eac5347891b761450f13d4abd693 This adds the new icons and adjusts the code, except for "dlcl16/remove_att.gif".
(In reply to Vikas Chandra from comment #62) > I think, these icons should not be deleted Update review to not delete the following icons: /icons/obj16/plugin_mf_obj.gif /icons/obj16/cheatsheet_obj.gif This icon is not present in pde.ui, it is contained in pde.ds.ui which I handle via a separate bug. /icons/obj16/ds_obj.gif
Gerrit change https://git.eclipse.org/r/46755 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0585fbb84b8363bfdb964bffe51f98b56d4c25da
(In reply to Eclipse Genie from comment #69) > Gerrit change https://git.eclipse.org/r/46755 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=0585fbb84b8363bfdb964bffe51f98b56d4c25da This commit removes the old gifs (except for the views and editors). I leave that bug open in the hope that Tony provides the one missing icon for PDE UI.
New Gerrit change created: https://git.eclipse.org/r/47397
I need to restore more gifs, see Bug 433714.
(In reply to Eclipse Genie from comment #66) > Gerrit change https://git.eclipse.org/r/46747 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a9477647d360eac5347891b761450f13d4abd693 > This removes 2 eclipse16.png icons, which even cause new warnings in /org.eclipse.pde.ui/plugin.xml. The PDE launch configuration icons are missing now.
Gerrit change https://git.eclipse.org/r/47397 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fe385a38ba596a86feb35ac533d6bfa8f5137fda
(In reply to Markus Keller from comment #73) > (In reply to Eclipse Genie from comment #66) > > Gerrit change https://git.eclipse.org/r/46747 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a9477647d360eac5347891b761450f13d4abd693 > > > > This removes 2 eclipse16.png icons, which even cause new warnings in > /org.eclipse.pde.ui/plugin.xml. The PDE launch configuration icons are > missing now. As far as I can see only ui/org.eclipse.pde.ui/icons/etool16/eclipse16.png is needed and ui/org.eclipse.pde.ui/icons/obj16/eclipse16.png can be deleted.
New Gerrit change created: https://git.eclipse.org/r/47462
Gerrit change https://git.eclipse.org/r/47462 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4c047e98a83401f640b185bd65e4a390868f66ad
New Gerrit change created: https://git.eclipse.org/r/47464
Gerrit change https://git.eclipse.org/r/47464 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=2c929a007c95973c2bdd6f52268ee5a742a41610
(In reply to Eclipse Genie from comment #77) > Gerrit change https://git.eclipse.org/r/47462 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=4c047e98a83401f640b185bd65e4a390868f66ad This restores the eclipse16.png and adds the missing "dlcl16/remove_att.png" which Tony provided yesterday. Eclipse launcher icons is back in my test workspace with this change. (In reply to Eclipse Genie from comment #79) > Gerrit change https://git.eclipse.org/r/47464 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=2c929a007c95973c2bdd6f52268ee5a742a41610 This one adds three additional gifs back, which were reported in my PDE test workspace with all views open.
*** Bug 466674 has been marked as a duplicate of this bug. ***
*** Bug 466796 has been marked as a duplicate of this bug. ***
Verified in 4.5.0.I20150507-2000 that the Launcher icon is back, the rest of the icons looks also well and I see no error related to missing icons.
This broke links in the PDE documentation which refers to some of the GIFs. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=483439435592a3036f14a34c3cd10cb36ef5004b
