465781 – [Graphics] Update org.eclipse.pde.ds.ui to png files

Bug 465781 - [Graphics] Update org.eclipse.pde.ds.ui to png files

Summary: [Graphics] Update org.eclipse.pde.ds.ui to png files

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.5 RC1
Assignee:	Tony McCrary
QA Contact:

URL:
Whiteboard:
Keywords:	greatfix

Depends on:
Blocks:	427950
	Show dependency tree

Reported:	2015-04-29 05:35 EDT by Lars Vogel
Modified:	2015-05-07 13:08 EDT (History)
CC List:	5 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit

Flags:	Vikas.Chandra: review+ Lars.Vogel: review+

Attachments
Gallery (25.51 KB, image/png) 2015-04-29 05:40 EDT, Lars Vogel	no flags	Details
April 29 2015 Gallery (25.58 KB, image/png) 2015-04-29 19:21 EDT, Tony McCrary	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2015-04-29 05:35:58 EDT

Comment 1 Lars Vogel

2015-04-29 05:40:27 EDT

Created attachment 252881 [details]
Gallery

Comment 2 Lars Vogel

2015-04-29 05:41:42 EDT

Dani, Noopur, Gallery looks really good for me.

Comment 3 Noopur Gupta

2015-04-29 05:58:32 EDT

Looks good. Two minor concerns:

- attribute_obj: 'a' within the circle is probably elongated now and not at the exact center of the circle.

- class_obj: The old and new icons have difference in vertical alignment. It should be checked that it does not change the icon position at the place where it is used in the IDE or it looks better with the new position.

Comment 4 Lars Vogel

2015-04-29 06:00:32 EDT

Tony, any change to get the reported issues fixed relatively fast? If yes, I have hope to get this still into M7 or RC1.

Comment 5 Tony McCrary

2015-04-29 08:35:44 EDT

The fixed icons already exist in the main PDE bundle, I'll update pde.ds.ui today.

Comment 6 Eclipse Genie

2015-04-29 19:20:58 EDT

New Gerrit change created: https://git.eclipse.org/r/46825

Comment 7 Tony McCrary

2015-04-29 19:21:31 EDT

Created attachment 252919 [details]
April 29 2015 Gallery

Comment 8 Noopur Gupta

2015-04-30 01:31:47 EDT

(In reply to Tony McCrary from comment #7)
> Created attachment 252919 [details]
> April 29 2015 Gallery

Looks good.

Comment 9 Eclipse Genie

2015-04-30 03:22:40 EDT

Gerrit change https://git.eclipse.org/r/46825 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f830ce6ca4ca68f550128811e9039073e4506ba6

Comment 10 Eclipse Genie

2015-04-30 06:01:08 EDT

New Gerrit change created: https://git.eclipse.org/r/46856

Comment 11 Eclipse Genie

2015-04-30 06:04:50 EDT

New Gerrit change created: https://git.eclipse.org/r/46857

Comment 12 Vikas Chandra

2015-05-06 05:16:16 EDT

+1 to https://git.eclipse.org/r/46857

The updated icons are reflected in DS tooling UI.

Comment 13 Lars Vogel

2015-05-06 05:20:02 EDT

(In reply to Vikas Chandra from comment #12)
> +1 to https://git.eclipse.org/r/46857
> 
> The updated icons are reflected in DS tooling UI.

Please set the review flag in the bug.

Comment 14 Eclipse Genie

2015-05-06 13:08:51 EDT

Gerrit change https://git.eclipse.org/r/46856 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=83acca6e1d5fc591aa97c7e1b198446a2168ec88

Comment 15 Eclipse Genie

2015-05-06 13:13:24 EDT

Gerrit change https://git.eclipse.org/r/46857 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5ee7e9260a566e7789c8f29cb0dd27cdb5f2b499

Comment 16 Lars Vogel

2015-05-06 13:14:10 EDT

Thanks Tony, I'm very happy that I was finally able to integrate your amazing work into PDE.

Comment 17 Lars Vogel

2015-05-07 13:08:47 EDT

Verified in 4.5.0.I20150506-2000, I did not see any exception working with declarative services in Eclipse related to icons.

Comment 18 Lars Vogel

2015-05-07 13:08:59 EDT