Community
Participate
Working Groups
gif files looks really bad on a dark background and we got this great contribution from Tony McCrary who have re-drawn all gif files in SVG and created a Mojo to generate png files from them. I suggest to use them in org.eclipse.debug.ui.
https://git.eclipse.org/r/20815
Wow, the new png files look really nice. Are there plans to also update org.eclipse.ui.console? It is part of platform debug, so it would be convenient if you updated it as part of this bug. Also, is there a plan to have someone remove all of the unused gif files (keeping in mind some of the gif files are referenced from the platform doc bundles)?
(In reply to Michael Rennie from comment #2) > Also, is there a plan to have someone remove all of the unused gif files > (keeping in mind some of the gif files are referenced from the platform doc > bundles)? I think the removal of the gif files will lead to a long discussion as other plug-ins might refer to existing gif files. I plan to start this discussion after the png replacement to avoid that people object against this change. Console is also planned, I update the review soon.
Gerrit review updated with the icons for the console https://git.eclipse.org/r/#/c/20815/
Created attachment 239886 [details] Icons Looks pretty awesome on a dark theme.
(In reply to Michael Rennie from comment #2) > Wow, the new png files look really nice. Are there plans to also update > org.eclipse.ui.console? It is part of platform debug, so it would be > convenient if you updated it as part of this bug. Would be nice if you have review https://git.eclipse.org/r/#/c/20815/ The change should be complete for debug and console and the new icons look IMHO way better than the gif ones.
(In reply to Lars Vogel from comment #6) > (In reply to Michael Rennie from comment #2) > > Wow, the new png files look really nice. Are there plans to also update > > org.eclipse.ui.console? It is part of platform debug, so it would be > > convenient if you updated it as part of this bug. > > Would be nice if you have review https://git.eclipse.org/r/#/c/20815/ > > The change should be complete for debug and console and the new icons look > IMHO way better than the gif ones. The new icons from https://git.eclipse.org/r/#/c/20815/ have been reviewed and submitted. We are still missing new icons for ui.external.tools which is also part of the platform debug repo.
This has been merged: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=b0f2acfda47696c9cf1b51ca3c4fdf3eb42bf9e0
(In reply to Michael Rennie from comment #8) > This has been merged: > > http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/ > ?id=b0f2acfda47696c9cf1b51ca3c4fdf3eb42bf9e0 Should have mentioned that I opened bug 430127 for the external tools icons so we don't have to keep this one open.
(In reply to Michael Rennie from comment #8) > This has been merged: > > http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/ > ?id=b0f2acfda47696c9cf1b51ca3c4fdf3eb42bf9e0 Thanks Michael for applying the review, this make the icons on a dark theme look so much better.
I plan to add this to the N&N M7
