Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-dev] Java File Encoding and other settings.

I'd use internal classes and open enhancement request against jdt to
provide API to support this usecase.

--
Regards,
Igor

On 11-05-23 03:58 PM, olivier nouguier wrote:
Now I need to parse the formatter configuration, quite an easy sax
parsing, but the job is already done in an internal class of the JDT...
(org.eclipse.jdt.internal.ui.preferences.formatter.FormatterProfileStore.readProfilesFromStream(InputSource
inputSource) );
I guess this situation occurs often what should I do:
- write my own parser (then dupplicate the code).
- use the internal and ignore warning.
Thx

On Fri, May 13, 2011 at 2:34 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx
<mailto:igor@xxxxxxxxxxxxxx>> wrote:

    You can use IMaven.resolve to resolve single artifact. This should be
    much easier to use than either Aether or Maven repository access APIs.

    --
    Regards,
    Igor


    On 11-05-11 11:58 AM, olivier nouguier wrote:

        On Wed, May 11, 2011 at 1:29 PM, Igor Fedorenko
        <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>> wrote:

            I am still not sure I understand all alternatives.

            When you say "dependency", do you mean project-level
        <dependency/>
            element or something under plugin configuration like in the
        examples you
            provided? I don't think using project level dependencies for
        code
            formatter configuration is a good idea.

        Under the plugin


            When you say "manual resolution", what do you mean exactly?
        Bypassing
            aether and/or maven repository API and talking to remote
        repositories
            directly?

        Using Aether.


            I also do not understand how you plan to take advantage of
        transitive
            dependency resolution, with or without use of classloaders.
        You just
            need a single xml document with code formatter
        configuration, right?

        There is not advantage at all, as you say for some simples file ...
        Thanks

            --
            Regards,
            Igor


            On 11-05-11 03:58 AM, olivier nouguier wrote:

                First I want the that the configuration remains shared as an
                artictact.
                Then the question is how do I retrieve this artifact:
                1a) As a dependency with transitive resolution.
                1b) As a dependency *without* transitive resolution
                2) As a manual resolution.

                AFAIU my problem is that with the option (1a), if a want
        to be able
                (easily) to transitively resolve resources I must use a
                classloader on
                dependencies.

                With option (1b) and (2) a can retrieve the resources
        for the
                artifact
                directly.

                On Tue, May 10, 2011 at 11:34 PM, Igor Fedorenko
        <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>>> wrote:

                    I assumed this is how you wanted to implement it, to be
                honest. What are
                    the alternatives?

                    --
                    Regards,
                    Igor


                    On 11-05-10 04:56 PM, olivier nouguier wrote:

                        @Igor
                        After more reflexion, do you think I should not
        use the
                dependency
                        mecanism to resolve my configuration file ?

                        I could provide extra configuration:

        <plugin>
        <groupId>org.eclipse.maven.plugins</groupId>
        <artifactId>maven-eclipse-plugin</artifactId>
        <version>1.0.0</version>
        <configuration>
        <artifact>
        <groupId>my.corporate.namespace</groupId>
        <artifactId>my-corporate-config</artifactId>
        <version>1.0.0</version>
        </artifact>
        <formatter>my-formatter-config.xml</formatter>
        </configuration>
        </plugin>

                        Then "manually" (with Aether api) resolve the
        artifact and
                        finally load
                        the file from the jar.

                        What do you think of this solution.

                        Thanks.

                        On Tue, Apr 19, 2011 at 8:26 AM, olivier nouguier
        <olivier.nouguier@xxxxxxxxx <mailto:olivier.nouguier@xxxxxxxxx>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>>>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>
        <mailto:olivier.nouguier@xxxxxxxxx
        <mailto:olivier.nouguier@xxxxxxxxx>>>>> wrote:

                            Just to load file from the dependency (if
        the file
                is in a
                            transitive dep).


                            On Tue, Apr 19, 2011 at 12:31 AM, Igor Fedorenko
        <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>>>> wrote:

                                Out of curiosity, why do you need a
        classloader to
                        configure code
                                formatter from an xml file?

                                --
                                Regards,
                                Igor


                                On 11-04-18 06:23 PM, olivier nouguier
        wrote:

                                    Hi all,
                                       In the same vein, I like to be
        able to
                set some other
                                    settings during
                                    a project import.
                                       To reproduce the

                  org.apache.maven.plugins:maven-eclipse-plugins mojo
                                    behaviour (eclipse:eclipse).

                                       For example the formatter
        configuration.
                                       AFAIU this settings is stored in
                                    .settings/org.eclipse.jdt.core.prefs
                                    and can be exported/imported as xml
        file.
                                       My idea is to provide a new MOJO
        like this:
        <plugin>
        <groupId>org.eclipse.maven.plugins</groupId>
        <artifactId>maven-eclipse-plugin</artifactId>
        <version>1.0.0</version>
        <configuration>
        <formatter>my-formatter-config.xml</formatter>
        </configuration>
        <dependencies>
        <dependency>
        <groupId>my.corporate.namespace</groupId>
        <artifactId>my-corporate-config</artifactId>
        <version>1.0.0</version>
        </dependency>
        </dependencies>
        </plugin>

                                    Then provide a configurator that
        will inject
                this
                        formatter
                                    configuration in .settings.

                                    Remarks ?

                                    Is there some helper to build
        classloader
                from m2e
                                    dependencies ?

                                    Thx.
                                    Olivier.



                                    --
        "Computers are useless. They can only give you answers."
                                    - Pablo Picasso -


    _______________________________________________
    m2e-dev mailing list
    m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
    https://dev.eclipse.org/mailman/listinfo/m2e-dev




--
"Computers are useless. They can only give you answers."
- Pablo Picasso -



_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev


Back to the top