[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [henshin-dev] Henshin Editor
|
Hi,
I solved the bug by applying the attached diff.
Regards,
Johannes
Am Donnerstag, den 14.04.2011, 12:30 +0200 schrieb Enrico Biermann:
> Hello Johannes,
>
> yes, this looks like a bug and I will look into it. As for further bug
> reports, please submit them to https://bugs.eclipse.org/bugs (Product:
> EMFTHenshin)
>
> Regards,
> Enrico
>
> On 14.04.2011 09:57, Johannes Tietje wrote:
> > Hello,
> >
> > I uploaded my whole project [1], because it has to be run in a new
> > Eclipse instance to correctly recognize the model URIs used in the
> > rules.
> >
> > Besides the "model opening" problem another problem occured when
> > processing a specific file with my rule set: I have one sequential unit
> > which fails to "undo" if one of the rule prerequisites is not met and
> > crashes with a NullPointerException and the following stacktrace:
> >
> > Exception in thread "main" java.lang.NullPointerException
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.undo(UnitApplication.java:121)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.executeSequentialUnit(UnitApplication.java:239)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.execute(UnitApplication.java:101)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.executeCountedUnit(UnitApplication.java:308)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.execute(UnitApplication.java:107)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.executeSequentialUnit(UnitApplication.java:235)
> > at
> > org.eclipse.emf.henshin.interpreter.UnitApplication.execute(UnitApplication.java:101)
> >
> > So, does this look like a bug to you?
> >
> > Regards,
> > Johannes
> >
> > [1] http://homepages.fh-giessen.de/~jftt68/henshin/TCPStateExtract.zip
> > (2.8 MB)
> >
> > Am Donnerstag, den 14.04.2011, 07:53 +0200 schrieb Enrico Biermann:
> >> Hello Johannes,
> >>
> >> the default (empty) model is displayed when there was an error opening
> >> your .henshin file.
> >> The only cause I can think of is that Muvitor wasn't updated which
> >> should have happened automatically because of the editor's dependency on
> >> the newer version 0.9.1.
> >>
> >> All my tests on local examples worked. Could you sent me your ecore and
> >> henshin files so I can determine why it doesn't work with the updated
> >> editor?
> >>
> >> Regards,
> >> Enrico
> >>
> >> On 13.04.2011 23:49, Johannes Tietje wrote:
> >>> Hello Enrico,
> >>>
> >>> I updated my editor from the update site but it seems the editor can't
> >>> print my rule file properly---have any specifics of rule layouting
> >>> fundamentally changed? The only thing visible (besides no imported
> >>> packages or transformation units) is a transformation system named
> >>> "default", although "my" transformation system in that rule file is
> >>> named "transformation system".
> >>>
> >>> I try to reset the editor to the old version.
> >>>
> >>> Regards,
> >>> Johannes
> >>>
> >>>
> >>> Am Mittwoch, den 13.04.2011, 18:58 +0200 schrieb Enrico Biermann:
> >>>> Hello Johannes,
> >>>>
> >>>> thanks for the clarification. I assumed the bug you mentioned was for
> >>>> the GMF-based editor not the GEF-based one.
> >>>> Anyway, it should be fixed in editor version 0.8.3 available via the
> >>>> update site (http://tfs.cs.tu-berlin.de/software/)
> >>>>
> >>>> Regards,
> >>>> Enrico
> >>>>
> >>>> On 13.04.2011 17:55, Johannes Tietje wrote:
> >>>>> Hi Enrico,
> >>>>>
> >>>>> I have a bug to file for the graphical editor, as I explained in another
> >>>>> mail, because when I have a transformation unit containing two rules,
> >>>>> where the unit and the rules have one common parameter,
> >>>>>
> >>>>> transformation unit "u1"
> >>>>> -> parameter "a"
> >>>>>
> >>>>> -> rule "b"
> >>>>> -> parameter "b.a"
> >>>>> -> rule "c"
> >>>>> -> parameter "c.a"
> >>>>>
> >>>>> I can only graphically connect one rule parameter to the parameter of
> >>>>> the surrounding unit---if I try to connect the second rule parameter to
> >>>>> the parameter of the unit, the first connection gets deleted. This only
> >>>>> happens, if I want the rule parameters to be "output" parameters. (Where
> >>>>> the edge leads from the rule to the unit.)
> >>>>>
> >>>>> Greetings,
> >>>>> Johannes
> >>>>>
> >>>>> Am Dienstag, den 12.04.2011, 15:58 +0200 schrieb Enrico Biermann:
> >>>>>> Hello Amalia,
> >>>>>>
> >>>>>> the editor which was used in the paper is not the official GMF-based
> >>>>>> graphical editor but a GEF-based one.
> >>>>>>
> >>>>>> You can use the following update site to download this editor
> >>>>>> (requires existing Henshin installation):
> >>>>>>
> >>>>>> http://tfs.cs.tu-berlin.de/software/
> >>>>>>
> >>>>>> You need the two features "Muvitor" and "Henshin Editor". After
> >>>>>> installation you should be able to choose either the tree-based editor
> >>>>>> or the GEF-based graphical editor when opening *.henshin files. If you
> >>>>>> have problems with the update site or the editor let us know.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Enrico
> >>>>>>
> >>>>>> On 12.04.2011 14:37, Amalia Sanusi wrote:
> >>>>>>> Hello,
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> I am currently starting to work on Henshin. But the problem is that,
> >>>>>>> I don’t have the Henshin Editor shown in this paper:
> >>>>>>> http://journal.ub.tu-berlin.de/index.php/eceasst/article/viewFile/528/530. There’s only a palette with Rule, Edge, Attribute, and the package. I tried to open the perspective but Henshin is not there.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> The version that I used is the most recent one (0.7.0). Am I missing
> >>>>>>> something here?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> ---
> >>>>>>>
> >>>>>>> Kind regards,
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Amalia Sanusi
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> henshin-dev mailing list
> >>>>>>> henshin-dev@xxxxxxxxxxx
> >>>>>>> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >>>>>> _______________________________________________
> >>>>>> henshin-dev mailing list
> >>>>>> henshin-dev@xxxxxxxxxxx
> >>>>>> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >>>>> _______________________________________________
> >>>>> henshin-dev mailing list
> >>>>> henshin-dev@xxxxxxxxxxx
> >>>>> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >>>> _______________________________________________
> >>>> henshin-dev mailing list
> >>>> henshin-dev@xxxxxxxxxxx
> >>>> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >>> _______________________________________________
> >>> henshin-dev mailing list
> >>> henshin-dev@xxxxxxxxxxx
> >>> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >> _______________________________________________
> >> henshin-dev mailing list
> >> henshin-dev@xxxxxxxxxxx
> >> https://dev.eclipse.org/mailman/listinfo/henshin-dev
> >
> > _______________________________________________
> > henshin-dev mailing list
> > henshin-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/henshin-dev
> _______________________________________________
> henshin-dev mailing list
> henshin-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/henshin-dev
Index: src/org/eclipse/emf/henshin/interpreter/UnitApplication.java
===================================================================
--- src/org/eclipse/emf/henshin/interpreter/UnitApplication.java (Revision 981)
+++ src/org/eclipse/emf/henshin/interpreter/UnitApplication.java (Arbeitskopie)
@@ -87,6 +87,7 @@
this.oldParameterValues = new HashMap<Parameter, Object>(parameterValues);
this.appliedRules = new Stack<RuleApplication>();
+ this.undoneRules = new Stack<RuleApplication>();
}
public boolean execute() {
