Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #311590 +++ In 2012 we removed the update manager API. Two plug-ins remained in master because they were still used in tests and by PDE. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=311590#c8 org.eclipse.update.configurator org.eclipse.update.core I suggest we finish the removal process in 4.8.
Karsten, would you be so kind to land a hand here? What I just did is git submodule foreach 'git grep update.core; return 0;'|wc -l in eclipse.platform.releng.aggregator repo and this gives me 337 entries. It would be nice if we go a fast quick removal round to reduce this references so we are a bit more sure when we remove update.core.
New Gerrit change created: https://git.eclipse.org/r/111555
Here are just *some* more places where update.core is referenced: org.eclipse.pde.build/feature - feature.xml org.eclipse.sdk.tests (feature) - feature.xml org.eclipse.ua.tests/data/help/dynamic - toc.xml (5 matches) and org.eclipse.update.configurator is referenced in many files.
(In reply to Dani Megert from comment #3) > Here are just *some* more places where update.core is referenced: > > org.eclipse.pde.build/feature - feature.xml not anymore in master > org.eclipse.sdk.tests (feature) - feature.xml patch is waiting gerrit verification > org.eclipse.ua.tests/data/help/dynamic - toc.xml (5 matches) to be checked > > and org.eclipse.update.configurator is referenced in many files. update.configurator is gonna be take 2. Concentrating on update.core removal for now as it's not in our install even while update.configurator is still bringed by smth.
Gerrit change https://git.eclipse.org/r/111555 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=b253214f729787ad2430cc7df1c8ca23768853d2
New Gerrit change created: https://git.eclipse.org/r/111722
Gerrit change https://git.eclipse.org/r/111722 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=87e20cf1696eb7a5c155655b34abbac2c8382f8f
New Gerrit change created: https://git.eclipse.org/r/111794
I don't see anything regarding this removal in /org.eclipse.platform.doc.isv/porting/removals.html Maybe it was there once, but now it is missing. This needs to be added. What's the bug report that requested to mark this API for deletion?
(In reply to Dani Megert from comment #9) > What's the bug report that requested to mark this API for deletion? See Depends on bugs. I think the root bug is 311590. Note that Bug 311590 was before the new API removal process.
(In reply to Lars Vogel from comment #10) > (In reply to Dani Megert from comment #9) > > > What's the bug report that requested to mark this API for deletion? > > See Depends on bugs. I think the root bug is 311590. Note that Bug 311590 > was before the new API removal process. Thanks! We still have to mention the actual removal in the doc.
(In reply to Dani Megert from comment #11) > Thanks! We still have to mention the actual removal in the doc. You suggest adding a "Removed APIs in the Eclipse 4.2. release" entry?
(In reply to Lars Vogel from comment #12) > (In reply to Dani Megert from comment #11) > > Thanks! We still have to mention the actual removal in the doc. > > You suggest adding a "Removed APIs in the Eclipse 4.2. release" entry? No. Since we already started to delete the stuff you can add Removed APIs in the Photon (4.8) release: It doesn't make sense to list it under "planned". Then reference/mention the original removal and mention what left-overs we now deleted.
New Gerrit change created: https://git.eclipse.org/r/112061
Gerrit change https://git.eclipse.org/r/112061 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=6a26c6b578949de78a8b980801249380ca23017a
Unsetting target milestone as pde changes will take more time.
git grep -l update.core shows references to xml files. See below for the details. I don't see information how these files are used, so I create a Gerrit to remove the entries and hope that Alex can provide feedback on the change. eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/workbenchTest/saveStandards/testInputcontent.xml eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/workbenchTest/saveStandards/testOutputcontent.xml eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/workbenchTest/testInputcontent.xml eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/workbenchTest/testOutputcontent.xml
(In reply to Lars Vogel from comment #17) > git grep -l update.core shows references to xml files. See below for the > details. > > I don't see information how these files are used, so I create a Gerrit to > remove the entries and hope that Alex can provide feedback on the change. > > eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/ > workbenchTest/saveStandards/testInputcontent.xml > eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/ > workbenchTest/saveStandards/testOutputcontent.xml > eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/ > workbenchTest/testInputcontent.xml > eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/ > workbenchTest/testOutputcontent.xml This is beyond me :). Maybe Sravan knows what this workbenchTest folder is for but I don't hence I haven't touched it.
New Gerrit change created: https://git.eclipse.org/r/115105
Gerrit change https://git.eclipse.org/r/115105 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=68ff1293015c5ba6fda163abc5e810ac0c5d82b1
git grep -l update.core shows now reference for update.core anymore. I suggest we close this bug and open a new one for the final removal of update.configurator.
Gerrit change https://git.eclipse.org/r/111794 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d77a2d336461e31358a07fd62be57a8e66f77eec
*** Bug 515095 has been marked as a duplicate of this bug. ***
