Bug 367924 - PDE Build depends on org.eclipse.update* plugins
Summary: PDE Build depends on org.eclipse.update* plugins
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M2   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 311590 366701 518351
  Show dependency tree
 
Reported: 2012-01-05 04:49 EST by Krzysztof Daniel CLA
Modified: 2018-01-09 09:45 EST (History)
8 users (show)

See Also:
Vikas.Chandra: review+

Attachments
Fix that removes dependency to core.update plugins (and support for old installation manager). (4.62 KB, patch)
2012-01-05 05:17 EST, Krzysztof Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2012-01-05 04:49:40 EST 
Removing them after Juno (bug 311590) will break PDE Build.
Comment 1 Krzysztof Daniel CLA 2012-01-05 05:17:46 EST 
Created attachment 209061 [details]
Fix that removes dependency to core.update plugins (and support for old installation manager).
Comment 2 John Arthorne CLA 2012-01-09 17:06:04 EST 
Note that org.eclipse.update.configurator is not going to be removed in bug 311590. Because it is re-exported by org.eclipse.core.runtime we could not remove that without breaking binary compatibility at the bundle level. However this change sounds reasonable to me. DJ, I know you had looked at removing these dependencies on platform.xml but not sure if you saw this one.
Comment 3 DJ Houghton CLA 2012-01-10 10:41:46 EST 
If we remove these references aren't we going to be missing information? If the user has multiple sites in the platform.xml file we won't find their features. Do we need to replace this code with calls to the profile to get a list of the features which are installed?
Comment 4 Dani Megert CLA 2017-06-16 04:31:46 EDT 
Lars, you've set the milestone to M1. Do you plan to work on this?
Comment 5 Lars Vogel CLA 2017-06-16 04:37:23 EDT 
(In reply to Dani Megert from comment #4)
> Lars, you've set the milestone to M1. Do you plan to work on this?

Jupp
Comment 6 Eclipse Genie CLA 2017-06-16 04:44:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/99444
Comment 7 Vikas Chandra CLA 2017-07-28 05:49:39 EDT 
Lars, any update on this one?
Comment 8 Lars Vogel CLA 2017-07-28 06:08:27 EDT 
(In reply to Vikas Chandra from comment #7)
> Lars, any update on this one?

The Gerrit awaits your feedback, see my request for feedback in the review
Comment 9 Vikas Chandra CLA 2017-07-30 04:07:09 EDT 
Moving for early M2
Comment 11 Alexander Kurtakov CLA 2017-08-15 05:08:26 EDT 
Pushed to master.
Comment 12 Vikas Chandra CLA 2017-09-14 08:37:42 EDT 
Alex/Lars, can you verify this one?
Comment 13 Eclipse Genie CLA 2017-11-14 07:11:27 EST 
New Gerrit change created: https://git.eclipse.org/r/111527