Comment 1 Ed Merks 2018-12-04 02:22:09 EST

Note that there uses for managing the platform.xml hidden away in org.eclipse.equinox.internal.p2.update.Configuration.  And that's uses in places like org.eclipse.equinox.internal.p2.reconciler.dropins.Activator.watchConfiguration()
which I believe from the name suggest that this is how the dropins folder is currently supported.  I.e., here one can drop features and bundles and have them automatically be "installed"...

So it's not clear how this would continue to work if the configurator is completely removed.

Comment 2 Alexander Kurtakov 2019-11-14 05:36:59 EST

Remove target milestone.

Comment 3 Alexander Fedorov 2019-11-15 03:01:37 EST

(In reply to Alexander Kurtakov from comment #2)
> Remove target milestone.

This bundle also contains an IBundleGroup implementation that involves feature.xml parsing. What is the expected new home for this functionality?

All mentioned is required for About dialog

Comment 4 Alexander Kurtakov 2019-11-15 03:04:57 EST

(In reply to Alexander Fedorov from comment #3)
> (In reply to Alexander Kurtakov from comment #2)
> > Remove target milestone.
> 
> This bundle also contains an IBundleGroup implementation that involves
> feature.xml parsing. What is the expected new home for this functionality?
> 
> All mentioned is required for About dialog

IMHO such API should be in p2 if it doesn't already contain such.

Comment 5 Julian Honnen 2020-06-30 02:53:42 EDT

*** Bug 564760 has been marked as a duplicate of this bug. ***

Comment 6 Lars Vogel 2020-07-01 12:42:07 EDT

This removal should be covered by Bug 311590, but of course the removal should not break p2.

Comment 7 Lars Vogel 2020-07-01 12:43:00 EDT

Btw. update.configurator is in my top ten of long running activators as reported by OSGi tracing.

286 org.eclipse.jdt.ui_3.21.200.v20200626-1045
145 org.eclipse.jdt.core_3.23.0.v20200630-0749
86 org.eclipse.core.resources_3.13.800.v20200613-0540
71 org.eclipse.emf.common_2.19.0.v20200324-0932
64 org.eclipse.team.core_3.8.1100.v20200607-0846
64 org.eclipse.equinox.simpleconfigurator_1.3.500.v20200211-1505
62 org.eclipse.osgi_3.16.0.v20200615-2047
61 org.eclipse.update.configurator_3.4.600.v20200422-1910

Comment 8 Alex Blewitt 2020-07-15 09:21:24 EDT

(In reply to Alexander Kurtakov from comment #4)
> (In reply to Alexander Fedorov from comment #3)
> > (In reply to Alexander Kurtakov from comment #2)
> > > Remove target milestone.
> > 
> > This bundle also contains an IBundleGroup implementation that involves
> > feature.xml parsing. What is the expected new home for this functionality?
> > 
> > All mentioned is required for About dialog
> 
> IMHO such API should be in p2 if it doesn't already contain such.

Raised bug 565239 to track this specific issue.

Comment 9 Eclipse Genie 2020-07-19 11:28:13 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/166483

Comment 10 Eclipse Genie 2020-07-19 11:37:27 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/166483 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=378afc9575dc2f45849f9327d5143c4a1af00607

Comment 11 Eclipse Genie 2020-07-20 06:41:49 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.releng/+/166511

Comment 12 Eclipse Genie 2020-07-20 06:42:12 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/166512

Comment 13 Eclipse Genie 2020-07-20 10:08:38 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/166512 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=66b2b162d143c1451cfeeeb36be7fc5418ea6d8a

Comment 14 Eclipse Genie 2020-07-20 10:15:15 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/165659

Comment 15 Eclipse Genie 2020-07-20 10:15:59 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/165659 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=9dd4bcad550f2089da3c923b8fa9b1506ceadf66