Community
Participate
Working Groups
The IBundleGroupProvider is used by org.eclipse.core.runtime, but it is currently provided by the org.eclipse.update.configurator bundle: {org.eclipse.core.runtime.IBundleGroupProvider}={service.id=140, service.bundleid=258, service.scope=bundle, component.name=org.eclipse.update.configurator.bundlegroup, component.id=57} "Registered by bundle:" org.eclipse.update.configurator_3.4.600.v20200422-1910 [258] "Bundles using service" org.eclipse.core.runtime_3.19.0.v20200626-1402 [54] In order to remove this fully from the system, we will need to move the default implementation of this provider to a different location.
Both of these bundles don't live in p2. It sounds like moving to core.runtime makes most sense to me.
OK. I get it now. Sorry for the confusion I proposed one thing and then another. So the new api in p2 should be about parsing of feature.xml files (according to the other bug)?
So the provider of the IBundleGroupProvider is currently a declarative service hosted in org.eclipse.update.configurator bundle, which we're trying to get rid of (bug 564850). However, various services (including org.eclipse.core.runtime) require there to be a service for this bundle. So we need a new home for ThingThatImplementsIBundleGroupProvider, and the logical place for that is (probably) somewhere in P2, which will parse feature.xml files and provide that interface. To be clear, the org.eclipse.core.runtime.IBundleGroupProvider interface is almost certainly OK where it is (and would be challenging to change). But what it amounts to is a move/refactoring of org.eclipse.update.configurator/src/org/eclipse/update/internal/configurator/BundleGroupComponent.java to somewhere more P2 specific.
I see. Thanks for the clarification and sorry for the noise I created.
Alex, can this be done for M3? If not, please reset target.
I did a few cleanups in this plug-ini but unfortunately referred to the wrong bug. Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform/+/167878 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=ac8c8d439179d4d7d31da56c6be502ce77a22bfe [tag] [reply] [−]Comment 14Eclipse Genie CLA Friend 2020-09-07 04:28:45 EDT Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform/+/167880 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=6bd869c527415839e37be1be7165240c04a28ffe [tag] [reply] [−]Comment 15Eclipse Genie CLA Friend 2020-09-07 12:24:29 EDT Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform/+/167879 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=1d2cbe26044da25e7d0197b8096f780cbb712d40 I hope these cleanups will make the migration easier.
Alex, do you plan to work on this?
It still needs to be done, yes, but I've been focussing on other things for the time being. If someone else wants to take this over, I'm happy to release it :)
