Bug 525525 - Remove dep on org.eclipse.update.core
Summary: Remove dep on org.eclipse.update.core
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: wst.server CLA
QA Contact: Elson Yuen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 518351
  Show dependency tree
 
Reported: 2017-10-03 18:36 EDT by Mat Booth CLA
Modified: 2018-01-17 10:08 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mat Booth CLA 2017-10-03 18:36:50 EDT 
Bundle org.eclipse.update.core was deprecated and removed from the release train releases since Eclipse 4.2:

http://www.eclipse.org/eclipse/development/porting/4.2/incompatibilities.html#update-manager

However, servertools still seems to have an optional dep on this bundle that should be removed. It seems to be sufficient to simply remove the "require-bundle" dep.
Comment 1 Eclipse Genie CLA 2017-10-03 18:43:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/106175
Comment 2 Nick Boldt CLA 2017-10-04 09:21:23 EDT 
Hey, Gorkem, can you merge this change?
Comment 3 Mat Booth CLA 2017-10-16 11:27:29 EDT 
In case it was preventing movement: When I rebased my patch this morning, the build succeeded this time :-)
Comment 4 Nick Boldt CLA 2017-12-18 20:18:24 EST 
Ping @gorkem and @elson. Can someone merge this?
Comment 5 Elson Yuen CLA 2017-12-20 16:37:45 EST 
It looks like there is no file change on that patch for some reasons. Is it ready for review?
Comment 6 Mat Booth CLA 2018-01-17 10:08:58 EST 
It looks like Nick fixed this in a separate commit, see:

http://git.eclipse.org/c/servertools/webtools.servertools.git/commit/?id=6d1ee537e0567c8dc4c7991d4ec3f03832503277

Closing.