Community
Participate
Working Groups
M2: I discovered painfully that the JDT editor supports zooming; presumably by accidentally typing Ctrl+=. It was only by eventually reading the entire short cut list that I could revert it. Bug 1: Zoom is not undoable. Bug 2: Zoom is not in the Preferences. Bug 3: Zoom is not in the Edit menu Bug 4: Zoom is not in the context-specific menu Bug 5: Zoom is ignored by block selection (seemed like this was a reset)
See bug 476037 and its "Blocks" list for possible duplicates.
(In reply to Ed Willink from comment #0) > M2: I discovered painfully that the JDT editor supports zooming; presumably > by accidentally typing Ctrl+=. It was only by eventually reading the entire > short cut list that I could revert it. FYI, this was mentioned in Neon New & Noteworthy. > Bug 1: Zoom is not undoable. There is Ctrl- to undo a Ctrl+ or a Ctrl=. There's bug 482913 which is related to introducing a zoom reset. > Bug 2: Zoom is not in the Preferences. It is actually a preference, which is the font size in the Fonts preference page. > Bug 3: Zoom is not in the Edit menu Why should it be in the Edit menu? Zooming is not related to edition, it would be more an action for the Window menu. IIRC, Lars already tracked something related to a menu in another bug. > Bug 4: Zoom is not in the context-specific menu As the zoom in text editor apply to the font preference, which is global, I'm not sure it would be very relevant to show it in context-specific menu. However, I'm not sure about what I just wrote. Someone should give a try to it and see whether it seems better with or without entry in context menu. > Bug 5: Zoom is ignored by block selection (seemed like this was a reset) This is aalready tracked in bug 492202. However, no good solution was found at the moment.
Tip: To find command like Zoom-In Zoom out, use Ctrl+3 and type "Zoom". The Ctrl+ and Ctrl- shortcuts are commonly used in browsers hence some users are very familiar with their usage. I suggest to mark this bug as worksforme, as no new issue was reported, AFAICS. But I know that Ed does not like his bugs being closed ;-) hence I leave it open for the moment but don't think there is something we should do here.
(In reply to Mickael Istria from comment #2) > > Bug 2: Zoom is not in the Preferences. > > It is actually a preference, which is the font size in the Fonts preference > page. I don't think that's what Ed meant. Ed, you can disable it by unassigning the keybindings. > > Bug 3: Zoom is not in the Edit menu > > Why should it be in the Edit menu? Zooming is not related to edition, it > would be more an action for the Window menu. +1. > > Bug 4: Zoom is not in the context-specific menu > > As the zoom in text editor apply to the font preference, which is global, > I'm not sure it would be very relevant to show it in context-specific menu. +1, and the context menu is already too big. *** This bug has been marked as a duplicate of bug 492202 ***
(In reply to Lars Vogel from comment #3) > I suggest to mark this bug as worksforme, as no new issue was reported, > AFAICS. It reports two real issues for which we already have bugs, so, I decide to take the fifth one from comment 0 and mark it as duplicate of bug 492202.
(In reply to Lars Vogel from comment #3) > But I know that Ed does not like his bugs being closed ;-) hence I leave it > open for the moment but don't think there is something we should do here. Thank you. But it seems to have been CLOSED anyway. REOPENing. It is really discourteous to CLOSE before you have given the original reporter an opportunity to comment. Bottom line. The new facilities enabled my workspace to be corrupted in ways that I did not understand and which wasted my time trying to rectify. The purpose of milestones is to get early feedback. Zooming is good, but the consequences need to be mitigated. > Bug 1: Zoom is not undoable. bug 482913 certainly addresses some important points, but not my use case. My editor was magically corrupted and I had no idea why. If Zoom was an Undoable command, i.e. it appears in the history, Edit->Undo Zoom Out instantly tells me what magic happened and how to rectify it. > > Bug 2: Zoom is not in the Preferences. > > It is actually a preference, which is the font size in the Fonts preference > page. Strongly disagree. a) the preferences is the default settings (presumably the zoom reset) and should not be used to invert an out/in. b) zoom level should be a distinct preference on the Font dialog. As well as editing e.g. Consolas 9, I should see/edit Current Zoom level 200%. c) there are so many choices that I am always guessing (wrongly) at which font preference affects what. While verifying the above whinge, I notice that a full title is Java->Java Text Editor Font (set to default: Text Font). Because the standard window is too narrow I have never read beyond "set to default". The full title clarifies but is bad. "set" is ambiguously active/passive. Java->Java Text Editor Font <= Text Font (unmodified) would be clearer. > > Bug 3: Zoom is not in the Edit menu > > Why should it be in the Edit menu? ... the Window menu. I don't mind which menu it is in, just so long as it is Edit->Undo-able. > Bug 4: Zoom is not in the context-specific menu IMHO zoom could be a per-edit session preference. Different languages merit different settings. Graphical and textual zoom are certainly independent. Why can't I have two editors open on the same file with distinct zooms? Why can't I have a lower zoom level for Compare (that needs more length) than a simple Editor? It is my editor that is corrupted, so it in the context menu that I look for uncorrupting commands. > > Bug 5: Zoom is ignored by block selection (seemed like this was a reset) > > This is already tracked in bug 492202. However, no good solution was found > at the moment. Agreed moved to Bug 492202.
Zoom, like any other non-edit command will never make it into the undo story. We won't do anything here except the reset command and look into bug 492202. Please do not reopen again. *** This bug has been marked as a duplicate of bug 492202 ***
(In reply to Ed Willink from comment #6) > bug 482913 certainly addresses some important points, but not my use case. > My editor was magically corrupted and I had no idea why. If Zoom was an > Undoable command, i.e. it appears in the history, Edit->Undo Zoom Out > instantly tells me what magic happened and how to rectify it. When you close a view, you don't have a menu to undo the fact that you closed it. I believe it's the same grain, as it's manipulating workbench and not workspace, it doesn't make sense to have it in the edition history. Or maybe there's another "workbench" history that exists somewhere and we could reuse. > a) the preferences is the default settings (presumably the zoom reset) and > should not be used to invert an out/in. > b) zoom level should be a distinct preference on the Font dialog. As well > as editing e.g. Consolas 9, I should see/edit Current Zoom level 200%. That would have been an alternative way to implement things, actually a more complex one as the operation is not a zoom, but really changing font size. Maybe rather than zoom in/out, we should relabel them "Increase font size" and "Decrease Font Size" to make it clearer. %age based zoom make sense when content have a "natural" size. It fits for HTML, images or diagrams which include size data, then zoom is relative to that reference size. Text doesn't have such data, %age would be relative to nothing. > While verifying the above whinge, I notice that a full title is Java->Java > Text Editor Font (set to default: Text Font). Because the standard window is > too narrow I have never read beyond "set to default". The full title > clarifies but is bad. "set" is ambiguously active/passive. Please suggest an improvement for those labels in another bugzilla. > IMHO zoom could be a per-edit session preference. Different languages merit > different settings. Graphical and textual zoom are certainly independent. > Why can't I have two editors open on the same file with distinct zooms? Why > can't I have a lower zoom level for Compare (that needs more length) than a > simple Editor? That's IMHO over-design and over-evaluation of the requirements to think that people want a per editor instance zoom. One zooms on text when it's hard to read. If one editor is hard to read, the other ones are too so a global zoom seems to better handle the actual user-stories. Graphical editors are different: zooming can be an important part of the navigation in diagrams, so the per-editor zoom makes sense there.
Discussion about menu is bug 483645
