Bug 1 - Usability issue with external editors (1GE6IRL)
Summary: Usability issue with external editors (1GE6IRL)
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: James Moody CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 183 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 21:34 EDT by Andre Weinand CLA
Modified: 2021-06-07 10:06 EDT (History)
10 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Weinand CLA 2001-10-10 21:34:46 EDT
- Setup a project that contains a *.gif resource
	- release project to CVS
	- edit the *.gif resource with an external editor, e.g. PaintShop
	- save and close external editor
	- in Navigator open the icon resource and verify that your changes are there
	- release project
		-> nothing to release!
	- in Navigator open the icon resource and verify that your changes are still there

	Problem: because I never "Refreshed from local", the workspace hasn't changed so "Release" didn't find anything.
	However opening the resource with an external editor found the modified file on disk and showed the changes.

	The real problem occurs if "Release" actually finds something to release but you don't spot that some resources are missing.
	This is extremely error prone: one of my changes didn't made it into build 110 because of this!

NOTES:
EG (5/23/01 3:00:33 PM)
	Release should do a refresh from local before doing the release.
	Moving to VCM


KM (05/27/01 5:10:19 PM)
	Comments from JM in related email:

	Should not do this for free.  Could have a setting which made it optoinal but should nt be mandatory.  Default setting could be to have it on.
	Consider the SWT team who keep their workspaces on network drives.  This will be slow.  

	Side effects will be that a build runs when the refresh is completed unless you somehow do it in a workspace runnable and don't end the
	runnable until after the release.  This would be less than optimal as some builders may be responsible for maintaining some invariants and deriving resources which are releasable.  If you don't run the builders before releasing, the invariants will not be maintained and you will release inconsistent state.

	Summary:  Offer to "ensure local consistency" before releasing.

KM (5/31/01 1:30:35 PM)
	See also 1GEAG1A: ITPVCM:WINNT - Internal error comparing with a document
	which failed with an error.  Never got log from Tod though.
Comment 1 James Moody CLA 2001-10-19 10:32:10 EDT
*** Bug 183 has been marked as a duplicate of this bug. ***
Comment 2 James Moody CLA 2001-10-19 16:36:00 EDT
Implemented 'auto refresh' option. Default value is off.
Comment 3 DJ Houghton CLA 2001-10-23 23:39:03 EDT
PRODUCT VERSION:
	109

Comment 4 James Moody CLA 2001-10-25 10:19:43 EDT
Fixed in v206
Comment 5 Boris Bokowski CLA 2006-11-01 16:25:53 EST
I looked at this because of the link in Ian's blog (http://ianskerrett.wordpress.com/2006/11/01/looking-back-in-time-at-eclipse/).

Much to my surprise, I can still reproduce the original issue with Eclipse 3.2.1!

Why didn't we turn auto-refresh on by default?  Does the SWT team still have their workspaces on network drives?
Comment 6 John Arthorne CLA 2006-11-01 16:35:52 EST
Yes, people still use network drives. In fact, since in 3.2 we now allow projects to be backed by arbitrary file systems via EFS, there are even more scenarios where refresh will be expensive.

Note also that James was referring to an "auto-refresh" option in the sync view. This was replaced with a global auto-refresh in the 3.0 release. This is still off by default, because as mentioned before, it can be expensive.
Comment 7 Boris Bokowski CLA 2006-11-01 16:42:41 EST
(In reply to comment #6)
> This is still off by default, because as mentioned before, it can be expensive.

Couldn't we turn it on by default now that we have jobs, and a place where jobs show up in the UI? If the refresh happened in a background job that was displayed in the status line, people would have a way to find out what's going on and disable it if they don't like it.
Comment 8 John Arthorne CLA 2006-11-01 17:22:38 EST
Boris: see bug 89672
Comment 9 Philippe Ombredanne CLA 2006-11-09 14:03:39 EST
Happy birthday bug 1, you are five years old, and still kicking :-D
Comment 10 John Arthorne CLA 2006-11-09 14:17:41 EST
Closing.
Comment 11 Eclipse Genie CLA 2015-05-19 05:30:50 EDT
New Gerrit change created: https://git.eclipse.org/r/48136
Comment 13 Denis Roy CLA 2015-05-19 09:47:26 EDT
(In reply to Eclipse Genie from comment #11)
> New Gerrit change created: https://git.eclipse.org/r/48136


I will fix her.
Comment 14 Eclipse Genie CLA 2017-10-10 12:12:15 EDT
New Gerrit change created: https://git.eclipse.org/r/106523
Comment 16 Eclipse Genie CLA 2021-06-04 11:00:45 EDT
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus-sysml16/+/181461
Comment 17 Eclipse Genie CLA 2021-06-07 10:06:43 EDT
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus-sysml16/+/181519