Comment 1 Dani Megert 2015-12-08 04:09:50 EST

Note that this would currently be a layer breaker. The commands are currently only in Platform Text not Platform UI layer.

Comment 2 Dani Megert 2015-12-09 05:44:37 EST

I've removed 84776, 469918, 482913 from the blocks section, since adding a menu does not really block fixing the other bugs.

Comment 3 Eclipse Genie 2016-01-13 09:48:02 EST

New Gerrit change created: https://git.eclipse.org/r/64263

Comment 4 Eclipse Genie 2016-01-13 10:13:16 EST

New Gerrit change created: https://git.eclipse.org/r/64274

Comment 5 Lars Vogel 2016-01-25 09:54:28 EST

*** Bug 486421 has been marked as a duplicate of this bug. ***

Comment 6 Lars Vogel 2016-01-25 09:55:17 EST

Patrik, feel free to take this one.

Comment 7 Patrik Suzzi 2016-02-04 17:43:15 EST

I plan to resolve by adding the items to the bundles/org.eclipse.ui.ide/plugin.xml, 
inside the window > appearance - menu:window?after=org.eclipse.ui.editors as you see below: 

   <extension
         point="org.eclipse.ui.menus">
         <menuContribution
            locationURI="menu:window?after=org.eclipse.ui.editors">
            <!-- .. other item --> 
            <command
                  commandId="org.eclipse.ui.edit.text.zoomIn"
                  icon="icons/full/etool16/zoomIn.gif"
                  id="org.eclipse.ui.appearance.zoomIn"
                  label="%menu.window.appearance.increase.font.size"
                  style="push">
            </command>
            <command
                  commandId="org.eclipse.ui.edit.text.zoomOut"
                  icon="icons/full/etool16/zoomOut.gif"
                  id="org.eclipse.ui.appearance.zoomOut"
                  label="%menu.window.appearance.decrease.font.size"
                  style="push">
            </command>

            <!-- .. etc. --> 

Can this be a layer breaker ?
If so, what is the suggested approach to fix this?

Comment 8 Eclipse Genie 2016-02-04 18:30:37 EST

New Gerrit change created: https://git.eclipse.org/r/65956

Comment 9 Mickael Istria 2016-02-05 01:28:55 EST

I'm wondering whether this wouldn't become confusing to general zoom in/out icons not working for diagram editors? It seems like to avoid confusion, this change should wait for bug 469918 to be resolved.

Comment 10 Dani Megert 2016-02-05 03:25:11 EST

(In reply to Mickael Istria from comment #9)
> I'm wondering whether this wouldn't become confusing to general zoom in/out
> icons not working for diagram editors? It seems like to avoid confusion,
> this change should wait for bug 469918 to be resolved.

+1. The menu is not so important. We can wait until we have a second non-textual editor supporting it and then see how we best add the menu.

Comment 11 Mickael Istria 2019-06-14 17:15:59 EDT

Window > Editor already has Zoom In and Zoom Out menus.