Bug 5 - ISharingManager sharing API inconsistent (1GAUL8H)
Summary: ISharingManager sharing API inconsistent (1GAUL8H)
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 21:34 EDT by John Arthorne CLA
Modified: 2008-08-15 08:04 EDT (History)
0 users

See Also:


Attachments
mylyn/context/zip (19.51 KB, application/octet-stream)
2008-08-15 08:04 EDT, Tobias Oberlies CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2001-10-10 21:34:50 EDT
For getting/setting the managed state of a resource, the methods are:

isManaged(resource) and
manage(resource)

for getting/setting the ignore state, the methods are:

getIgnored(resource)
setIgnored(resource)

These should be made more consistent.  I suggest renaming ignore methods:

isIgnored(resource) and
ignore(resource).

I think it's good practice to not use "get" and "set" in method names unless it's really
just a field accessor.

NOTES:
Comment 1 Jean-Michel Lemieux CLA 2001-10-12 11:30:46 EDT
Is already addressed in 2.0 API. Not changing in 1.0.
Comment 2 Tobias Oberlies CLA 2008-08-15 08:04:36 EDT
Created attachment 110086 [details]
mylyn/context/zip