Community
Participate
Working Groups
I know SWT tries to use native widgets everywhere, but I think Scrollbars deserve an exception to be implemented in java so that styling can happen. Every other UI toolkit does it and all the other major IDEs already style Scrollbars to look well on dark themes (i.e.: Visual Studio, Intellij), otherwise things don't look as nice... especially on Windows.
Created attachment 240861 [details] Snapshot showing how a dark theme looks on windows Just attached a snapshot showing a dark theme on windows. Personally, by looking at it, it seems that the most important thing are the scrollbars and not the actual code...
Created attachment 245302 [details] Win 7 and Dark theme This is how dark theme looks on Win 7 64 bit. Not quite dark and quite distracting.
Created attachment 245303 [details] icons in the tree are not reall visible Expand icons in the tree are not really visible although on hover they have nice purple effect. Most of the images used look like they don't have proper alpha channel but like they are plain GIFs just blended with white background.
Created attachment 254547 [details] scrollbars 4.5rc3 This is still happening on 4.5RC3, the darktheme doesnt dark scrollbars on Windows 7.
As a note, this is currently expected (and non-trivial to fix as SWT doesn't give the support as it focuses more on wrapping what the system has to offer -- and windows itself provides no such functionality). There are workarounds to make it work 'emulating' a scrollbar, which is actually what LiClipse: http://www.liclipse.com/ does for the editors, but I don't think it's feasible to apply that to the Eclipse platform as it's a bit too hackish -- although the final result is definitely good ;)
I suppose that unless another renderers are used like based on JavaFX -efxclipse project- https://wiki.eclipse.org/Efxclipse/SWTonFX Of course I think that project is not yet mature enough. In the meantime cannot see a clean 'good' solution to have a complete dark theme
just aclare, As mature enough I meant the SWTonJavaFX but not really sure about its current state anyways
New Gerrit change created: https://git.eclipse.org/r/68531
Created attachment 260341 [details] Themed Scrollbars with https://git.eclipse.org/r/68531 applied (only applicable for StyledText elements for now)
Created attachment 260673 [details] Screenshot If I put the scrollbar relatively big, it changes it size. This should get fixed.
Many thanks Fabio, looks really great. I wait for Gerrit to build the last (minor) adjustments I did and then I merge it. The issue found in comment 10 can be fixed via Bug 490927. I will ask for more testing and depending on the outcome we can leave it activated for Windows or disable it. Can you prepare a N&N entry for ssh://youruser@git.eclipse.org:29418/www.eclipse.org/eclipse/news.git ?
(In reply to Lars Vogel from comment #10) > Created attachment 260673 [details] > Screenshot > > If I put the scrollbar relatively big, it changes it size. This should get > fixed. Humm, there are actually 2 settings for the width (one for when the mouse is not close to it and another when the mouse is close to it)... have you changed both in this case? i.e.: "swt-scrollbar-width" and "swt-scrollbar-mouse-near-scroll-width" should have the same value if you don't want that behavior.
Just to complement, I left the values different on purpose (i.e.: it should be a feature that when the mouse is far from the scrollbar the scrollbar is tiny). Now, if that's not the case and you did not change the mouse position and it started flicking or if both values were the same, I'll take a look at it (or I can just change that default value in the .css if you think it should always have the same value).
Gerrit change https://git.eclipse.org/r/68531 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=742d2e990765d5bbf9be61ff3f047105f8102bd3
(In reply to Fabio Zadrozny from comment #12) > Humm, there are actually 2 settings for the width (one for when the mouse is > not close to it and another when the mouse is close to it)... have you > changed both in this case? No I didn't. Please comment on Bug 490927 and mark it as invalid.
Fabio, is this bug and the FEEP for StyledText only? If not, please reopen so that you can use it for finish styling for the other elements, like table and trees.
Ok, marked it closed/invalid. Also, as you requested, I'll also prepare a N&N entry for: ssh://youruser@git.eclipse.org:29418/www.eclipse.org/eclipse/news.git (although I won't be able to do it today). Related to the FEEP, yes, it was agreed it would be for the StyledText only (changed the title to reflect that)... a new bug should be opened for Table/Trees (although I think this will be only feasible for 4.7 (I already have some ideas, but it would need changes in APIs and should be done earlier in the process -- M7 is already too late for that).
An unrelated question: when you created 490927 it was created as a clone, so, I wanted to do the same to clone this one but change the title for Tree/Table, but when I click the 'Clone this Bug' at the bottom in my case it takes me to an empty bug... is this expected or do I need to be a commiter in the project to properly clone a bug?
(In reply to Eclipse Genie from comment #14) > Gerrit change https://git.eclipse.org/r/68531 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=742d2e990765d5bbf9be61ff3f047105f8102bd3 > This caused a compile warning in the official build: http://download.eclipse.org/eclipse/downloads/drops4/N20160401-2000/compilelogs/plugins/org.eclipse.e4.ui.tests.css.swt_0.10.0.N20160401-2000/@dot.html Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8c9e62edbaa5320dda73b168a7b3074b2d20e507
This does not work well on Windows: Bug 490949: Themed StyledText scroll bar is missing context menu Bug 490950: Themed StyledText scroll bar is missing scroll arrows Bug 490951: Overview ruler inverted when using themed StyledText scroll bar
To have special scroll bars just for text looks odd. This surfaces especially in the Compare editor which now shows a mix of scroll bars.
(In reply to Dani Megert from comment #21) > To have special scroll bars just for text looks odd. This surfaces > especially in the Compare editor which now shows a mix of scroll bars. The long term goal is to have styled scrollbars everywhere.
Found another problem: Bug 490980: Auto-scroll (un-) lock in Console does not work with themed StyledText scroll bar
Well, the long term goal is clear. Hopefully, this all can be fixed until code freeze.
(In reply to Rade Martinovi? from comment #24) > Well, the long term goal is clear. Hopefully, this all can be fixed until > code freeze. Then this is better moved to 4.7 where we can provide that story.
(In reply to Dani Megert from comment #25) > (In reply to Rade Martinovi? from comment #24) > > Well, the long term goal is clear. Hopefully, this all can be fixed until > > code freeze. > > Then this is better moved to 4.7 where we can provide that story. Since introduction, the dark theme is far from perfect, especially under Window Any improvement to the existing experience is helpful to our users.
Just wanted to add that this is being done under the FEEP and the final decision to have at least the StyledText for 4.6 was something which the FEEP itself ended up thinking would be already a good step forward (so, many people think this is already a worthy addition as is). Also, as Lars said, the dark theme experience (especially on Windows) hasn't been great from the start and is being improved organically at each release (and hopefully the next will improve even more), and I believe this is good step forward in that direction. I'm aware that right scrollbar styles are mixed, but I still think this makes the UI better than not having that support on the StyledText -- and if someone thinks it's too bad, there's a way to opt-out by using "-Dswt.enable.themedScrollBar=false"... and in non-windows platforms, where the current status quo is not as bad, "-Dswt.enable.themedScrollBar=true" can be used to opt-in. I'm also aware that there are things that can't be overcome with the current SWT implementation (because it has no API to really change the ScrollBar object implementation, the code has to work-around it and things such as the oddity in the compare view end up happening -- unfortunately this requires a change in the SWT API which I think is too late to be introduced at this point).
(In reply to Fabio Zadrozny from comment #17) > a new bug should be opened for Table/Trees Opened Bug 491032
(In reply to Fabio Zadrozny from comment #27) > Just wanted to add that this is being done under the FEEP and the final > decision to have at least the StyledText for 4.6 was something which the > FEEP itself ended up thinking would be already a good step forward (so, many > people think this is already a worthy addition as is). > > Also, as Lars said, the dark theme experience (especially on Windows) hasn't > been great from the start and is being improved organically at each release > (and hopefully the next will improve even more), and I believe this is good > step forward in that direction. Fair enough. I'm not using the dark theme, hence those really using it should decide whether this is better for them or not.
New Gerrit change created: https://git.eclipse.org/r/69905
Note: gerrit review for adding it to the New & Noteworthy.
Gerrit change https://git.eclipse.org/r/69905 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3ade40c61c06c0c56ed708223dc85862cc0d2ea1
Created attachment 261543 [details] some scrollbars not styled not sure if this was expected for this build but I've been testing the M7 darktheme and there still some scrollbars that are not yet styled so I just thoght to write a comment here. E.g. Project Explorer, Plugins. Problems, Target Platform State, interestingly the Console scrollbars are styled great both vertical and horizontal, of course the java editor is also perfectly styled. Definitely a nice improvement.
(In reply to Pablo Gomez from comment #33) > Created attachment 261543 [details] > some scrollbars not styled > > not sure if this was expected for this build but I've been testing the M7 > darktheme and there still some scrollbars that are not yet styled so I just > thoght to write a comment here. E.g. Project Explorer, Plugins. Problems, > Target Platform State, interestingly the Console scrollbars are styled great > both vertical and horizontal, of course the java editor is also perfectly > styled. Definitely a nice improvement. Hi Pablo, This is expected (you can see the release notes at https://www.eclipse.org/eclipse/news/4.6/M7/). The related bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=491032 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=491032#c2 has comments on why it wasn't done for 4.6M7).
i just enabeld it on macOS and the vertical scrollbar appears when the mouse comes close but disappears again before I can click it.
Created attachment 275426 [details] screen recording showing the issue on mac
(In reply to Matthias Becker from comment #35) > i just enabeld it on macOS and the vertical scrollbar appears when the mouse > comes close but disappears again before I can click it. I suggest to handle this via a new bug which depends on this one, this bug is already older and Fabio only activated it for Windows.
(In reply to Lars Vogel from comment #37) > (In reply to Matthias Becker from comment #35) > > i just enabeld it on macOS and the vertical scrollbar appears when the mouse > > comes close but disappears again before I can click it. > > I suggest to handle this via a new bug which depends on this one, this bug > is already older and Fabio only activated it for Windows. done. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=537995
Bug 444560 introduce dark scrollbars on an SWT level.
