Bug 491577 - Themed StyledText scroll bar scrolls on right mouse click (context menu)
Summary: Themed StyledText scroll bar scrolls on right mouse click (context menu)
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.6 RC2   Edit
Assignee: Fabio Zadrozny CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 430278
  Show dependency tree
 
Reported: 2016-04-13 05:35 EDT by Dani Megert CLA
Modified: 2016-05-23 06:54 EDT (History)
4 users (show)

See Also:
daniel_megert: review+
Lars.Vogel: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2016-04-13 05:35:52 EDT 
The themed StyledText scroll bar scrolls on right mouse click. This is unexpected.

Related to bug 490949.
Comment 1 Fabio Zadrozny CLA 2016-04-13 06:52:25 EDT 
Hi Dani,

Not sure about this one (I must say that decision was deliberate)... 

Right now, Eclipse on Windows does open a context menu with options such as "scroll here", but I thought that was a bit overkill, so, I decided to adopt the same behavior from Eclipse on Linux, which scrolls as if it was a left click (particularly I find that more natural).

As a note, I also took a look on other programs on windows:

* Google Chrome: Just ignores that the scroll bar was clicked and shows the regular context menu.

* Skype: Scrolls to the clicked position and then shows the regular context menu.

* Internet Explorer: uses the native behavior showing a context menu as in Eclipse on Windows.

* LibreOffice Writer: ignores the right click

So, as that feature seems to be very unreliable among different programs on Windows, I think scrolling on right click seems a reasonable approach.

So, ideally, I'd like to leave the behavior as is and mark this bug as won't fix.
Comment 2 Dani Megert CLA 2016-04-13 07:45:23 EDT 
You need to compare with Eclipse on Windows. Users are used to not scroll on right click. A theme should not change the user interactions whenever possible.
Comment 3 Lars Vogel CLA 2016-04-25 15:10:08 EDT 
Mass move to 4.6 RC1. We might push out more to 4.7.
Comment 4 Eclipse Genie CLA 2016-04-26 08:59:32 EDT 
New Gerrit change created: https://git.eclipse.org/r/71417
Comment 5 Fabio Zadrozny CLA 2016-04-26 09:02:09 EDT 
Ok, https://git.eclipse.org/r/71417 changes the behavior to do nothing on windows in this case.
Comment 6 Dani Megert CLA 2016-05-16 04:22:40 EDT 
Lars, I reviewed the code and tested it on Windows. Please also review for RC2 and verify that it does not break your platform.
Comment 7 Lars Vogel CLA 2016-05-17 11:11:35 EDT 
(In reply to Dani Megert from comment #6)
> Lars, I reviewed the code and tested it on Windows. Please also review for
> RC2 and verify that it does not break your platform.

Works fine. On Ubuntu right mouse click scrolls and this still works. This is expected as the new code is guarded by a check for Windows.
Comment 9 Patrik Suzzi CLA 2016-05-23 06:54:35 EDT 
Verified on Windows+Linux with RC2
Neon (4.6)
Build id: I20160519-1730