Bug 562112 - Retire theme scrollbar from StyledText for the Dark Theme
Summary: Retire theme scrollbar from StyledText for the Dark Theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 506767 (view as bug list)
Depends on: 430278 444560 561588
Blocks: 562375
  Show dependency tree
 
Reported: 2020-04-14 10:55 EDT by Lars Vogel CLA
Modified: 2020-04-24 06:45 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-04-14 10:55:22 EDT 
Now that we supported dark scrollbars, we should retire the software solution from Bug 430278.
Comment 1 Lars Vogel CLA 2020-04-14 10:58:13 EDT 
*** Bug 506767 has been marked as a duplicate of this bug. ***
Comment 2 Lars Vogel CLA 2020-04-14 11:05:39 EDT 
This will also IMHO improve the consistency of the Eclipse IDE L&F.
Comment 3 Eclipse Genie CLA 2020-04-14 11:11:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/160917
Comment 4 Eclipse Genie CLA 2020-04-14 11:22:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/160919
Comment 5 Pierre-Yves Bigourdan CLA 2020-04-15 02:30:40 EDT 
So, will it no longer be possible to style scroll bars? It's a nice feature to have for custom themes IMHO, even though it may no longer be relevant for the dark theme.
Comment 6 Lars Vogel CLA 2020-04-15 03:49:45 EDT 
(In reply to Pierre-Yves B. from comment #5)
> So, will it no longer be possible to style scroll bars? It's a nice feature
> to have for custom themes IMHO, even though it may no longer be relevant for
> the dark theme.

It will still be possible to use the approach for custom styling, will will just not be included in the Eclipse SDK.
Comment 7 Lars Vogel CLA 2020-04-15 03:52:20 EDT 
Fabio, what is your preferred solution? Only remove the CSS or also remove the code from https://git.eclipse.org/r/#/c/68531/?

I did not see anyone fixing the code, e.g., Bug 506767 so in case you are are also not interested in maintaining it, I would prefer to retire it.
Comment 8 Lars Vogel CLA 2020-04-15 04:00:25 EDT 
If we want to remove the implementation we basically have to revert https://git.eclipse.org/r/#/c/68531/
Comment 9 Mike Marchand CLA 2020-04-17 10:39:31 EDT 
In some ways, it's too bad that the styled scrollbar wasn't pushed further into all things scrollable.  I am happy to have the native scrollbars be dark, but I think I preferred the styled scrollbar in many ways: I love the control we have with the custom compared to native, but also I preferred the look.

Like I said, I am happy to no longer have light native scrollbars on Dark theme.  I also prefer consistency, so this is why it's a good thing to remove our use of the styled scrollbars.
Comment 11 Pierre-Yves Bigourdan CLA 2020-04-17 16:05:54 EDT 
(In reply to Mike Marchand from comment #9)
> In some ways, it's too bad that the styled scrollbar wasn't pushed further
> into all things scrollable.  I am happy to have the native scrollbars be
> dark, but I think I preferred the styled scrollbar in many ways: I love the
> control we have with the custom compared to native, but also I preferred the
> look.

Agreed. I think the "all things scrollable" bit is Bug 455526.
Comment 12 Lars Vogel CLA 2020-04-21 16:55:10 EDT 
Removal of the code will be handled via Bug 562112.
Comment 13 Lars Vogel CLA 2020-04-24 06:45:03 EDT 
Bug 444560 introduced the option for dark scrollbars in SWT