Community
Participate
Working Groups
Created attachment 237492 [details] Screenshot I'm using Luna 4.4.M3 RCP package and libgtk-3.0 version 3.4.2-0ubuntu5. I noticed when opening the MANIFEST.MF editor that some widgets now show a background. See for instance the background under the general section in screenshot. It used to be white. Not sure who's culprit: SWT or PDE...
Mickael, can you come with pure swt reproducer?
Sorry, I'm quite busy for the moment. I'll try to find time within a few days. If you don't have news soon, feel free to ping me back.
By the way, the editor relies on the form API, which is another usual suspect.
See also bug 422940, which is about visual artifacts with FormToolkit code.
I don't have much free time so please come with pure swt reproducer to ease people that would probably look at it.
I believe it can be related to bug 421834 about current SWT/GTK3 implementation making children composite inherit some stuff from parents. In this case, it could be a child inheriting the transparency settings from its parent.
Created attachment 240040 [details] A snippet to reproduce it (using Section) Here is a snippet that reproduce the bug (or maybe just a part of it). We can see that with GTK3, the child widget containing the description inherits from the color of the title, whereas it's not the case with GTK2. I tried to dig deeper, but I didn't manage to find out a better way to reproduce this.
(In reply to Mickael Istria from comment #7) > Created attachment 240040 [details] > A snippet to reproduce it (using Section) > > Here is a snippet that reproduce the bug (or maybe just a part of it). We > can see that with GTK3, the child widget containing the description inherits > from the color of the title, whereas it's not the case with GTK2. > I tried to dig deeper, but I didn't manage to find out a better way to > reproduce this. I don't see the use of Section in this file. Did you attach the right file?
Created attachment 242948 [details] Always set the background color (hack?) In Control.setBackground (Color color) If I change it to always set the color, it looks much better (if (OS.GTK3) set = true;). But it doesn't seem right to always set it.
Created attachment 242958 [details] screenshot from snippet This screenshot shows the difference of behaviour with GTK3 vs GTK2.
Created attachment 242959 [details] A snippet to reproduce it (using Section) Updated reproducer
(In reply to Marc-Andre Laperle from comment #9) > Created attachment 242948 [details] > Always set the background color (hack?) > > In Control.setBackground (Color color) > > If I change it to always set the color, it looks much better (if (OS.GTK3) > set = true;). But it doesn't seem right to always set it. Marc, this is a huge hack but I wouldn't mind having it in Luna (with TODO to fix it properly). To give some info - some widgets like GtkLabel(and others) are transparent now, so one needs to set their background. Would you please submit a patch about it?
Patch: https://git.eclipse.org/r/26375
(In reply to Mickael Istria from comment #11) > Created attachment 242959 [details] > A snippet to reproduce it (using Section) > > Updated reproducer Thanks Mickael!
(In reply to Marc-Andre Laperle from comment #13) > Patch: > https://git.eclipse.org/r/26375 Pushed the patch to master - http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2247f34f7e6717b23f83a3e524d9181bdd001eaf Lets keep the bug open to investigate a proper fix...
I can't reproduce the issue on Mars.
Eric, would you please take a look what/if anything needs work on this bug still?
(In reply to Alexander Kurtakov from comment #17) > Eric, would you please take a look what/if anything needs work on this bug > still? Yes this is still needed, unfortunately. If I remove it I get blue backgrounds in the manifest editor.
I think the cause of this bug is somewhat natural for GTK3. Certain widgets have elements that contain multiple elements. For example a GtkLabel has a GtkBox, and an SwtFixed container. These containers may not explicitly have backgrounds set. Setting a background color higher up in the widget tree might cause these containers to inherit this background. This causes some weird areas to have background colors where others don't. For example, look at the manifest editor. The blue spots are interspersed in odd places that don't seem to match up to a specific widget. My guess here is that these are overlapping containers, where the top one has no background color and the bottom one does. The top container inherits the blue color from elsewhere, and the bottom container has a white background. The portions of the top container that are not covered by the bottom container are therefore blue. Since we use SwtFixed containers in GTK3 for just about everything, setting the background color on all of them for a consistent color scheme might be necessary.
I feel it's time to close this bug. Many things have changed since it was filed and it's a big vague. Better to have dedicated bugs for any other known bug.
Closing.
