Comment 1 Mickael Istria 2013-11-21 09:47:19 EST

Making a link to bug 340067 as they may be related.

Comment 2 Alexander Kurtakov 2013-11-21 09:57:15 EST

Mickael, could you write a plain swt reproducer? This makes it really easier to understand and work on the problem compared to full IDE problem.

Comment 3 Peter Severin 2014-02-14 06:52:56 EST

I also saw this issue in Properties View while testing WireframeSketcher plugin. Text in combos and text fields was bold. I am still not sure what are the steps to reproduce it as it does not happen consistently.

Comment 4 Mickael Istria 2014-02-17 10:27:14 EST

Created attachment 240038 [details]
Snippet to reproduce the problem

It seems to be a change in font inheritance mechanism with GTK3.
By default in SWT, Font are not inherited, so any new Control uses the default font except is something else is specified. I don't know if it is specified by SWT or not, by it has always been like that.
With GTK3, the widget automatically uses font from parent, breaking the expected behavior.
See attached snippet which highlights this behaviour difference with GTK2 and GTK3.

Comment 5 Alexander Kurtakov 2014-02-17 10:45:30 EST

Mickael,
I love such bug reports - fix pushed to master http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=cc2ab6506227bedefa370f48a8e22f7d6c2048d0 .
If most bug reports where coming with such analysis and snippets there wouldn't have been that many open bugs.

Comment 6 Alexander Kurtakov 2014-02-18 13:45:31 EST

Additional commit fixing Button and Text components inheriting font.
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d418a2f5e052f6a533f94964edfe7916aabde323

Comment 7 Peter Severin 2014-03-23 02:26:20 EDT

This issue seems to be fixed for Text in 4.4M6, but it's still present for Combo.

Comment 8 Alexander Kurtakov 2014-04-01 03:29:42 EDT

Reopen as per last comment.

Comment 9 Alexander Kurtakov 2014-04-01 15:30:48 EDT

(In reply to Peter Severin from comment #7)
> This issue seems to be fixed for Text in 4.4M6, but it's still present for
> Combo.

Peter, would you please provide a snippet reproducing the Combo issue?

Comment 10 Peter Severin 2014-04-02 00:04:12 EDT

Created attachment 241493 [details]
Combo test case

Comment 11 Peter Severin 2014-04-02 00:04:40 EDT

Created attachment 241494 [details]
Combo problem screenshot

Comment 12 Peter Severin 2014-04-02 00:11:56 EDT

I added test case and a screenshot that shows the problem. While creating the test case I noticed another bug with Class File Editor which I reported here Bug 431772.

Comment 13 Alexander Kurtakov 2014-04-02 03:34:00 EDT

A good bug report with reproducer deserves a fix. Pushed to master http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0854ee343a9a2f7b225cfa849ae690c61a29f135

Comment 14 Marc-André Laperle 2014-05-10 15:32:35 EDT

Created attachment 242931 [details]
Other problematic widgets snippet

Alexander, there are other widgets that still inherit the font:
-ExpandBar
-Group
-List
-Spinner
-Table
-Tree

See attached snippet.

Comment 15 Marc-André Laperle 2014-05-10 15:34:07 EDT

Patch:
https://git.eclipse.org/r/26329

Comment 16 Marc-André Laperle 2014-05-10 16:33:28 EDT

Created attachment 242934 [details]
Other problematic widgets snippet

Actually, ToolBar is also affected (noticed because of EGit's Rebase interactive). Snippet updated and I'll update the patch too.

Comment 17 Arun Thondapu 2014-05-12 06:55:30 EDT

(In reply to Marc-Andre Laperle from comment #15)
> Patch:
> https://git.eclipse.org/r/26329

Pushed to master - http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4697a58f0a3ea1a0b8cab8c841e547bfbe9ba5a1