Bug 3979 - [CVS Decorator] show version info works incorrectly for subpackages (1GFDIEB)
Summary: [CVS Decorator] show version info works incorrectly for subpackages (1GFDIEB)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 critical with 1 vote (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 3526 3855 4040 4051 10011 13426 21263 22430 24388 25584 36222 36292 42492 45706 47584 50041 72001 74866 111044 125851 (view as bug list)
Depends on: 86493
Blocks: 32581
  Show dependency tree
 
Reported: 2001-10-10 23:04 EDT by Erich Gamma CLA
Modified: 2006-03-15 14:03 EST (History)
22 users (show)

See Also:

Attachments
Patch to add proper patch decoration once dependencies are fixed (15.56 KB, patch)
2005-08-05 14:36 EDT, Michael Valenta CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2001-10-10 23:04:02 EDT 
AK (6/15/01 7:53:56 PM)	
	create two packages in one source folder p and p.p1
	now, if you modify a file in p.p1 the > mark shows in for p as well

NOTES:
Comment 1 Martin Aeschlimann CLA 2001-10-16 11:15:51 EDT 
moved to 'active'
Comment 2 DJ Houghton CLA 2001-10-24 07:26:46 EDT 
PRODUCT VERSION:
124
Comment 3 Erich Gamma CLA 2001-11-10 17:27:32 EST 
*** Bug 3855 has been marked as a duplicate of this bug. ***
Comment 4 Erich Gamma CLA 2001-11-10 17:28:11 EST 
*** Bug 4051 has been marked as a duplicate of this bug. ***
Comment 5 Erich Gamma CLA 2001-11-10 17:47:30 EST 
*** Bug 3526 has been marked as a duplicate of this bug. ***
Comment 6 Erich Gamma CLA 2001-11-10 19:05:38 EST 
*** Bug 4040 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2002-02-27 10:24:21 EST 
The design has changed i.e. version info provided by vcm via decorator but the
problem is still here.

This is a major issue because this is confusing for the user (marking a package
to have changes while he did not change anything in there).

Leaving P2 but would even vote to become P1
Comment 8 Erich Gamma CLA 2002-05-04 13:36:08 EDT 
I agree on the importance but the issue is that the decoration is done by the 
CVSDecorator using the IResource adapter. It therefore can only know about the 
resource hierarchy. Similarly, the Java views cannot know about the CVS 
decorations. All they do is to map LabelProviderChangedEvents for IResources 
back to IJavaElements. 

One idea was to show two different dirty indicators on containers:
- "logically" dirty - the container contains dirty children
- "physically" dirty - the container is "otherwise" dirty 

To make this happen would require VCM support for hooking into the CVS 
decoration. This is unlikely to happen for 2.0 (unless Kevin disagrees).

Finally, as a weak argument - the problem only shows up when the "Compute Deep 
Outgoing change for folders" is on.

Opt to do nothing for 2.0
Comment 9 Kevin McGuire CLA 2002-05-06 12:55:41 EDT 
I would love to solve this but we have no solution for 2.0.
Comment 10 Dirk Baeumer CLA 2002-07-25 12:53:11 EDT 
Kevin, any plans to give JDT the change to influence this ?
Comment 11 Kevin McGuire CLA 2002-07-25 14:51:55 EDT 
Our choices at present are:

1. We can stop showing dirty indicators on parents.  To find out if you have 
projects with changes, you'ld need to perform a query.  This has certain 
performance gains as well since you don't have to check the dirty status for 
all elements of a project (expensive and doesn't scale as projects increase in 
size).

2. Something else which understands the logical parenting in the packages 
view.  All we have here is the problem description; we have no solution to 
propose as yet, but at least have time to think about it now.  This is the 
deluxe solution although it doesn't avoid the performance issue cited above.
Comment 12 Michael Valenta CLA 2002-08-22 16:01:15 EDT 
*** Bug 21263 has been marked as a duplicate of this bug. ***
Comment 13 Michael Valenta CLA 2002-09-06 21:12:27 EDT 
*** Bug 13426 has been marked as a duplicate of this bug. ***
Comment 14 Michael Valenta CLA 2002-09-09 14:16:47 EDT 
*** Bug 10011 has been marked as a duplicate of this bug. ***
Comment 15 Kevin McGuire CLA 2002-10-04 10:34:23 EDT 
*** Bug 24388 has been marked as a duplicate of this bug. ***
Comment 16 Kevin McGuire CLA 2002-10-04 10:34:55 EDT 
*** Bug 22430 has been marked as a duplicate of this bug. ***
Comment 17 Simon Archer CLA 2002-10-06 13:44:05 EDT 
Kevin...  In reference to your list of possibilities on 2002-07-25, how about a 
third possibility, where a task is created and added to the task view for each 
dirty resource.  This would save the user from having to search for dirty 
resources.

Granted, this might not be the best solution since the number of dirty 
resources could be large.  A number of quick-fixes could be created for dirty 
resources including rolling back to the latest in the stream or local history, 
commiting the changes, etc.
Comment 18 Kevin McGuire CLA 2002-10-07 13:52:01 EDT 
Simon, we had thought about tasks for this, although our experience with using 
them for denoting new (unshared) resources is that they don't play well (they 
are lost amoungst the errors, people don't look for them, etc).  We would 
probably require a combination of things.
Comment 19 Claude Knaus CLA 2002-11-01 04:24:02 EST 
*** Bug 25584 has been marked as a duplicate of this bug. ***
Comment 20 Kevin McGuire CLA 2003-02-05 10:23:13 EST 
I've downgraded from P2 since no action for 2.1 which we are closing on.
Comment 21 Michael Valenta CLA 2003-04-08 11:40:13 EDT 
*** Bug 36222 has been marked as a duplicate of this bug. ***
Comment 22 Jean-Michel Lemieux CLA 2003-09-04 12:06:15 EDT 
*** Bug 42492 has been marked as a duplicate of this bug. ***
Comment 23 Michael Valenta CLA 2003-10-28 21:38:25 EST 
*** Bug 45706 has been marked as a duplicate of this bug. ***
Comment 24 Jean-Michel Lemieux CLA 2003-11-26 16:59:50 EST 
*** Bug 47584 has been marked as a duplicate of this bug. ***
Comment 25 Michael Valenta CLA 2004-01-16 12:08:57 EST 
*** Bug 50041 has been marked as a duplicate of this bug. ***
Comment 26 C. Lamont Gilbert CLA 2004-01-16 16:29:31 EST 
If im not mistaken, this applies to all OS.  Also, this is fine for Hierachy
layout, but the problem is strickly with Flat layout!?

What exactly is "show version info?"  The problem I am experiencing is with the
CVS status icons.
Comment 27 Michael Valenta CLA 2004-08-16 09:10:05 EDT 
*** Bug 72001 has been marked as a duplicate of this bug. ***
Comment 28 Jean-Michel Lemieux CLA 2004-09-28 09:32:37 EDT 
*** Bug 74866 has been marked as a duplicate of this bug. ***
Comment 29 Michael Valenta CLA 2005-08-04 14:46:24 EDT 
Fix released to HEAD
Comment 30 Michael Valenta CLA 2005-08-05 14:34:11 EDT 
Had to back out of this due to bug 86493.
Comment 31 Michael Valenta CLA 2005-08-05 14:36:01 EDT 
Created attachment 25770 [details]
Patch to add proper patch decoration once dependencies are fixed
Comment 32 Michael Valenta CLA 2005-09-29 09:01:55 EDT 
*** Bug 111044 has been marked as a duplicate of this bug. ***
Comment 33 Michael Valenta CLA 2006-01-16 10:47:48 EST 
Fix released to HEAD. Packages are now decorated properly.
Comment 34 Michael Valenta CLA 2006-01-31 11:17:45 EST 
*** Bug 125851 has been marked as a duplicate of this bug. ***
Comment 35 Michael Valenta CLA 2006-03-15 14:03:38 EST 
*** Bug 36292 has been marked as a duplicate of this bug. ***