Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [iam-dev] Behavior of POM Editor on Validation

I think validation should only be informative, since the user might be interrupted and she should not be forced to enter valid data just to be able to switch to a different task.

We can do some aditional checks where it makes sense. For instance, running a java program when the workspace contains build errors displays a warning. We can do something similar when launching a maven goal if the pom contains validation error (this can be done by looking at error markers, no need to revalidate).

This would be a separate task, anyway.


On Thu, Jan 22, 2009 at 2:30 AM, Korina Cordero <kcordero@xxxxxxxxx> wrote:
I just tried saving an invalid URL and I think the validation strategy I used won't let it be saved. =)  I'll tinker with it a bit more and see what I can come up with.

Right now, I just put the validation classes in one package under org.eclipse.iam.pomeditor.components.validation.  But I can move it once we've decided where to put them.

Abel Muiño wrote:
I would let the user save whatever he wants (for example, you can save a java file even if it does not compile).

Regarding validation... all the checks that can be put in place will improve user experience, so I would check everything that we can quickly check.

BTW: It would be useful to have the validators as reusable components (maybe in maven.core, suggestions are welcome). For instance, groupId and artifactId are used in the new maven project wizard and are (currently) not validated.

On Wed, Jan 21, 2009 at 10:23 AM, Korina Cordero <kcordero@xxxxxxxxx <mailto:kcordero@xxxxxxxxx>> wrote:

   Hi,

   I'm looking into cleaning up the validation pop-ups that I
   initially put for URL text fields.  I might do some more
   validation for a few more text fields too.

   The old scenario used to show a pop up window when the URL doesn't
   start with the proper text( http://, https:// etc.), which I admit
   is not too elegant.

   Abel directed me to this site that has a more cleaner method:
   http://toedter.com/blog/?p=36
   where a little red X will be displayed beside the text field when
   the text field contains invalid input.  My next question is this:
    Once the little red x is shown, do we allow the user to save the
   changes done to the POM Editor?  Or do we force the user to enter
   valid input and only allow the user to save once everything passes
   validation?

   Another question I have is, aside from URL, are there any other
   text fields that we might need to validate?  Like email, group ID,
   artifact ID, etc.?

   thanks,
   Korina
   _______________________________________________
   iam-dev mailing list
   iam-dev@xxxxxxxxxxx <mailto:iam-dev@xxxxxxxxxxx> ------------------------------------------------------------------------


_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev
 

_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev



--
Abel Muiño - http://ramblingabout.wordpress.com/

Back to the top