Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] CDT Junit tests

I restored the assert and committed a fix.

BTW, removing an assert when a test fails scares me a bit... I suggest next time we take more more time to investigate or at least discuss when it's not Saturday morning and people like me are busy oversleeping ;)

On 11-03-12 10:54 AM, Alena Laskavaia wrote:
Ok I will remove fist part of assert to make test pass. I tried to
pass not qualified name to it - but then test would fail with
incorrect result. If you feel strongly that assert should be there
please fix the test firt

On Sat, Mar 12, 2011 at 10:45 AM, Alena Laskavaia
<elaskavaia.cdt@xxxxxxxxx>  wrote:
Thanks it helps. So it is failing before
    public void setTemplateName(IASTName name) {
        assertNotFrozen();
        assert !(name instanceof ICPPASTQualifiedName)&&  !(name
instanceof ICPPASTTemplateId);

name is ICPPASTQualifiedName

Why it not suppose to be?

On Sat, Mar 12, 2011 at 10:29 AM, James Blackburn
<jamesblackburn@xxxxxxxxx>  wrote:

On 12 March 2011 15:20, Alena Laskavaia<elaskavaia.cdt@xxxxxxxxx>  wrote:
Only one test remains failing

https://hudson.eclipse.org/hudson/job/cdt-nightly/574/testReport/org.eclipse.cdt.ui.tests.refactoring.extractlocalvariable/ExtractLocalVariableRefactoringTest/Bug_331963_Extract_local_variable_doesn_t_put_template_type_parameters_Namespace/

I tried to disable it but it does not fail on my host. Does somebody
know why it may fail or can reproduce it?
I think to make it fail you'll need to run the JUnit with -ea set on your VM
(enable asserts).  As to why it fails, I have no idea...
Cheers,
James
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top