Bug 66297 - [KeyBindings] preference page: UP/DOWN focus broken in Keybinding prefs, assignments table
Summary: [KeyBindings] preference page: UP/DOWN focus broken in Keybinding prefs, assi...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 88049 (view as bug list)
Depends on: 176235
Blocks:
  Show dependency tree
 
Reported: 2004-06-09 10:08 EDT by Randy Hudson CLA
Modified: 2007-06-20 14:19 EDT (History)
4 users (show)

See Also:


Attachments
Patch to KeysPreferencePage (2.10 KB, patch)
2004-06-18 12:17 EDT, Douglas Pollock CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2004-06-09 10:08:41 EDT
Select a keybinding which has 2 or more assignments. Tab to the assignments 
table, and try to use the UP and DOWN arrows.  The behavior is random and after 
1 or 2 presses, you cannot change the selected tableitem.

Also, the Table stops showing focus as soon as you move up or down. It should 
retain focus.
Comment 1 Douglas Pollock CLA 2004-06-09 15:34:25 EDT
Moving preference page bugs to Chris.... 
Comment 2 Tod Creasey CLA 2004-06-18 10:43:16 EDT
Moving to Doug as this is on the accessibility list.
Comment 3 Douglas Pollock CLA 2004-06-18 12:17:09 EDT
Created attachment 12494 [details]
Patch to KeysPreferencePage

This should fix the problem.  It looks like while trying to fix the fact that
the arrow button wouldn't appear in the tab stop list, I also made it so that
the table was never added to the tab stop list.  The fix is to move the tab
stop list tinkering after the creation of the table.

The symptoms that I see are an inability to tab in to and an inability to tab
out of the table.

Please try this patch, and let me know how it goes....
Comment 4 Tod Creasey CLA 2004-07-26 15:51:43 EDT
Moving to Doug as he takes care of this now
Comment 5 Douglas Pollock CLA 2004-08-09 13:30:30 EDT
Moving preference page bugs to Chris....  
Comment 6 Douglas Pollock CLA 2004-10-20 21:25:20 EDT
Taking all of Chris' [KeyBindings] bugs. 
Comment 7 Douglas Pollock CLA 2004-11-02 09:45:37 EST
I'm not sure why this patch was never applied.  Moving to M4. 
Comment 8 Douglas Pollock CLA 2004-12-13 17:55:38 EST
I'm sorry, but I won't be able to fix these for M4.  I'm moving them to the 
3.1 milestone. 
Comment 9 Randy Hudson CLA 2004-12-14 00:35:16 EST
This bug should be irrelevant once the preference page is redesigned.
Comment 10 Douglas Pollock CLA 2005-03-15 10:44:34 EST
*** Bug 88049 has been marked as a duplicate of this bug. ***
Comment 11 Steven Wasleski CLA 2005-04-12 11:03:46 EDT
We are in the process of updating the accessibility information for 3.1.  Is 
this bug going to be fixed in 3.1 or is it no longer a bug after the 
preference page redesign?
Comment 12 Douglas Pollock CLA 2005-04-12 11:37:04 EDT
The preference page re-work has been pulled for the 3.1 plan to work on performance.
Comment 13 Carolyn MacLeod CLA 2005-04-14 17:17:51 EDT
Then this bug is no longer irrelevant. It needs to be fixed because this 
particular preference page is currently not accessible.
Comment 14 Tod Creasey CLA 2005-08-08 10:11:56 EDT
Doug I just tested this with your new page and I don't this will be an issue
when you release it.

Could you verify please?
Comment 15 Frank DiPalermo CLA 2005-08-09 10:49:50 EDT
A couple of observation on the experimental page:
1. I noted that the list of commands has a window class of SysTreeView32.  
Should it not be a SysListView32?
2. If I tab past the list to the Showw All checkbox, press Spacebar to check it 
and then Shift+Tab back to the list, I do not see the focus on the list and 
nothing is highlighted.
Comment 16 Randy Hudson CLA 2005-08-09 11:13:38 EDT
What is this new experimental page??
Comment 17 Frank DiPalermo CLA 2005-08-09 11:29:32 EDT
Randy, if you download the latest Eclipse build.  Then look in the preferences, 
you will find the experimental page listed along with the old page.
Comment 18 Michael Van Meekeren CLA 2006-04-21 13:14:39 EDT
Moving Dougs bugs
Comment 19 Paul Webster CLA 2006-09-28 15:13:33 EDT
Is this still a problem in 3.3?

PW
Comment 20 Karice McIntyre CLA 2006-09-28 17:56:33 EDT
Yes, in 3.3 M2 it is still a problem (on the old Keys preference page).  Note, this bug is on the accessibility list.
Comment 21 Paul Webster CLA 2006-09-28 21:00:05 EDT
If we finally get rid of the old page in 3.3 we might be able to close this :-)

PW
Comment 22 Randy Hudson CLA 2006-09-28 22:57:56 EDT
> If we finally get rid of the old page in 3.3 we might be able to close this :-)

I really hope this bug is resolved INVALID, but only once we have something better than both of the existing tabs. Good luck...
Comment 23 Karice McIntyre CLA 2006-12-04 09:40:48 EST
Paul, what is the status/target of this bug?
Comment 24 Paul Webster CLA 2007-04-30 14:17:13 EDT
(In reply to comment #23)
> Paul, what is the status/target of this bug?

The new page will be released in 3.3M7
PW
Comment 25 Paul Webster CLA 2007-05-16 20:01:05 EDT
The new page is now available (and barring severe accident) will be the main page in 3.3

If you'd like this to remain open I'm fine with that (it's still a problem on the old page) and add a helpwanted keyword to it.

PW
Comment 26 Paul Webster CLA 2007-06-20 14:19:26 EDT
new keys preference page
PW