Community
Participate
Working Groups
Some of the problems to address in NewKeysPreferencePage 1) Does not remeber show all commands check box 2) needs category column 3) could use description column 4) needs to update sorting for at least name, category, and key There needs to be some kind of "When" filtering ... i.e. debug generates many contexts but they aren't for keybindings. We're not sure what form this would take. PW
One more thing needs to be replaced: Current Description Label with Scrolled Text Box Ali
Created attachment 60868 [details] Sorting is added to NewKeysPreferencePage It saves the "Show all" check box upon closing. And Sorting is also working. I am working on adding a Category column and will replace the current description label. Ali
Created attachment 61014 [details] NewKeyPreferencePage v-02 Following things added: Sorting,"Show All Checkbox" saving, Category Column and a Text area for description with Scroll bars. We could review it on Friday morning and possibly release it for M6. Ali
Ali, I got a change to check out the patch, the behaviour looks good. We need to make 2 modifications before we submit it. 1) we'll use dialog settings instead of a preference to remember show all commands. Use WorkbenchPlugin.getDefault().getDialogSettings(), and then create your own section for the new keys preference page. 2) We should add sort by Category in the GroupBy:None case ... I thought it wouldn't matter, but it does. PW
Created attachment 62303 [details] NewKeyPreferencePage v-03 Modifications requested are included in this patch.......ready to be checked in. Ali
Ali, I get an NPE when I try and run this patch: java.lang.NullPointerException at org.eclipse.ui.internal.keys.NewKeysPreferencePage.createTreeControls(NewKeysPreferencePage.java:1298) at org.eclipse.ui.internal.keys.NewKeysPreferencePage.createContents(NewKeysPreferencePage.java:941) at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:233) at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1421) at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1180) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37) Please have a look and update. I think it has to do with the return values from getDialogSettings(). You should either always assume it's the workbench level and ask for the section, or always assume it's the section that you need. PW
Created attachment 62949 [details] NPE fixed in this patch Paul, I fixed the NPE exception in this patch, try it out and let me know. Ali
Released patch >20070404 PW
Please either make sure the new Keys preference page is complete for M7, or remove the page again for 3.3. Currently, the page is unusable, and removing it now would save a lot of testing energy.
Created attachment 64943 [details] NewKeyPreferencePage v-05 Paul, I didnt take the add/remove image columns out. There is a method selectTreeColumn(MouseEvent event), in NewKeysPreferencePage which supports the functionality of these two columns. For some reason event.x and event.y are not returning the right value. I will investigate it tomorrow morning and might be able to fix it. All the other fixes are in this patch, including the bindingManager change. Ali
(In reply to comment #10) > Created an attachment (id=64943) [details] > NewKeyPreferencePage v-05 Released into HEAD >20070425 > Paul, > > I didnt take the add/remove image columns out. They still work on my linux box. Perhaps it's a problem with the tree on windows. I'd still prefer to remove them, as we have the Add and Remove buttons in the editor area at the bottom. PW
Created attachment 65041 [details] NewKeyPreferencePage v-06 Add and Remove columns are removed. Ali
(In reply to comment #12) > Created an attachment (id=65041) [details] > NewKeyPreferencePage v-06 Released in HEAD >20070426 PW
5 things to work on: 1) add When column to the view 2) remove GroupBy combo 3) use Tree sort direction API 4) add filters for actionSet contexts and *.internal.* contexts from the Advanced button 5) move the description box under the When combo box. PW
Created attachment 65081 [details] NewKeyPreferencePage v-07 Paul, I have added items 1-3 in this patch. I tried to stretch the filter text box all the way to left but I couldnt. Secondly I updated my code and it seems like the previous patch (Add/remove icons removed) is not in head yet, so this patch also includes the last patch. Ali
(In reply to comment #15) > Created an attachment (id=65081) [details] > NewKeyPreferencePage v-07 Released to HEAD >20070426 PW
Created attachment 65134 [details] NewKeyPreferencePage v-08 Paul, Here is the filters code, it works perfect (as far as I tested it). I admit that Code is not pretty, I had to make those tags public so that I could access it from preferencePage and filtersDialog and some other little things. I will clean it up more tomorrow morning. Ali
Created attachment 65137 [details] keys v09 I've changed the advanced dialog so that it doesn't need to deal with dialog settings, but it looks good with two cases: 1) when we change the filters it blanks out the combo box, ignoring the tree selection 2) What should we do if the user has a filtered context already selected for a keybinding? We show it in the tree, but if selected we update its context to In Windows and if you save it we treat it like a deliberate change. We should work these out tomorrow morning. PW
Released some fixes into HEAD >20070427 10:30 1. "Include Unbound Commands" 2. "editing" a system binding works as expected 3. changing the filters leaves the combo When correct 4. there is a label on the User keybinding column Still working on: 5. don't have the tree jump back to the beginning on delete PW
Created attachment 65345 [details] NewKeysPreferencePage v-10 Paul, I fixed two bugs in this patch: 1. Blanking out all fields(dataControls) after delete. 2. Updating the tree after changing the whenCombo. Ali
(In reply to comment #20) > Created an attachment (id=65345) [details] > NewKeysPreferencePage v-10 Slightly modified but released into HEAD >20070429 PW
The work this was to drive is completed, and problems are now being tracked by other bugs. PW
Indeed PW
