Comment 1 Douglas Pollock 2005-11-25 09:13:36 EST

These are auto-generated commands from parsing the legacy action-based extension points.  I just realized how many duplicates there were yesterday, and haven't had a chance to think about it much.

Things I've considered:
(1) Trying to merge them into a single command, and then try to use activeWhen criteria to make sure the handlers become active at the right moment
(2) Don't show uncategorized commands in the keys preference page

Comment 2 Michael Van Meekeren 2006-04-21 13:21:13 EDT

Moving Dougs bugs

Comment 3 Michael Valenta 2006-05-09 14:40:35 EDT

You may already be aware of this but, this looks really bad with Callisto loaded because there are many more duplicates and there are also some commands that are missing strings.

Comment 4 Dani Megert 2007-03-24 07:00:46 EDT

Just wondering as you marked this one as depending on bug 176235: are you planning to pull out the 'Keys' preference page and replace it with the new one?

Comment 5 Paul Webster 2007-03-24 07:07:20 EDT

That's what I'm hoping to do (this will be the 3rd release that platform UI has tried).

The original keys pages won't be deleted, but won't be the default page that's shipped with the SDK.

PW

Comment 6 Markus Keller 2007-05-04 10:23:39 EDT

These zombies became much more apparent on the new Keys preference page. On the old page, they were all 'hidden' in the 'Uncategorized' category, but on the new page, they always show up in the table as soon as 'Include unbound commands' is checked.

Comment 7 Paul Webster 2007-05-04 10:27:50 EDT

A potentially longer term solution might be to display some contributing information.

I'll try and filter them out from the Advanced dialog.
PW

Comment 8 Paul Webster 2007-05-07 12:32:59 EDT

Created attachment 66140 [details]
Filter out uncategorized commands v02

By default, filter out uncategorized commands.
PW

Comment 9 Paul Webster 2007-05-07 12:35:09 EDT

OK, maybe those flags don't work the way I think:-)

Boris, could you please review this change?

Thanx,
pW

Comment 10 Paul Webster 2007-05-07 15:28:43 EDT

Created attachment 66197 [details]
Filter out uncategorized commands v03

OK, without the internal Util or weak hash map.

Just use a special string to set and unset the optimization in PatternFilter.
PW

Comment 11 Paul Webster 2007-05-08 15:16:49 EDT

Created attachment 66348 [details]
Filter out uncategorized commands v04

Match patch to HEAD
PW

Comment 12 Paul Webster 2007-05-10 10:57:53 EDT

Created attachment 66692 [details]
Filter out uncategorized commands v05

Updated to HEAD
PW

Comment 13 Boris Bokowski 2007-05-10 11:04:29 EDT

It looks like there is a NLS key without a value in the .properties file: UncategorizedFilterCheckBox_Text

Comment 14 Boris Bokowski 2007-05-10 11:05:15 EDT

Never mind, the sync view didn't show all outgoing changes.

Comment 15 Boris Bokowski 2007-05-10 11:31:22 EDT

+1 for RC1, with one thing I would like to be documented in PatternFilter:  Can you please file a bug requesting the API change in PatternFilter (making filter non-final) and reference that bug from a comment in filter() and setPattern()?

Comment 16 Paul Webster 2007-05-10 12:13:49 EDT

Added bug 186404 to track the API request for 3.4 and released to HEAD >20070510
PW

Comment 17 Dani Megert 2007-05-15 05:44:24 EDT

Tested on I20070515-0010: the attached image says it all: still visble even though filter is checked.

Comment 18 Dani Megert 2007-05-15 05:45:07 EDT

Created attachment 67205 [details]
Image showing uncategorized commands

Comment 19 Dani Megert 2007-05-15 05:49:27 EDT

Please ignore my previous comments.

Comment 20 Dani Megert 2007-05-15 05:49:47 EDT

Verified in I20070515-0010.