Community
Participate
Working Groups
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169602
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169602 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3127ad094ef9b39db865d907b36bac2b203de744
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e9eb78986f6f4d04ff83e25fa0cdd7375b890d3f
Hi, I'm trying to trace the cause of Bug 568407. Is it possible that changes in this one caused icons to be drawn too big on Linux high DPI?
(In reply to Phil Beauvoir from comment #5) > Hi, I'm trying to trace the cause of Bug 568407. > > Is it possible that changes in this one caused icons to be drawn too big on > Linux high DPI? If, then likely this one: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846 Paul, can you reproduce the problem, and if yes, could you revert this commit and check if that fixes the problem?
Paul, could you please check if changes here caused regression in bug 568407? If yes, we should either fix it or revert *before* 4.18 M3.
Sorry for the late reply, I missed the email from Bugzilla. I'm looking into this now.
Firstly, the incorrect scaling doesn't happen on Fedora, however the icons are not scaling properly. I'm assuming that the icons not scaling in Fedora is equivalent to the large icons on Ubuntu. I can confirm the behavior between the I20200921-1800, and I20200928-1800. I reverted the changes from https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846, however the behavior still remains. The way icons are scaled through the dpiChanged function in ToolItem, and that has not been change in the patch.
(In reply to Soraphol (Paul) Damrongpiriyapong from comment #9) > > > I can confirm the behavior between the I20200921-1800, and I20200928-1800. > To narrow it down, the icons are the right size in I20200922-1800 but large in I20200924-1800.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/173331
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/173331 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5ebd4cd672b570f376545bbf9552a6c3c633fa3a
Snippet 18: Each ToolItem is much larger than in GTK3, making the toolbar take up more space in GTK4. Snippet 36: Each ToolItem is much larger than in GTK3, making the toolbar take up more space in GTK4. Snippet 47: Each ToolItem image is the correct size, but the box its surrounded by is too big horizontally, and the image is not centered in the middle (slightly offset downwards). Furthermore, the "disabled" image has a box around it at all times, which is not correct behavior. Snippet 49: Larger items, but also does not wrap. (This appears to be broken on GTK3 too) Snippet 58: Larger items, combo overlaps with the item to its right (Item 5). Snippet 67: Larger items, and the drop down menu does not appear. Snippet 153: Larger items, status line does not appear at all when mouse enters a ToolItem. Snippet 288: File dialog says "The folder contents could not be displayed" and "Operation not supported". If this is ignored and one of the folders on the left side of the dialog are used, a GIF file can be selected. However, when "Open" is selected, a Segfault occurs at the g_slist_length frame.
