Community
Participate
Working Groups
Created attachment 284618 [details] Screenshot Eclipse 4.18 Version: I20201030-1800 Ubuntu 20.04 I'm running the latest I-build of Eclipse 4.18 with Ubuntu 20.04 with display scaling at 200%. All toolbar icons are now double-sized. This is not happening in Eclipse 4.17 so must be a regression.
I've tested the 4.18 I-builds and found when the regression occurred: I20200921-1800 - OK, the icons are correct size I20200928-1800 - Not OK, the icons are double-sized
Not sure if this is an SWT issue, can anyone advise?
(In reply to Phil Beauvoir from comment #1) > I've tested the 4.18 I-builds and found when the regression occurred: > > I20200921-1800 - OK, the icons are correct size > > I20200928-1800 - Not OK, the icons are double-sized Could you narrow down to the first build where the regression happens, we had many changes in the week? I do not see anything special in SWT, but I see changes in HiDPI imagedescriptior code via bug 567898 (would be I20201023-1800) and in ActionContributionItem via bug 567905 (would be I20201024-1800). Both could be related.
(In reply to Andrey Loskutov from comment #3) > (In reply to Phil Beauvoir from comment #1) > > I've tested the 4.18 I-builds and found when the regression occurred: > > > > I20200921-1800 - OK, the icons are correct size > > > > I20200928-1800 - Not OK, the icons are double-sized > > Could you narrow down to the first build where the regression happens, we > had many changes in the week? I do not see anything special in SWT, but I > see changes in HiDPI imagedescriptior code via bug 567898 (would be > I20201023-1800) and in ActionContributionItem via bug 567905 (would be > I20201024-1800). Both could be related. I can't find links to those builds: https://download.eclipse.org/eclipse/downloads/ Do you have links? Could the committers also test this? Setting the scaling to 200% on Ubuntu or a similar Linux distro and launching a 4.18 Eclipse build will show the problem straight away.
(In reply to Phil Beauvoir from comment #4) > Do you have links? I've uploaded two builds I still had locally: eclipse-SDK-I20201023-0250-linux-gtk-x86_64.tar.gz: https://drive.google.com/file/d/1GmQea4qyL3f1cl0AEgI3FnJT_vNfwZ33/view?usp=sharing eclipse-SDK-I20201025-1800-linux-gtk-x86_64.tar.gz: https://drive.google.com/file/d/1vOwesW-3Ia6tfZZkHyuOC-tt7YcpzL5H/view?usp=sharing > Could the committers also test this? Setting the scaling to 200% on Ubuntu > or a similar Linux distro and launching a 4.18 Eclipse build will show the > problem straight away. :-) Nice try. I have RHEL 7.4 with KDE and no HI DPI monitor, so I have no idea how to change scaling (I can't find nothing related in KDE settings).
(In reply to Phil Beauvoir from comment #0) > All toolbar icons are now double-sized. Not sure if I understand right, but I always though it was the intention of High DPI support that Icons are larger...
I can see this problem with X11 backend. needs further investigation @paul can you try this on wayland backend?
(In reply to Christoph Laeubrich from comment #6) > (In reply to Phil Beauvoir from comment #0) > > All toolbar icons are now double-sized. > > Not sure if I understand right, but I always though it was the intention of > High DPI support that Icons are larger... They are scaled 4 times instead of twice.
The double sized icons are in both builds so this means this problem started in I20201023-0250. > :-) Nice try. I have RHEL 7.4 with KDE and no HI DPI monitor, so I have no idea how to change scaling (I can't find nothing related in KDE settings). I use Linux Mint and Ubuntu in VMWare Fusion on a MacBook which has a high DPI screen. It is possible to set the Display Scale to 150% on Ubuntu 20.04 and on Linux Mint to set the Display scaling to "Double (Hi-DPI)" even without a Hi DPI monitor. Both of these settings will let one do a test and see the problem.
(In reply to Christoph Laeubrich from comment #6) > (In reply to Phil Beauvoir from comment #0) > > All toolbar icons are now double-sized. > > Not sure if I understand right, but I always though it was the intention of > High DPI support that Icons are larger... If you look at the screenshot you can see they are double the double size. Compare the icons in the toolbar with those in the View tabs. https://bugs.eclipse.org/bugs/attachment.cgi?id=284618
(In reply to Phil Beauvoir from comment #9) > The double sized icons are in both builds so this means this problem started > in I20201023-0250. Great, so it is most likely bug 567898. Christoph, could you please check that? > It is possible to set the Display Scale to 150% on Ubuntu 20.04 and on Linux > Mint to set the Display scaling to "Double (Hi-DPI)" even without a Hi DPI > monitor. Nice for Mint, but as said, I see no way to change any display property with KDE on RHEL 7.4.
Hold on, we've got the build dates mixed up. I said: > I20200921-1800 - OK, the icons are correct size > I20200928-1800 - Not OK, the icons are double-sized Those are September I builds.
(In reply to Phil Beauvoir from comment #12) > Hold on, we've got the build dates mixed up. > > I said: > > > I20200921-1800 - OK, the icons are correct size > > I20200928-1800 - Not OK, the icons are double-sized > > Those are September I builds. Arrgh, I've seen your first comment about October version and somehow missed that. Here are three related builds from September I have: https://drive.google.com/drive/folders/0B7vALkuico9heWlDMlhfRGlRbm8?usp=sharing
(In reply to Andrey Loskutov from comment #11) > (In reply to Phil Beauvoir from comment #9) > > The double sized icons are in both builds so this means this problem started > > in I20201023-0250. > > Great, so it is most likely bug 567898. Christoph, could you please check > that? Sorry for noise, wrong I Build month.
(In reply to Andrey Loskutov from comment #13) > (In reply to Phil Beauvoir from comment #12) > > Hold on, we've got the build dates mixed up. > > > > I said: > > > > > I20200921-1800 - OK, the icons are correct size > > > I20200928-1800 - Not OK, the icons are double-sized > > > > Those are September I builds. > > Arrgh, I've seen your first comment about October version and somehow missed > that. > > Here are three related builds from September I have: > https://drive.google.com/drive/folders/ > 0B7vALkuico9heWlDMlhfRGlRbm8?usp=sharing The problem occurs in I20200924-1800.
I looked through the SWT commits for around that date and found this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=567138 Could it be related?
(In reply to Phil Beauvoir from comment #15) > > Here are three related builds from September I have: > > https://drive.google.com/drive/folders/ > > 0B7vALkuico9heWlDMlhfRGlRbm8?usp=sharing > > The problem occurs in I20200924-1800. I've uploaded build I20200922-1800 and I20200924-1800. So the problem does not appear in I20200922-1800, right? (In reply to Phil Beauvoir from comment #16) > I looked through the SWT commits for around that date and found this: > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=567138 > > Could it be related? Bug 567138 changes went into I20200924-1800 build, so could be related, yes. If, then likely this one: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846 Can someone who can reproduce the problem revert this commit and check if that fixes the problem?
(In reply to Andrey Loskutov from comment #17) > (In reply to Phil Beauvoir from comment #15) > > > Here are three related builds from September I have: > > > https://drive.google.com/drive/folders/ > > > 0B7vALkuico9heWlDMlhfRGlRbm8?usp=sharing > > > > The problem occurs in I20200924-1800. > > I've uploaded build I20200922-1800 and I20200924-1800. So the problem does > not appear in I20200922-1800, right? Correct. The problem does not appear in I20200922-1800.
Created attachment 284645 [details] Screenshot of I20200922-1800 Screenshot of I20200922-1800
Created attachment 284647 [details] Screenshot of I20200924-1800 Screenshot of I20200924-1800 where we can see the issue.
Should I change the component setting to "SWT" if this is not "UI"?
Sorry for the late reply, I missed the email when going through my Bugzilla list. Anyways, on Fedora (Wayland) the icons are not doubled sized, but incorrectly scaled and are blurry. I assume that is the Wayland equivalent of this bug. I can confirm the regression does occur between the two builds 0922, and 0928. I went ahead and reverted the changes of https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/169846, however the bug still exists. I'm continuing to look into this.
(In reply to Soraphol (Paul) Damrongpiriyapong from comment #22) > I can confirm the regression does occur between the two builds > 0922, and 0928. > > Actually, occurs in I20200924-1800.
Images are also extra large not just in toolbars and tool items but also in the images used at the top of wizard dialogs.
So the Toolbar bug is not the reason for the regression. The patch that is causing the regression is 566902. I'm working on a patch right now to resolve this.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171861
@Phil, thank you for all the testing by the way. I have submitted a patch that should fix the issue. If you could either check it out and test it or wait till we get an I-build for it, that would be great!
@Paul thank-you for the fast fix and a big thank-you for your contributions to SWT. :-) As soon as this gets into the I build I will test it!
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171861 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4a0a2bea453724e991034dec415daf248e8df49c
Tested I20201105-1800 and it looks good. All images and icons are back to normal size. Thanks, Paul!
Thanks Paul & Phil!
Created attachment 284733 [details] Screenshot of toolbar There's another problem with this issue. When you hover the mouse on the "Debug" and "Run" drop-down toolbar items in Eclipse, the icons change to double-size. See screenshot. Should I re-open this issue?
(In reply to Phil Beauvoir from comment #32) > Created attachment 284733 [details] > Screenshot of toolbar > > There's another problem with this issue. > > When you hover the mouse on the "Debug" and "Run" drop-down toolbar items in > Eclipse, the icons change to double-size. > > See screenshot. > > Should I re-open this issue? Thanks, I will do this for you :-) Paul, could you please check if you could make it for M3 (Monday next week)?
Sorry for the late reply, yesterday was a day off in Canada. I will take a look, I'll try my best to get it by Monday.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172158
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172158 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1f357955fb620bcbbbe6e52a577db656f90fbdd3
Verified fixed on latest I-build: I20201112-1800.
