Bug 545942 - [GTK4] Ensure snippets work on GTK4
Summary: [GTK4] Ensure snippets work on GTK4
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.12   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
Depends on: 567138 567257 567333 568185 568316 571516 574830 546488 546493 546525
Blocks: 540385
  Show dependency tree
 
Reported: 2019-03-29 13:30 EDT by Eric Williams CLA
Modified: 2021-12-01 16:06 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2019-03-29 13:30:40 EDT
Make sure snippets behave as expected on GTK4.
Comment 1 Eric Williams CLA 2019-03-29 15:05:13 EDT
Snippet3: the item row index is 4 rows higher than it should be.

Snippet4: no dialog is opened.

Snippet5: the expanding button does not expand. Buttons have scrollbars for some reason and are drawn outside their shell.

Snippet9: red circle does not expand and is drawn outside its shell.

Snippet10: no image is drawn.

Snippet11 and Snippet12: caret location is incorrect.

Snippet13: broken on GTK3 and GTK4 (see bug 545944)

Snippet16: timer works but does not print "In" when the cursor hovers over the shell.

Snippet17: no events are printed.

Snippet23: no tracker is created.

Snippet29: no menu text is placed on the bar and the menu is empty.

Snippet31: broken on GTK3 and GTK4 (see bug 545945)

Snippet36: SWT.FLAT style isn't working properly.

Snippet39: arrow missing on button, SWT crashes with link error on menu selection "gdk_window_get_display"

Snippet40: no popup menu is shown.

Snippet41: all tooltips work except the shell's.

Snippet43: no caret is created.

Snippet44: hand cursor doesn't revert back to normal after leaving the button.

Snippet46: button does not drag.

Snippet48: crashes GNOME shell.

Snippet49: does not wrap properly.

Snippet50: no dialog appears, error is printed: "Trying to snapshot GtkWindow 0x7f02045f29a0 without a current allocation"
Comment 2 Eclipse Genie CLA 2019-04-03 11:25:55 EDT
New Gerrit change created: https://git.eclipse.org/r/139963
Comment 4 Eric Williams CLA 2019-04-03 15:26:05 EDT
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/139963 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=58cbb11130181f062aef553ee21bcb21bc968945

Fixes the crasher for Snippet39.
Comment 5 Xi Yan CLA 2019-04-16 11:28:56 EDT
Snippet 51: general issue with layout, table not filling entire shell while resizing

Snippet 52: mouse does not scroll table (see Bug 545943)

Snippet 53: mouse does not scroll table (see Bug 545943)

Snippet 55: font does not change (see Bug 502105)

Snippet 58: general issue with layout, middle combo item initial size too small

Snippet 59: mouse does not scroll table (see Bug 545943)

Snippet 61: mouse does not scroll table (see Bug 545943)

Snippet 63: no dialog is opened (see Bug 546483)

Snippet 64: mouse does not scroll table (see Bug 545943)

Snippet 65: issue with layout, item is out of the shell by a fixed offset

Snippet 66: broken on GTK3 and GTK4, no scribble is shown (see bug 546482)

Snippet 67: crashes when opening dropdown, Exception in thread "main" java.lang.UnsatisfiedLinkError: org.eclipse.swt.internal.gtk.OS.memmove(JLorg/eclipse/swt/internal/gtk/GdkEventButton;J)V

Snippet 71: no dialog is opened (see Bug 546483)

Snippet 73: right click does not shown context menu 

Snippet 74: no caret is shown

Snippet 75: tab does not traverse children

Snippet 77: column does not get resized with shell

Snippet 78, 79: crash with Exception in thread "main" java.lang.UnsatisfiedLinkError: org.eclipse.swt.internal.gtk.OS.memmove(JLorg/eclipse/swt/internal/gtk/GtkTargetEntry;J)V

Snippet 82: CTabFolder is not shown

Snippet 84: OS.memmove crash

Snippet 89: no menu is shown

Snippet 90: mouse does not scroll table (see Bug 545943)

Snippet 91: OS.memmove crash

Snippet 94: crash with Exception in thread "main" java.lang.UnsatisfiedLinkError: org.eclipse.swt.internal.gtk.GTK._gtk_clipboard_get(J)J

Snippet 95: Can't take a capture, emits (SWT:14822): Gtk-WARNING **: 11:24:50.941: Trying to snapshot GtkWindow 0x7fe6dc5aec20 without a current allocation

Snippet 96: no text displayed on top of table cursor

Snippet 97: no context menu when right click

Snippet 100: general layout issue, initial text area is out of the shell
Comment 6 Eric Williams CLA 2019-04-16 11:36:32 EDT
Bug 546481 fixed Snippet4 and Snippet 50.
Comment 7 Eric Williams CLA 2019-04-16 14:22:20 EDT
Bug 546488 fixed Snippet44 and the cursor being broken in ControlExample.
Comment 8 Xi Yan CLA 2019-04-16 14:46:57 EDT
Bug 545943 fixed mouse not scrolling in snippet 7,8,52,53,59,61,90,etc..
Comment 9 Lakshmi P Shanmugam CLA 2019-06-03 01:26:29 EDT
@Eric, please close or re-target as required.
Comment 10 Eric Williams CLA 2019-06-03 09:24:42 EDT
Moving into 4.13.
Comment 11 Eric Williams CLA 2019-08-14 19:02:19 EDT
Moving into 4.14 as there is still work to be done.
Comment 12 Eric Williams CLA 2019-11-12 11:51:20 EST
Haven't had time to look at GTK4 lately, untargetting this.
Comment 13 Dani Megert CLA 2020-04-01 03:39:02 EDT
I've removed the 'plan' keyword because no target milestone was set. A plan bug must always have a target milestone.

If you consider to set the 'plan' keyword again, make sure that the target milestone must match the release where it was originally planned. If the work was not finished, a follow-up plan bug for the next release must be created and the old one left in the NEW state. Not doing so would destroy the initial plan. The plan must reflect what has been delivered and what not.

Also, please make sure that you only tag root/top-level bugs with 'plan'. Bug fixes or simple things must not get the 'plan keyword.
Comment 14 Joel Majano CLA 2021-11-19 16:30:08 EST
ControlExample: When maximized, widgets remain the same size as they were before maximizing. 

Dragging the window to make it bigger correctly expands the area the widgets take up, but this does not happen when maximized.