567062 – [Quicksearch] Give indication if search is stopped due to max results limit

Bug 567062 - [Quicksearch] Give indication if search is stopped due to max results limit

Summary: [Quicksearch] Give indication if search is stopped due to max results limit

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Text (show other bugs)
Version:	4.14
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.20 M3
Assignee:	Julian Ruppel
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	567925
	Show dependency tree

Reported:	2020-09-17 05:49 EDT by Paul Pazderski
Modified:	2021-06-23 08:24 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit 574405

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul Pazderski

2020-09-17 05:49:42 EDT

Quicksearch stops the search after a configured amount of results is found (atm roughly 200). There is no indication if search is stopped due to this limit or because all files where searched.
If the search ends and I got a quite long list of results but not the result I expected I cannot know if it was not found or to many other matches found before.

Comment 1 Julian Ruppel

2021-04-15 17:57:47 EDT

With https://bugs.eclipse.org/bugs/show_bug.cgi?id=572693 there will be a counter showing how many results have been found.
I think it makes sense to build on top of this and indicate when a limit is reached.

In addition, since this limit will become more prominent then, we should make it configurable in the preferences.

Ideas?

Comment 2 Eclipse Genie

2021-04-23 17:03:50 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179768

Comment 3 Eclipse Genie

2021-04-26 06:15:14 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179768 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=34b30bce9608a8fab1e06c12fe14e609c0ccb660

Comment 4 Mickael Istria

2021-04-26 06:16:24 EDT

Thanks Julian!
Can you please add a note about it with a small screenshot to the New & Noteworthy document?

Comment 5 Eclipse Genie

2021-04-26 09:35:00 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179834

Comment 6 Julian Ruppel

2021-04-26 09:41:24 EDT

Sure, however, I don't know how to do so ;) Do you have a link at hand?

BTW, I found it confusing that under certain circumstances more results can be found than specified in the limit. Thus, I added a tooltip to explain the situation.
At the same time, I replaced the other tooltips, which were a bit hidden in my opinion, with more obvious info icons.

Comment 7 Eclipse Genie

2021-04-26 12:02:28 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179834 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=9daa731d8511d9c52a956aadceec2e2fbbde33d0

Comment 8 Eclipse Genie

2021-04-26 14:49:25 EDT

New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/179852

Comment 9 Eclipse Genie

2021-04-27 01:42:34 EDT

Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/179852 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=575218d62747adb74ec3c1d9ae664b6d26faec50

Comment 10 Mickael Istria

2021-04-27 02:49:33 EDT

Thanks Julian!