Bug 563714 - Give a chance to remove the title bar
Summary: Give a chance to remove the title bar
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-29 07:48 EDT by Gao Hao CLA
Modified: 2022-03-22 09:12 EDT (History)
6 users (show)

See Also:


Attachments
display information in menu bar instead of title bar(VS Code) (140.16 KB, image/png)
2020-06-12 08:44 EDT, Gao Hao CLA
no flags Details
display information in menu bar instead of title bar(NetBeans) (148.67 KB, image/png)
2020-06-12 09:03 EDT, Gao Hao CLA
no flags Details
display information in menu bar instead of title bar(Intellij IDEA) (236.21 KB, image/png)
2020-06-12 09:07 EDT, Gao Hao CLA
no flags Details
title bar is too tall (91.70 KB, image/png)
2020-06-12 09:46 EDT, Gao Hao CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gao Hao CLA 2020-05-29 07:48:54 EDT
In Windows, the title bar remains white even in dark theme, so why not remove it?

When press `Alt+F11` to enter full-screen mode, the title bar is hidden. Was it possible to hide title bar without entering full screen mode?
Comment 1 Gao Hao CLA 2020-05-29 07:51:43 EDT
The title bar is unnecessary sometimes when for example, detaching a Java Editor or Git staging View.
Comment 2 Andrew Obuchowicz CLA 2020-05-29 07:54:02 EDT
What version of Windows are you using?

https://bugs.eclipse.org/bugs/attachment.cgi?id=282907 shows the title bar being the system accent color, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=563282

I'm not a SWT expert by any means, but isin't showing/hiding the title bar delegated to the native widget toolkit (in this case, Win32)? I'm pretty sure KDE Plasma (Linux desktop) lets you remove the title bar of applications.
Comment 3 Paul Pazderski CLA 2020-05-29 08:07:29 EDT
(In reply to Andrew Obuchowicz from comment #2)
> https://bugs.eclipse.org/bugs/attachment.cgi?id=282907 shows the title bar
> being the system accent color, see
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=563282

There exist an extra option in Windows whether the accent color is used in title bar or not.

(In reply to Andrew Obuchowicz from comment #2)
> I'm not a SWT expert by any means, but isin't showing/hiding the title bar
> delegated to the native widget toolkit (in this case, Win32)? I'm pretty
> sure KDE Plasma (Linux desktop) lets you remove the title bar of
> applications.

Same for Windows. An application can decide if the window should include a title bar. However without that bar you lose any functionality which is provided by the title bar.
Comment 4 Andrew Obuchowicz CLA 2020-05-29 08:12:46 EDT
Thanks for the clarification Paul :)

> However without that bar you lose any functionality which is
> provided by the title bar.

This is a big enough reason to not remove the title bar IMO. Maybe using the system accent color or manually setting the title bar's color through the Windows CSS would be best?
Comment 5 Paul Pazderski CLA 2020-05-29 08:24:30 EDT
(In reply to Andrew Obuchowicz from comment #4)
> Thanks for the clarification Paul :)
> 
> > However without that bar you lose any functionality which is
> > provided by the title bar.
> 
> This is a big enough reason to not remove the title bar IMO. Maybe using the
> system accent color or manually setting the title bar's color through the
> Windows CSS would be best?

There is no way I know to change the title bar color from the application itself and in general is the title bar customization limited to the accent color AFAIK.

There exist concepts (in my opinion horrible concepts) like client-side decoration which would allow custom title bar colors but that is not supported by SWT as far as I know.
Comment 6 Lars Vogel CLA 2020-05-29 08:29:19 EDT
Styling the Windows title bar is covered by Bug 563329. Suggesting to mark this one as dup.
Comment 7 Andrew Obuchowicz CLA 2020-05-29 08:43:42 EDT
> 
> There is no way I know to change the title bar color from the application
> itself and in general is the title bar customization limited to the accent
> color AFAIK.

That's ok, even more reason for us to look into getting Bug 563282 merged :)
Comment 8 Andrew Obuchowicz CLA 2020-05-29 08:47:21 EDT
@Gao Hao

> In Windows, the title bar remains white even in dark theme, so why not remove  > it?

As paul mentioned, the title bar provides functionality for the IDE's main window. Maybe a better solution would be to provide theming for the title bar (eg. using the system accent color).

> The title bar is unnecessary sometimes when for example, detaching a Java 
> Editor or Git staging View.

I'd create a seperate bug for this. Maybe something like: "Allow floating views to disable the title bar"?
Comment 9 Lars Vogel CLA 2020-06-12 08:21:08 EDT

*** This bug has been marked as a duplicate of bug 563329 ***
Comment 10 Gao Hao CLA 2020-06-12 08:44:59 EDT
Created attachment 283255 [details]
display information in menu bar instead of title bar(VS Code)

In VS Code, title bar is removed and title is displayed in menu bar.
If we choose `native` for `Title Bar Style` in VS Code Settings page, title bar will be displayed, but the title bar is white.
Comment 11 Gao Hao CLA 2020-06-12 09:03:23 EDT
Created attachment 283256 [details]
display information in menu bar instead of title bar(NetBeans)

NetBeans can remove title bar and display info in menu bar(a plug-in provide this feature). If I double click the menu bar, NetBeans will change between full screen and maximization.
Eclipse can remove title bar by using the `Alt+F11`, but this shortcut will make Eclipse full-screen.
So, If Eclipse can display info in menu bar and can `Maximize Restore On Double Click`, it would be great.
Comment 12 Gao Hao CLA 2020-06-12 09:07:34 EDT
Created attachment 283257 [details]
display information in menu bar instead of title bar(Intellij IDEA)

Intellij IDEA decided to remove title bar last year/
Comment 13 Gao Hao CLA 2020-06-12 09:46:59 EDT
Created attachment 283259 [details]
title bar is too tall

In some linux machine, title bar is too tall.
You can use the native color for title bar, what about the height of title bar? Will Eclipse control it?
Comment 14 Christian Sarrasin CLA 2022-03-22 08:40:42 EDT
I believe this bug needs reopening.  The alleged duplicate bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=563329 was resolved in 4.22 but - as far as I can tell - it only provided some cosmetic styling of the title bar so it can be adjusted to follow "dark" themes (yay!).

I have attempted to "enable theming" under Preferences->General->Appearances with theme set as "System" but this has made no difference: the title bar is still wasting precious screen real estate (Ubuntu 21.10, GNOME 40.4.0).

How do we get this bug re-opened?
Comment 15 Lars Vogel CLA 2022-03-22 09:12:20 EDT
Not sure if SWT API allows to remove the title bar / move the title bar into the same place as the menu.

Moving to SWT for investigation.