Bug 563329 - [Dark theme] Ability to style the window title bar
Summary: [Dark theme] Ability to style the window title bar
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 4.22 M2   Edit
Assignee: Alexandr Miloslavskiy CLA
QA Contact: Niraj Modi CLA
URL:
Whiteboard:
Keywords: noteworthy
: 576321 (view as bug list)
Depends on:
Blocks: 576614
  Show dependency tree
 
Reported: 2020-05-19 06:02 EDT by Lars Vogel CLA
Modified: 2021-11-15 05:21 EST (History)
8 users (show)

See Also:

Attachments
Screenshot (133.08 KB, image/png)
2020-05-19 06:02 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-19 06:02:29 EDT 
Created attachment 282924 [details]
Screenshot

Similar to Bug 459789 for the Mac, we should allow to put the windows title bar into dark mode on Windows.
Comment 1 Andrew Obuchowicz CLA 2020-05-29 08:44:33 EDT 
See Paul's relevant comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=563714#c5
Comment 2 Lars Vogel CLA 2020-06-12 08:21:08 EDT 
*** Bug 563714 has been marked as a duplicate of this bug. ***
Comment 3 Alexandr Miloslavskiy CLA 2021-09-29 08:55:58 EDT 
*** Bug 576321 has been marked as a duplicate of this bug. ***
Comment 4 Eclipse Genie CLA 2021-10-13 18:12:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458
Comment 5 Alexandr Miloslavskiy CLA 2021-10-13 18:14:49 EDT 
Good news: the necessary API is now documented; this also allows me to use it for older versions of Win10.

Here's the patch.
Comment 7 Niraj Modi CLA 2021-10-18 06:23:00 EDT 
(In reply to Eclipse Genie from comment #6)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=fb22c8ec55bee7b6eb77c862764a4e249176bc8a

Thanks Alexandr for this dark-theme improvement.
We also need N&N entry for 4.22
Comment 8 Lars Vogel CLA 2021-10-18 06:36:20 EDT 
Thanks Alexandr for this feature and Niraj for the review.

Alexandr/ Niraj, do I need to do something in our org.eclipse.e4.ui.swt.internal.win32.DarkThemeProcessor? Currently we only call 			OS.setTheme (isDark);
Comment 9 Alexandr Miloslavskiy CLA 2021-10-18 07:29:53 EDT 
No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249

Lars, would you make a N&N entry?

[1] https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458/6/bundles/org.eclipse.swt/Eclipse+SWT+PI/win32/org/eclipse/swt/internal/win32/OS.java
Comment 10 Lars Vogel CLA 2021-10-18 09:06:48 EDT 
(In reply to Alexandr Miloslavskiy from comment #9)
> No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249
> 
> Lars, would you make a N&N entry?

Yes, will do with tomorrows I-Build.
Comment 11 Eclipse Genie CLA 2021-10-19 04:29:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186647
Comment 12 Eclipse Genie CLA 2021-10-19 04:33:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186648
Comment 15 Niraj Modi CLA 2021-10-22 03:22:15 EDT 
(In reply to Lars Vogel from comment #10)
> (In reply to Alexandr Miloslavskiy from comment #9)
> > No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249
> > 
> > Lars, would you make a N&N entry?
> 
> Yes, will do with tomorrows I-Build.

Thanks Lars for the N&N entry, resolving now.
Comment 16 Vikas Chandra CLA 2021-11-11 05:59:08 EST 
The image in the N&N is greater than 800px whereas the instruction caps the width to 800px.

Can you upload with an image <=800px in width?
Comment 17 Lars Vogel CLA 2021-11-15 05:21:02 EST 
(In reply to Vikas Chandra from comment #16)
> The image in the N&N is greater than 800px whereas the instruction caps the
> width to 800px.
> 
> Can you upload with an image <=800px in width?

Done.
Comment 18 Eclipse Genie CLA 2021-11-15 05:21:37 EST 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/187732