Community
Participate
Working Groups
Created attachment 282905 [details] accent-swt-control.png In Windows and Mac (and I think in some Linux versions), the system defines a color called "accent color" which is the main color of the theme. https://docs.microsoft.com/en-us/windows/uwp/design/style/color#accent-color https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/ This draft gerrit patch adds a SWT.COLOR_SYSTEM_ACCENT constant and a windows implementation The constant is accessible in code and in css themes, as "COLOR-SYSTEM-ACCENT". For instance with bug 497586, it would be possible to use it in Eclipse Theme such as theme-with-accent.png sample In Windows, this color is provided by dwmapi.dll / dwmgetcolorizationcolor method. https://docs.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmgetcolorizationcolor Another way would be to fix the TITLE_BACKGROUND color on windows to reflect this accent color as shown in accent-swt-control.png, it still reflect the legacy title color. Of course its just a draft, with no target milestone. what do you think of this? To be discussed.
Created attachment 282907 [details] theme-with-accent.png
New Gerrit change created: https://git.eclipse.org/r/163170
What was your use case that needed this change?
I think this is an /awesome/ idea!! It'd be a good way to use the active-tab-highlight and keep things consistent with the user's OS colors. I'm personally totally for it :) +1
For the meaning of System Accent color, i think the Windows one is nice: https://docs.microsoft.com/en-us/windows/uwp/design/style/color https://docs.microsoft.com/en-us/windows/uwp/design/style/color#color-principles Use color meaningfully. When color is used sparingly to highlight important elements, it can help create a user interface that is fluid and intuitive. Use color to indicate interactivity. It's a good idea to choose one color to indicate elements of your application that are interactive. For example, many web pages use blue text to denote a hyperlink. Color is personal. In Windows, users can choose an accent color and a light or dark theme, which are reflected throughout their experience. You can choose how to incorporate the user's accent color and theme into your application, personalizing their experience. Color is cultural. Consider how the colors you use will be interpreted by people from different cultures. For example, in some cultures the color blue is associated with virtue and protection, while in others it represents mourning. -- For the uses, I see several use cases, but platform ui team will have probably some: - The one from bug 497586 (theme-with-accent.png) where the Eclipse default theme can be consistent with the user's OS colors - By implementing calc() function in css engine (https://developer.mozilla.org/fr/docs/Web/CSS/calc) we can imagine compute some gradients of the System Accent, making theme more user-color related. like: https://docs.microsoft.com/en-us/windows/uwp/design/style/color#accent-color-palette) - As there is now major releases every 3 months, this draft-integration is a step-forward for better integration of SWT into modern color principles. [1][2][3] [1] https://docs.microsoft.com/fr-fr/windows/uwp/design/style/color [2] https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/ [3] https://material.io/design/color/the-color-system.html#color-theme-creation
Thanks for the explanation. I feel that this change is outside of my scope of interests. I only had a look at the patch because Lars asked me to and I saw some problems with it.
In some linux machine, the title bar's height is extremely high, which is so ugly. So, can you control the height of Eclipse title bar?
(In reply to Gao Hao from comment #7) > In some linux machine, the title bar's height is extremely high, which is so > ugly. So, can you control the height of Eclipse title bar? Please avoid unrelated questions in bug reports.
